From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856F0C433F5 for ; Tue, 12 Apr 2022 08:59:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFE806B0078; Tue, 12 Apr 2022 04:59:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E868E6B007B; Tue, 12 Apr 2022 04:59:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27B86B007D; Tue, 12 Apr 2022 04:59:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id BD6096B0078 for ; Tue, 12 Apr 2022 04:59:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 9529C80E78 for ; Tue, 12 Apr 2022 08:59:21 +0000 (UTC) X-FDA: 79347628122.13.E2EF393 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf21.hostedemail.com (Postfix) with ESMTP id CBAEE1C0004 for ; Tue, 12 Apr 2022 08:59:20 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kd03W5c8jzgYh5; Tue, 12 Apr 2022 16:57:27 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 12 Apr 2022 16:59:13 +0800 Subject: Re: [PATCH 0/4] A few cleanup and fixup patches for migration To: "ying.huang@intel.com" CC: , , , , , , , , , , , , , , , , , , Andrew Morton References: <20220409073846.22286-1-linmiaohe@huawei.com> <880376f0-f480-979b-261f-72cf9475474c@huawei.com> From: Miaohe Lin Message-ID: Date: Tue, 12 Apr 2022 16:59:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: thhp1m49rddo7c1kzo54tb9d5qqxw68g Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Queue-Id: CBAEE1C0004 X-HE-Tag: 1649753960-542409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/4/12 14:33, ying.huang@intel.com wrote: > On Tue, 2022-04-12 at 11:29 +0800, Miaohe Lin wrote: >> On 2022/4/12 10:25, ying.huang@intel.com wrote: >>> On Sat, 2022-04-09 at 15:38 +0800, Miaohe Lin wrote: >>>> Hi everyone, >>>> This series contains a few patches to remove unneeded lock page and >>>> PageMovable check, reduce the rcu lock duration. Also we fix potential >>>> pte_unmap on an not mapped pte. More details can be found in the >>>> respective changelogs. Thanks! >>> >>> It appears that you ignored my comments for the previous version. Can >>> you check it? >> >> I do remember [1] and I tried to make isolate_huge_page consistent with isolate_lru_page. >> But their return value conventions are different. isolate_huge_page return 0 when >> success while isolate_huge_page returns true in this case. So make them consistent >> would lead to many code change. I should have added this in my changelog. > > If you found new problem, you can reply to the original email. Just > don't ignore the comments. Sorry about it. I would take care of this next time. Thanks! > > Best Regards, > Huang, Ying > >> Thanks. >> >> [1] https://lore.kernel.org/linux-mm/8735jsgctq.fsf@yhuang6-desk2.ccr.corp.intel.com/ >> >> >>> >>> Best Regards, >>> Huang, Ying >>> >>>> --- >>>> v1: >>>>   rebase [1] on mainline. >>>> >>>> [1] https://lore.kernel.org/lkml/20220304093409.25829-2-linmiaohe@huawei.com/T/ >>>> --- >>>> Miaohe Lin (4): >>>>   mm/migration: reduce the rcu lock duration >>>>   mm/migration: remove unneeded lock page and PageMovable check >>>>   mm/migration: return errno when isolate_huge_page failed >>>>   mm/migration: fix potential pte_unmap on an not mapped pte >>>> >>>>  include/linux/migrate.h | 2 +- >>>>  include/linux/swapops.h | 4 ++-- >>>>  mm/filemap.c | 10 +++++----- >>>>  mm/hugetlb.c | 2 +- >>>>  mm/migrate.c | 31 +++++++++++++------------------ >>>>  5 files changed, 22 insertions(+), 27 deletions(-) >>>> >>> >>> >>> >>> . >>> >> > > > . >