From: Ding Hui <dinghui@sangfor.com.cn>
To: Naoya Horiguchi <nao.horiguchi@gmail.com>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>, Tony Luck <tony.luck@intel.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/6] mm/hwpoison: mf_mutex for soft offline and unpoison
Date: Tue, 15 Jun 2021 19:41:34 +0800 [thread overview]
Message-ID: <b827a97a-661a-be04-f154-49be6087aa57@sangfor.com.cn> (raw)
In-Reply-To: <20210614021212.223326-2-nao.horiguchi@gmail.com>
On 2021/6/14 10:12, Naoya Horiguchi wrote:
>
> @@ -2171,6 +2177,8 @@ int soft_offline_page(unsigned long pfn, int flags)
> return -EIO;
> }
>
> + mutex_lock(&mf_mutex);
> +
> if (PageHWPoison(page)) {
> pr_info("%s: %#lx page already poisoned\n", __func__, pfn);
> put_ref_page(ref_page);
Did you miss mutex_unlock() here when page already poisoned ?
> @@ -2194,5 +2202,7 @@ int soft_offline_page(unsigned long pfn, int flags)
> __func__, pfn, page->flags, &page->flags);
> }
>
> + mutex_unlock(&mf_mutex);
> +
> return ret;
> }
>
--
Thanks,
- Ding Hui
next prev parent reply other threads:[~2021-06-15 11:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 2:12 [PATCH v1 0/6] mm/hwpoison: fix unpoison_memory() Naoya Horiguchi
2021-06-14 2:12 ` [PATCH v1 1/6] mm/hwpoison: mf_mutex for soft offline and unpoison Naoya Horiguchi
2021-06-15 11:41 ` Ding Hui [this message]
2021-06-15 11:55 ` HORIGUCHI NAOYA(堀口 直也)
2021-06-15 12:42 ` Miaohe Lin
2021-06-16 0:41 ` HORIGUCHI NAOYA(堀口 直也)
2021-06-16 3:14 ` Miaohe Lin
2021-06-14 2:12 ` [PATCH v1 2/6] mm/hwpoison: remove race consideration Naoya Horiguchi
2021-06-15 12:57 ` Ding Hui
2021-06-16 0:11 ` HORIGUCHI NAOYA(堀口 直也)
2021-06-16 0:40 ` Ding Hui
2021-06-14 2:12 ` [PATCH v1 3/6] mm/hwpoison: introduce MF_MSG_PAGETABLE Naoya Horiguchi
2021-06-14 3:06 ` Matthew Wilcox
2021-06-14 3:55 ` HORIGUCHI NAOYA(堀口 直也)
2021-06-14 2:12 ` [PATCH v1 4/6] mm/hwpoison: remove MF_MSG_BUDDY_2ND and MF_MSG_POISONED_HUGE Naoya Horiguchi
2021-06-14 2:12 ` [PATCH v1 5/6] mm/hwpoison: make some kernel pages handlable Naoya Horiguchi
2021-07-28 10:59 ` Ding Hui
2021-07-29 6:54 ` HORIGUCHI NAOYA(堀口 直也)
2021-06-14 2:12 ` [PATCH v1 6/6] mm/hwpoison: fix unpoison_memory() Naoya Horiguchi
2021-06-17 10:00 ` Ding Hui
2021-06-18 8:36 ` HORIGUCHI NAOYA(堀口 直也)
2021-06-19 12:22 ` Ding Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b827a97a-661a-be04-f154-49be6087aa57@sangfor.com.cn \
--to=dinghui@sangfor.com.cn \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nao.horiguchi@gmail.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).