From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73756C433F5 for ; Thu, 9 Sep 2021 08:37:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D50EE61183 for ; Thu, 9 Sep 2021 08:37:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D50EE61183 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1E4F16B0071; Thu, 9 Sep 2021 04:37:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 193D36B0072; Thu, 9 Sep 2021 04:37:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0836B6B0073; Thu, 9 Sep 2021 04:37:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id E87F56B0071 for ; Thu, 9 Sep 2021 04:37:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 919DD184571E8 for ; Thu, 9 Sep 2021 08:37:56 +0000 (UTC) X-FDA: 78567382152.03.3782623 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf25.hostedemail.com (Postfix) with ESMTP id C4A32B000184 for ; Thu, 9 Sep 2021 08:37:55 +0000 (UTC) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4H4sj5190mz8yCN; Thu, 9 Sep 2021 16:33:29 +0800 (CST) Received: from dggema766-chm.china.huawei.com (10.1.198.208) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.8; Thu, 9 Sep 2021 16:37:50 +0800 Received: from [10.174.177.210] (10.174.177.210) by dggema766-chm.china.huawei.com (10.1.198.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Thu, 9 Sep 2021 16:37:49 +0800 Subject: Re: [PATCH] ramfs: fix mount source show for ramfs To: Andrew Morton CC: , , , , , , References: <20210811122811.2288041-1-yangerkun@huawei.com> <720f6c7a-6745-98ad-5c71-7747857a7f01@huawei.com> <20210908153958.19054d439ae59ee3a7e41519@linux-foundation.org> From: yangerkun Message-ID: Date: Thu, 9 Sep 2021 16:37:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210908153958.19054d439ae59ee3a7e41519@linux-foundation.org> Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [10.174.177.210] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggema766-chm.china.huawei.com (10.1.198.208) X-CFilter-Loop: Reflected X-Stat-Signature: owto5376tqnokqwhimj8ypidd7n6e5d8 Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of yangerkun@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=yangerkun@huawei.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C4A32B000184 X-HE-Tag: 1631176675-380570 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2021/9/9 6:39, Andrew Morton =E5=86=99=E9=81=93: > On Wed, 8 Sep 2021 16:56:25 +0800 yangerkun wrot= e: >=20 >> =E5=9C=A8 2021/8/11 20:28, yangerkun =E5=86=99=E9=81=93: >>> ramfs_parse_param does not parse key "source", and will convert >>> -ENOPARAM to 0. This will skip vfs_parse_fs_param_source in >>> vfs_parse_fs_param, which lead always "none" mount source for ramfs. = Fix >>> it by parse "source" in ramfs_parse_param. >>> >>> Signed-off-by: yangerkun >>> --- >>> fs/ramfs/inode.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c >>> index 65e7e56005b8..0d7f5f655fd8 100644 >>> --- a/fs/ramfs/inode.c >>> +++ b/fs/ramfs/inode.c >>> @@ -202,6 +202,10 @@ static int ramfs_parse_param(struct fs_context *= fc, struct fs_parameter *param) >>> struct ramfs_fs_info *fsi =3D fc->s_fs_info; >>> int opt; >>> =20 >>> + opt =3D vfs_parse_fs_param_source(fc, param); >>> + if (opt !=3D -ENOPARAM) >>> + return opt; >>> + >>> opt =3D fs_parse(fc, ramfs_fs_parameters, param, &result); >>> if (opt < 0) { >>> /* >>> >=20 > (top-posting repaired) >=20 >> Hi, this patch seems still leave in linux-next, should we pull it to >> mainline? >=20 > I was hoping for a comment from Al? Hi, Al, Can you help to review this patch... Thanks, Kun. > . >=20