From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F95DC433F5 for ; Mon, 11 Apr 2022 03:26:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95B786B0072; Sun, 10 Apr 2022 23:26:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90AC66B0073; Sun, 10 Apr 2022 23:26:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FB416B0074; Sun, 10 Apr 2022 23:26:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 73D046B0072 for ; Sun, 10 Apr 2022 23:26:46 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 10922EB0 for ; Mon, 11 Apr 2022 03:26:45 +0000 (UTC) X-FDA: 79343161170.01.DCF81A1 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf25.hostedemail.com (Postfix) with ESMTP id F28BCA0006 for ; Mon, 11 Apr 2022 03:26:42 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KcDgM3p7zzBsCY; Mon, 11 Apr 2022 11:22:23 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 11 Apr 2022 11:26:38 +0800 Subject: Re: [PATCH v2 3/9] mm/vmscan: introduce helper function reclaim_page_list() To: Matthew Wilcox CC: , , , , , References: <20220409093500.10329-1-linmiaohe@huawei.com> <20220409093500.10329-4-linmiaohe@huawei.com> <18ac3908-d162-f1ea-e91f-1da203272b74@huawei.com> From: Miaohe Lin Message-ID: Date: Mon, 11 Apr 2022 11:26:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F28BCA0006 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: 7ntscaa94yx6tchiunoux773zskqjdet X-HE-Tag: 1649647602-562597 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/4/11 11:17, Matthew Wilcox wrote: > On Mon, Apr 11, 2022 at 09:53:15AM +0800, Miaohe Lin wrote: >> On 2022/4/9 21:44, Matthew Wilcox wrote: >>> On Sat, Apr 09, 2022 at 05:34:54PM +0800, Miaohe Lin wrote: >>>> + nr_reclaimed = shrink_page_list(page_list, pgdat, &sc, &dummy_stat, false); >>>> + while (!list_empty(page_list)) { >>>> + folio = lru_to_folio(page_list); >>>> + list_del(&folio->lru); >>>> + putback_lru_page(&folio->page); >>> >>> folio_putback_lru() >> >> I thought folio_putback_lru is deliberately not to use because there is no caller of folio_putback_lru now. >> But it seems I was wrong. Will do it in next version. > > Looks like all of the uses of it that I mooted during the last merge > window ended up going away. > > https://lore.kernel.org/all/20220204195852.1751729-47-willy@infradead.org/ > was obsoleted by commit b109b87050df > > https://lore.kernel.org/all/20220204195852.1751729-48-willy@infradead.org/ > and > https://lore.kernel.org/all/20220204195852.1751729-50-willy@infradead.org/ > were also obsoleted by Hugh's mlock changes > > I also sent > https://lore.kernel.org/all/YjJJIrENYb1qFHzl@casper.infradead.org/ > > but never quite got it up to submittable quality. I see. This is really a pity. Many thanks for clarifying. :) > > . >