From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E47C433EF for ; Mon, 7 Feb 2022 11:03:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BC3F6B0075; Mon, 7 Feb 2022 06:03:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06CAF6B0078; Mon, 7 Feb 2022 06:03:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E78306B007B; Mon, 7 Feb 2022 06:03:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id D92396B0075 for ; Mon, 7 Feb 2022 06:03:53 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9827995184 for ; Mon, 7 Feb 2022 11:03:53 +0000 (UTC) X-FDA: 79115698746.30.D0556CF Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf03.hostedemail.com (Postfix) with ESMTP id 0C50120002 for ; Mon, 7 Feb 2022 11:03:52 +0000 (UTC) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Jsjtv1jtXz9sSq; Mon, 7 Feb 2022 12:03:51 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YAmRq4QJUMWg; Mon, 7 Feb 2022 12:03:51 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Jsjtv0l7Pz9sSp; Mon, 7 Feb 2022 12:03:51 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 076C88B770; Mon, 7 Feb 2022 12:03:51 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 17no10m552pl; Mon, 7 Feb 2022 12:03:50 +0100 (CET) Received: from PO20335.IDSI0.si.c-s.fr (unknown [172.25.230.108]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DA3C78B76C; Mon, 7 Feb 2022 12:03:50 +0100 (CET) Received: from PO20335.IDSI0.si.c-s.fr (localhost [127.0.0.1]) by PO20335.IDSI0.si.c-s.fr (8.17.1/8.16.1) with ESMTPS id 217AtJFD1027425 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 7 Feb 2022 11:55:19 +0100 Received: (from chleroy@localhost) by PO20335.IDSI0.si.c-s.fr (8.17.1/8.17.1/Submit) id 217AtJq91027424; Mon, 7 Feb 2022 11:55:19 +0100 X-Authentication-Warning: PO20335.IDSI0.si.c-s.fr: chleroy set sender to christophe.leroy@csgroup.eu using -f From: Christophe Leroy To: Andrew Morton Cc: Christophe Leroy , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH] mm: Outline copy_overflow() Date: Mon, 7 Feb 2022 11:55:18 +0100 Message-Id: X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1644231317; l=2079; s=20211009; h=from:subject:message-id; bh=B2+X2j+KlBBxIWK5drKA6NAvxrzcwOQtuyC1RfeAjSY=; b=bZ5BynnluxfvRODMh3aFzFl1M2ciHtt6MWLm8ji0Xq/x1+XEM1/JqA/RoWq2ey4KtZrThO9aiQFD As+Pc3klDGfKqGr0q+iSl63oUo8kGGNqdyF+pAHaSnm2RB4OIwh3 X-Developer-Key: i=christophe.leroy@csgroup.eu; a=ed25519; pk=HIzTzUj91asvincQGOFx6+ZF5AoUuP9GdOtQChs7Mm0= X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0C50120002 X-Stat-Signature: huzb1csnw3e55okfk6xayqo365i93pgo Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu X-HE-Tag: 1644231832-913859 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: While building a small config with CONFIG_CC_OPTIMISE_FOR_SIZE, I ended up with more than 50 times the following function in vmlinux: c00243bc : c00243bc: 94 21 ff f0 stwu r1,-16(r1) c00243c0: 7c 85 23 78 mr r5,r4 c00243c4: 7c 64 1b 78 mr r4,r3 c00243c8: 3c 60 c0 62 lis r3,-16286 c00243cc: 7c 08 02 a6 mflr r0 c00243d0: 38 63 5e e5 addi r3,r3,24293 c00243d4: 90 01 00 14 stw r0,20(r1) c00243d8: 4b ff 82 45 bl c001c61c <__warn_printk> c00243dc: 0f e0 00 00 twui r0,0 c00243e0: 80 01 00 14 lwz r0,20(r1) c00243e4: 38 21 00 10 addi r1,r1,16 c00243e8: 7c 08 03 a6 mtlr r0 c00243ec: 4e 80 00 20 blr That function being a non conditional warning on an error path, it is not worth inlining. Outline it. This reduces the size of vmlinux by almost 4kbytes. Signed-off-by: Christophe Leroy --- include/linux/thread_info.h | 5 +---- mm/maccess.c | 5 +++++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h index 73a6f34b3847..1087d1e2be5c 100644 --- a/include/linux/thread_info.h +++ b/include/linux/thread_info.h @@ -209,10 +209,7 @@ __bad_copy_from(void); extern void __compiletime_error("copy destination size is too small") __bad_copy_to(void); =20 -static inline void copy_overflow(int size, unsigned long count) -{ - WARN(1, "Buffer overflow detected (%d < %lu)!\n", size, count); -} +void copy_overflow(int size, unsigned long count); =20 static __always_inline __must_check bool check_copy_size(const void *addr, size_t bytes, bool is_source) diff --git a/mm/maccess.c b/mm/maccess.c index d3f1a1f0b1c1..d15c7b2324b4 100644 --- a/mm/maccess.c +++ b/mm/maccess.c @@ -335,3 +335,8 @@ long strnlen_user_nofault(const void __user *unsafe_a= ddr, long count) =20 return ret; } + +void copy_overflow(int size, unsigned long count) +{ + WARN(1, "Buffer overflow detected (%d < %lu)!\n", size, count); +} --=20 2.33.1