From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8516DC433E0 for ; Mon, 10 Aug 2020 07:56:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 46ED62065C for ; Mon, 10 Aug 2020 07:56:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KQtfawXK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46ED62065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A2B886B0006; Mon, 10 Aug 2020 03:56:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B5F18D0001; Mon, 10 Aug 2020 03:56:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85E936B0008; Mon, 10 Aug 2020 03:56:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 6D1186B0006 for ; Mon, 10 Aug 2020 03:56:48 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2B4D5181AC9C6 for ; Mon, 10 Aug 2020 07:56:48 +0000 (UTC) X-FDA: 77133902496.30.knee93_200eec326fd8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id E8E32180B3C85 for ; Mon, 10 Aug 2020 07:56:47 +0000 (UTC) X-HE-Tag: knee93_200eec326fd8 X-Filterd-Recvd-Size: 8847 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 10 Aug 2020 07:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597046206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3gHZrGopRj+/QtDb/9N2USnjAmR/1np+CUt5Rx5vS9w=; b=KQtfawXKM/F5hV8whiR9qBpCObjCZ1tZi2hQqNUX4jhLwz66mQYIXo22RNZNRUqj58UPEM w7gNGSSuRVRZyxKkLXo+qkN0+1+NQmlBDw/k70CUN3SRmul6KZ0WvEi8KT+K9XbbpWY5tp 1b1tZ+WeOlih+Lr797rHeOflGwqTvgg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-CWsEjFvDOfab41_2em0s8w-1; Mon, 10 Aug 2020 03:56:44 -0400 X-MC-Unique: CWsEjFvDOfab41_2em0s8w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6078B800474; Mon, 10 Aug 2020 07:56:42 +0000 (UTC) Received: from [10.36.113.172] (ovpn-113-172.ams2.redhat.com [10.36.113.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 181075D9E7; Mon, 10 Aug 2020 07:56:33 +0000 (UTC) Subject: Re: [PATCH v4 0/6] mm / virtio-mem: support ZONE_MOVABLE To: linux-kernel@vger.kernel.org, Andrew Morton Cc: virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Baoquan He , Jason Wang , "Michael S. Tsirkin" , Michal Hocko , Mike Kravetz , Mike Rapoport , Mike Rapoport , Pankaj Gupta , Qian Cai References: <20200804194142.28279-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63W5Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAjwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat GmbH Message-ID: Date: Mon, 10 Aug 2020 09:56:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200804194142.28279-1-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Rspamd-Queue-Id: E8E32180B3C85 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.08.20 21:41, David Hildenbrand wrote: > @Andrew can we give this a churn and consider it for v5.9 in case there > are no more comments? @Andrew, Ping, so I assume we'll target v5.10? > > Patch #1-#4,#6 have RBss or ACKs, patch #5 is virtio-mem stuff maintained > by me (and MST is aware). > > --- > > When introducing virtio-mem, the semantics of ZONE_MOVABLE were rather > unclear, which is why we special-cased ZONE_MOVABLE such that partially > plugged blocks would never end up in ZONE_MOVABLE. > > Now that the semantics are much clearer (and are documented in patch #6), > let's support partially plugged memory blocks in ZONE_MOVABLE, allowing > partially plugged memory blocks to be online to ZONE_MOVABLE and also > unplugging from such memory blocks. This avoids surprises when onlining > of memory blocks suddenly fails, just because they are not completely > populated by virtio-mem (yet). > > This is especially helpful for testing, but also paves the way for > virtio-mem optimizations, allowing more memory to get reliably unplugged. > > Cleanup has_unmovable_pages() and set_migratetype_isolate(), providing > better documentation of how ZONE_MOVABLE interacts with different kind of > unmovable pages (memory offlining vs. alloc_contig_range()). > > v3 -> v4: > - "mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()" > -- Fix typo in description > - "virtio-mem: don't special-case ZONE_MOVABLE" > -- Add more details why we initialli special-cased ZONE_MOVABLE (via MST) > - "mm: document semantics of ZONE_MOVABLE" > -- Rephrase some parts of documentation (via Mike) > > v2 -> v3: > - "mm: document semantics of ZONE_MOVABLE" > -- Fix a typo > > v1 -> v2: > - "mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()" > -- Move to position 1, add Fixes: tag > -- Drop unused "out:" label > - "mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()" > -- Keep curly braces on "else" case > - Replace "[PATCH v1 5/6] mm/page_alloc: restrict ZONE_MOVABLE optimization > in has_unmovable_pages() to memory offlining" > by "mm: document semantics of ZONE_MOVABLE" > -- Brain dump of what I know about ZONE_MOVABLE > > David Hildenbrand (6): > mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate() > mm/page_alloc: tweak comments in has_unmovable_pages() > mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate() > mm/page_isolation: cleanup set_migratetype_isolate() > virtio-mem: don't special-case ZONE_MOVABLE > mm: document semantics of ZONE_MOVABLE > > drivers/virtio/virtio_mem.c | 47 +++++++------------------------------ > include/linux/mmzone.h | 35 +++++++++++++++++++++++++++ > mm/page_alloc.c | 22 +++++------------ > mm/page_isolation.c | 39 ++++++++++++++---------------- > 4 files changed, 66 insertions(+), 77 deletions(-) > -- Thanks, David / dhildenb