From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE55C43331 for ; Tue, 24 Mar 2020 13:00:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B56F2070A for ; Tue, 24 Mar 2020 13:00:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B56F2070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E68A86B0003; Tue, 24 Mar 2020 09:00:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E17E76B0006; Tue, 24 Mar 2020 09:00:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2DA86B0007; Tue, 24 Mar 2020 09:00:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id BB90F6B0003 for ; Tue, 24 Mar 2020 09:00:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9513C1803DD16 for ; Tue, 24 Mar 2020 13:00:58 +0000 (UTC) X-FDA: 76630265796.14.man44_7ce1fa73a1717 X-HE-Tag: man44_7ce1fa73a1717 X-Filterd-Recvd-Size: 2455 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Mar 2020 13:00:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 59CCEAD39; Tue, 24 Mar 2020 13:00:55 +0000 (UTC) Subject: Re: [PATCH 2/2] Revert "topology: add support for node_to_mem_node() to determine the fallback node" To: Andrew Morton , linux-mm@kvack.org Cc: Joonsoo Kim , Bharata B Rao , Christopher Lameter , David Rientjes , Kirill Tkhai , Mel Gorman , Michael Ellerman , Michal Hocko , Nathan Lynch , Pekka Enberg , PUVICHAKRAVARTHY RAMACHANDRAN , Sachin Sant , Srikar Dronamraju References: <20200320115533.9604-1-vbabka@suse.cz> <20200320115533.9604-2-vbabka@suse.cz> From: Vlastimil Babka Message-ID: Date: Tue, 24 Mar 2020 14:00:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200320115533.9604-2-vbabka@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/20/20 12:55 PM, Vlastimil Babka wrote: > This reverts commit ad2c8144418c6a81cefe65379fd47bbe8344cef2. > > The function node_to_mem_node() was introduced by that commit for use in SLUB > on systems with memoryless nodes, but it turned out to be unreliable on some > architectures/configurations and a simpler solution exists than fixing it up. > > Thus the previous commit "mm, slub: prevent kmalloc_node crashes and memory > leaks" removed the only user of node_to_mem_node() and we can revert the commit > that introduced it. Since the bugfix was fast-tracked to Linus, we can now reference it properly and replace the second paragraph with: Thus commit 0715e6c516f1 ("mm, slub: prevent kmalloc_node crashes and memory leaks") removed the only user of node_to_mem_node() and we can revert the commit that introduced the function.