From: Jason Wang <jasowang@redhat.com>
To: Christoph Hellwig <hch@infradead.org>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration
Date: Thu, 15 Aug 2019 11:28:05 +0800 [thread overview]
Message-ID: <bba46127-ea43-f9f3-eece-0910243782c5@redhat.com> (raw)
In-Reply-To: <20190813164105.GD22640@infradead.org>
On 2019/8/14 上午12:41, Christoph Hellwig wrote:
> On Tue, Aug 13, 2019 at 08:57:07AM -0300, Jason Gunthorpe wrote:
>> On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote:
>>
>>> What kind of issues do you see? Spinlock is to synchronize GUP with MMU
>>> notifier in this series.
>> A GUP that can't sleep can't pagefault which makes it a really weird
>> pattern
> get_user_pages/get_user_pages_fast must not be called under a spinlock.
> We have the somewhat misnamed __get_user_page_fast that just does a
> lookup for existing pages and never faults for a few places that need
> to do that lookup from contexts where we can't sleep.
Yes, I do use __get_user_pages_fast() in the code.
Thanks
next prev parent reply other threads:[~2019-08-15 3:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 5:48 [PATCH V5 0/9] Fixes for vhost metadata acceleration Jason Wang
2019-08-09 5:48 ` [PATCH V5 1/9] vhost: don't set uaddr for invalid address Jason Wang
2019-08-09 5:48 ` [PATCH V5 2/9] vhost: validate MMU notifier registration Jason Wang
2019-08-09 5:48 ` [PATCH V5 3/9] vhost: fix vhost map leak Jason Wang
2019-08-09 5:48 ` [PATCH V5 4/9] vhost: reset invalidate_count in vhost_set_vring_num_addr() Jason Wang
2019-08-09 5:48 ` [PATCH V5 5/9] vhost: mark dirty pages during map uninit Jason Wang
2019-08-09 5:48 ` [PATCH V5 6/9] vhost: don't do synchronize_rcu() in vhost_uninit_vq_maps() Jason Wang
2019-08-09 5:48 ` [PATCH V5 7/9] vhost: do not use RCU to synchronize MMU notifier with worker Jason Wang
2019-08-09 5:48 ` [PATCH V5 8/9] vhost: correctly set dirty pages in MMU notifiers callback Jason Wang
2019-08-09 5:48 ` [PATCH V5 9/9] vhost: do not return -EAGAIN for non blocking invalidation too early Jason Wang
2019-08-10 17:52 ` [PATCH V5 0/9] Fixes for vhost metadata acceleration Michael S. Tsirkin
2019-08-12 2:44 ` Jason Wang
2019-08-12 4:13 ` David Miller
2019-08-12 9:49 ` Michael S. Tsirkin
2019-08-12 13:02 ` Jason Gunthorpe
2019-08-13 8:31 ` Jason Wang
2019-08-13 11:57 ` Jason Gunthorpe
2019-08-13 16:41 ` Christoph Hellwig
2019-08-15 3:28 ` Jason Wang [this message]
2019-08-15 3:26 ` Jason Wang
2019-08-15 19:33 ` Jason Gunthorpe
2019-08-13 8:12 ` Jason Wang
2019-08-19 21:08 ` Michael S. Tsirkin
2019-08-20 2:29 ` Jason Wang
2019-09-01 18:02 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2019-08-07 7:06 [PATCH V4 0/9] Fixes for metadata accelreation Jason Wang
2019-08-07 7:06 ` [PATCH V4 7/9] vhost: do not use RCU to synchronize MMU notifier with worker Jason Wang
2019-08-07 12:07 ` Jason Gunthorpe
2019-08-07 14:02 ` Jason Wang
2019-08-08 12:54 ` Jason Wang
2019-08-10 19:12 ` [PATCH V5 0/9] Fixes for vhost metadata acceleration Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bba46127-ea43-f9f3-eece-0910243782c5@redhat.com \
--to=jasowang@redhat.com \
--cc=hch@infradead.org \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).