From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C70C5C433DB for ; Thu, 11 Feb 2021 10:37:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4F3FC64E9A for ; Thu, 11 Feb 2021 10:37:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F3FC64E9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ADCD56B00B4; Thu, 11 Feb 2021 05:37:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8C896B00B5; Thu, 11 Feb 2021 05:37:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A3D76B00B6; Thu, 11 Feb 2021 05:37:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 840D86B00B4 for ; Thu, 11 Feb 2021 05:37:06 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 532F58249980 for ; Thu, 11 Feb 2021 10:37:06 +0000 (UTC) X-FDA: 77805634452.17.C8DA353 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 687A590009DE for ; Thu, 11 Feb 2021 10:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613039825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RqhIlOOXm2OfTrN0agJ7O4HLKITtUNyiTne5QniNN2I=; b=EnRBFrEAWoBGz9aU0qzkrXn4X5YUmTZWHY0HmjLcM4NzC1ssaxvLT5io1EFJPQlaLMuyya NAcGMIyijGP74fHZt3n7C9HZkE9xokq9ji/kjrfhsPTrJwPJj1W2GpXPIVBBuQjKHeKVn0 xkzgq30YznXZ7ChNoxTbPDzXSBSlbz0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-bUAS80RNMB-1DacjiPlFmA-1; Thu, 11 Feb 2021 05:37:02 -0500 X-MC-Unique: bUAS80RNMB-1DacjiPlFmA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5FB0192CC40; Thu, 11 Feb 2021 10:37:00 +0000 (UTC) Received: from [10.36.114.52] (ovpn-114-52.ams2.redhat.com [10.36.114.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id C53525D9E8; Thu, 11 Feb 2021 10:36:59 +0000 (UTC) Subject: This reply comments on the patch to fixes the missing a blank line warning To: Adithya Chandrakasan , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org References: <20210211072918.376837-1-adithya.chandrakasan@gmail.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Thu, 11 Feb 2021 11:36:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210211072918.376837-1-adithya.chandrakasan@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 687A590009DE X-Stat-Signature: zogdyizuhwsp84f1x5jgpjbspjonwihd Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613039825-300215 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ^ Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject. "mm/util: fix ??? warning" Which raises the question, what is ??? Compiler? static code checker? ... ? Thanks On 11.02.21 08:29, Adithya Chandrakasan wrote: > FILE: mm/util.c:930: WARNING: Missing a blank line after declarations > > Signed-off-by: Adithya Chandrakasan > --- > mm/util.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/util.c b/mm/util.c > index 8c9b7d1e7c49..60286876636d 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) > unsigned int len; > struct mm_struct *mm = get_task_mm(task); > unsigned long arg_start, arg_end, env_start, env_end; > + > if (!mm) > goto out; > if (!mm->arg_end) > -- Thanks, David / dhildenb