From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F496C388F7 for ; Tue, 3 Nov 2020 13:42:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EB7421534 for ; Tue, 3 Nov 2020 13:42:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EB7421534 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cornelisnetworks.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6253E6B0036; Tue, 3 Nov 2020 08:42:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D9E96B0068; Tue, 3 Nov 2020 08:42:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 478B86B006C; Tue, 3 Nov 2020 08:42:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 183FB6B0036 for ; Tue, 3 Nov 2020 08:42:01 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A47B48249980 for ; Tue, 3 Nov 2020 13:42:00 +0000 (UTC) X-FDA: 77443220400.20.part16_5910c42272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 80217180C07A3 for ; Tue, 3 Nov 2020 13:42:00 +0000 (UTC) X-HE-Tag: part16_5910c42272b9 X-Filterd-Recvd-Size: 2838 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 13:41:59 +0000 (UTC) IronPort-SDR: e7+jRYYZmwliGtxUqeVxRezK8c7I3WTkSW4WENIVfFYsSdnEGEWxoZnf+V3VsocWyLMQQlIPuu WkbGc9PpvguQ== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="169184255" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="169184255" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 05:41:58 -0800 IronPort-SDR: 0lkPVRStevKvuHjmGu0t607rGAkskgQQc7fhWgg+x0/0/f4pXQrf7DcMlISLtVecK/WMvhqK7P /Wk6B2w2IaHA== X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="538494148" Received: from ddalessa-mobl.amr.corp.intel.com (HELO [10.254.204.251]) ([10.254.204.251]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 05:41:57 -0800 Subject: Re: [PATCH for-rc v1] IB/hfi1: Move cached value of mm into handler To: Jason Gunthorpe Cc: dledford@redhat.com, Jann Horn , linux-rdma@vger.kernel.org, Mike Marciniszyn , linux-mm@kvack.org, Ira Weiny References: <20201029012243.115730.93867.stgit@awfm-01.aw.intel.com> <20201103002239.GI36674@ziepe.ca> From: Dennis Dalessandro Message-ID: Date: Tue, 3 Nov 2020 08:41:53 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201103002239.GI36674@ziepe.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/2/2020 7:22 PM, Jason Gunthorpe wrote: > On Wed, Oct 28, 2020 at 09:22:43PM -0400, Dennis Dalessandro wrote: > >> Will add a Cc for stable once the patch is finalized. I'd like to get >> some more feedback on this patch especially in the mmu_interval_notifier >> stuff. > > Which mmu_interval_notifier stuff in this patch? > > Can you convert this last usage of mmu_notifier in mmu_rb_handler to > use an interval notifier? I seem to remember thinking it was the right > thing but too complicated for me to attempt The call to mmu_interval_notifier_insert() in set_rcvarray_entry() specifically. Instead of passing the saved mm I changed it to use current. Yes we may be able to convert to the interval notifier for the rest of it. I'd rather do that as a separate patch and get this fixed for 5.10 and in the stable kernels and do that as a for-next sort of thing. -Denny