From: David Hildenbrand <david@redhat.com>
To: Christian Brauner <christian.brauner@ubuntu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Vlastimil Babka <vbabka@suse.cz>,
Suren Baghdasaryan <surenb@google.com>,
Matthew Bobrowski <repnop@google.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Jan Kara <jack@suse.cz>, Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH 1/2] pid: add pidfd_get_task() helper
Date: Fri, 8 Oct 2021 10:47:36 +0200 [thread overview]
Message-ID: <be830537-18e4-d49b-720a-ca40785c4610@redhat.com> (raw)
In-Reply-To: <20211004125050.1153693-2-christian.brauner@ubuntu.com>
On 04.10.21 14:50, Christian Brauner wrote:
> The number of system calls making use of pidfds is constantly
> increasing. Some of those new system calls duplicate the code to turn a
> pidfd into task_struct it refers to. Give them a simple helper for this.
>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Matthew Bobrowski <repnop@google.com>
> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Minchan Kim <minchan@kernel.org>
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
> include/linux/pid.h | 1 +
> kernel/pid.c | 34 ++++++++++++++++++++++++++++++++++
> 2 files changed, 35 insertions(+)
>
> diff --git a/include/linux/pid.h b/include/linux/pid.h
> index af308e15f174..343abf22092e 100644
> --- a/include/linux/pid.h
> +++ b/include/linux/pid.h
> @@ -78,6 +78,7 @@ struct file;
>
> extern struct pid *pidfd_pid(const struct file *file);
> struct pid *pidfd_get_pid(unsigned int fd, unsigned int *flags);
> +struct task_struct *pidfd_get_task(int pidfd, unsigned int *flags);
> int pidfd_create(struct pid *pid, unsigned int flags);
>
> static inline struct pid *get_pid(struct pid *pid)
> diff --git a/kernel/pid.c b/kernel/pid.c
> index efe87db44683..2ffbb87b2ce8 100644
> --- a/kernel/pid.c
> +++ b/kernel/pid.c
> @@ -539,6 +539,40 @@ struct pid *pidfd_get_pid(unsigned int fd, unsigned int *flags)
> return pid;
> }
>
> +/**
> + * pidfd_get_task() - Get the task associated with a pidfd
> + *
> + * @pidfd: pidfd for which to get the task
> + * @flags: flags associated with this pidfd
> + *
> + * Return the task associated with the given pidfd.
> + * Currently, the process identified by @pidfd is always a thread-group leader.
> + * This restriction currently exists for all aspects of pidfds including pidfd
> + * creation (CLONE_PIDFD cannot be used with CLONE_THREAD) and pidfd polling
> + * (only supports thread group leaders).
> + *
> + * Return: On success, the task_struct associated with the pidfd.
> + * On error, a negative errno number will be returned.
Nice doc.
You might want to document what callers of this function are expected to
do to clean up.
> + */
> +struct task_struct *pidfd_get_task(int pidfd, unsigned int *flags)
> +{
> + unsigned int f_flags;
> + struct pid *pid;
> + struct task_struct *task;
> +
> + pid = pidfd_get_pid(pidfd, &f_flags);
> + if (IS_ERR(pid))
> + return ERR_CAST(pid);
> +
> + task = get_pid_task(pid, PIDTYPE_TGID);
> + put_pid(pid);
The code to be replaced always does the put_pid() after the
put_task_struct(). Is this new ordering safe? (didn't check)
> + if (!task)
> + return ERR_PTR(-ESRCH);
> +
> + *flags = f_flags;
> + return task;
> +}
> +
> /**
> * pidfd_create() - Create a new pid file descriptor.
> *
>
I'd have squashed this into the second patch, makes it a lot easier to
review and it's only a MM cleanup at this point.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-10-08 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 12:50 [PATCH 0/2] Introduce simple pidfd to task helper Christian Brauner
2021-10-04 12:50 ` [PATCH 1/2] pid: add pidfd_get_task() helper Christian Brauner
2021-10-08 8:47 ` David Hildenbrand [this message]
2021-10-11 10:45 ` Christian Brauner
2021-10-04 12:50 ` [PATCH 2/2] mm: use pidfd_get_task() Christian Brauner
2021-10-07 22:12 ` [PATCH 0/2] Introduce simple pidfd to task helper Matthew Bobrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be830537-18e4-d49b-720a-ca40785c4610@redhat.com \
--to=david@redhat.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=christian.brauner@ubuntu.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=repnop@google.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).