From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BBCC38A02 for ; Sun, 30 Oct 2022 19:23:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01CE56B0071; Sun, 30 Oct 2022 15:23:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0F206B0073; Sun, 30 Oct 2022 15:23:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD7018E0001; Sun, 30 Oct 2022 15:23:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CAA3A6B0071 for ; Sun, 30 Oct 2022 15:23:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 99C7DA01DC for ; Sun, 30 Oct 2022 19:23:43 +0000 (UTC) X-FDA: 80078590326.21.F3A8F42 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf06.hostedemail.com (Postfix) with ESMTP id 1D792180005 for ; Sun, 30 Oct 2022 19:23:42 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 983B95C003F; Sun, 30 Oct 2022 15:23:42 -0400 (EDT) Received: from imap46 ([10.202.2.96]) by compute5.internal (MEProxy); Sun, 30 Oct 2022 15:23:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com.au; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1667157822; x=1667244222; bh=ki 0w8E89xq1IweuEOycTi68h20ldYBwm17VLVgE61nc=; b=Aw56PXPAHjWEYBtkyS NJsPJp1mWEa26PXS+uhsQraVHhzYyLvCY5LefxNYpM3iMpAMmmoUDMgaJhuDSRB1 GpFIgAP84Ne1U4GiK/2cyNIhjnWpv5roPE9k4016fMj8HWKPTsbuEyjvU6upd19t Hsn2LiOQzJ3uu1Ab3g0tmTPlDGhKrGrzHgmhaeAMPw3tD0uJ9AZJY1e/CPd5ZYSY EkdWAILI2vIYysXEnkv6LJLpH2DQoPAQPOFdjCUXM5+RAoUxDJGOn080VpgwdBDU Eq0kRgfSWWSPakWwzCP4bjNWYcKfnHHh+ZjUQzDrW5ZXYLG0M80fN9w6rzjeanQ5 6T2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1667157822; x=1667244222; bh=ki0w8E89xq1IweuEOycTi68h20ld YBwm17VLVgE61nc=; b=f0WWAltV/OTnTYSijZiq/NryQ+2dT6NnL4p3hSztaVNX qlL7kZb9aAgP3A212eonGOUfnk2bKOt8khbUKQgCBQhu2J7EGVZq8VxHVEr8/1Us fPvoZtaIhUGLydhAiWjDHVTyq8cZGaHjM4m09B/y2JC8NpEmpUcIMuLlz2IQex5p IOjDyAsaS28BkWKtDpdW36SRySf67Jc5SmhIjdsUNZ/it6NnerMtsQEVJ2QNHmW+ Q/kMIfRtHJSUnZXAcJdy+FabIIkdvtK9WWmrLASUDOfTK/9WTFoRQiWqZKOFcAwB gcDqdInCsUr0i/kIed+4QBTZIyeSVtOV8GzGUxLUMw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedruddtgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedflfho hhhnucfvhhhomhhsohhnfdcuoehlihhsthhssehjohhhnhhthhhomhhsohhnrdhfrghsth hmrghilhdrtghomhdrrghuqeenucggtffrrghtthgvrhhnpeekfefhgfdutdeggeejtdev tddvvdekvedvheefheeijefhhffhjeekjefgleevgeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlihhsthhssehjohhhnhhthhhomhhsohhn rdhfrghsthhmrghilhdrtghomhdrrghu X-ME-Proxy: Feedback-ID: ia7894244:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 71A9E2A20080; Sun, 30 Oct 2022 15:23:40 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1087-g968661d8e1-fm-20221021.001-g968661d8 Mime-Version: 1.0 Message-Id: In-Reply-To: <20220913065423.520159-2-feng.tang@intel.com> References: <20220913065423.520159-1-feng.tang@intel.com> <20220913065423.520159-2-feng.tang@intel.com> Date: Sun, 30 Oct 2022 19:23:04 +0000 From: "John Thomson" To: "Feng Tang" , "Andrew Morton" , "Vlastimil Babka" , "Christoph Lameter" , "Pekka Enberg" , "David Rientjes" , "Joonsoo Kim" , "Roman Gushchin" , "Hyeonggon Yoo" <42.hyeyoo@gmail.com>, "Dmitry Vyukov" , "Jonathan Corbet" , "Andrey Konovalov" Cc: "Dave Hansen" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Robin Murphy" , "John Garry" , "Kefeng Wang" Subject: Re: [PATCH v6 1/4] mm/slub: enable debugging memory wasting of kmalloc Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667157823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ki0w8E89xq1IweuEOycTi68h20ldYBwm17VLVgE61nc=; b=uITUxoKlIUsqBKJmoSudvNbr77+AN9AqCyY3uFsEskSqxWgZJ1r+fW52fPMDpIpPX1ke3p gorPjPzNPEmnzCnnZe2SZk7Ib7Y6lA7gv42sIF3/Z7yfDMSixNxH5xwUzyBFTu6w0UpiOV CH7ZtlcC3VC3nqFfL4MfTTeSOlfKGMI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=fastmail.com.au header.s=fm3 header.b=Aw56PXPA; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=f0WWAltV; spf=pass (imf06.hostedemail.com: domain of lists@johnthomson.fastmail.com.au designates 66.111.4.26 as permitted sender) smtp.mailfrom=lists@johnthomson.fastmail.com.au; dmarc=pass (policy=none) header.from=fastmail.com.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667157823; a=rsa-sha256; cv=none; b=6r6vJroLjwHnszetvCRSeEY4yEzxPmKAX2AijKwv6DNC/Sd/S/VaKsnITQHLWDwvc6Ab8P O8v40iboB/cXkXWrK4WERUS7bzelsPUwD9010b68GeO/NsGszXPtiUgVqqqVIAk7l3LmCp KLWo4RLvz9exzE0ANi6cH0an7JrLoXk= X-Stat-Signature: dqg37k5gfjqbq73883b5hsacdxrx8ck7 X-Rspamd-Queue-Id: 1D792180005 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=fastmail.com.au header.s=fm3 header.b=Aw56PXPA; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=f0WWAltV; spf=pass (imf06.hostedemail.com: domain of lists@johnthomson.fastmail.com.au designates 66.111.4.26 as permitted sender) smtp.mailfrom=lists@johnthomson.fastmail.com.au; dmarc=pass (policy=none) header.from=fastmail.com.au X-Rspamd-Server: rspam04 X-HE-Tag: 1667157822-535273 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Sep 2022, at 06:54, Feng Tang wrote: > kmalloc's API family is critical for mm, with one nature that it will > round up the request size to a fixed one (mostly power of 2). Say > when user requests memory for '2^n + 1' bytes, actually 2^(n+1) bytes > could be allocated, so in worst case, there is around 50% memory > space waste. I have a ralink mt7621 router running Openwrt, using the mips ZBOOT kernel, and appear to have bisected a very-nearly-clean kernel v6.1rc-2 boot issue to this commit. I have 3 commits atop 6.1-rc2: fix a ZBOOT compile error, use the Openwrt LZMA options, and enable DEBUG_ZBOOT for my platform. I am compiling my kernel within the Openwrt build system. No guarantees this is not due to something I am doing wrong, but any insight would be greatly appreciated. On UART, No indication of the (once extracted) kernel booting: transfer started ......................................... transfer ok, time=2.01s setting up elf image... OK jumping to kernel code zimage at: 80BA4100 810D4720 Uncompressing Linux at load address 80001000 Copy device tree to address 80B96EE0 Now, booting the kernel... Nothing follows 6edf2576a6cc ("mm/slub: enable debugging memory wasting of kmalloc") reverted, normal boot: transfer started ......................................... transfer ok, time=2.01s setting up elf image... OK jumping to kernel code zimage at: 80BA4100 810D47A4 Uncompressing Linux at load address 80001000 Copy device tree to address 80B96EE0 Now, booting the kernel... [ 0.000000] Linux version 6.1.0-rc2 (john@john) (mipsel-openwrt-linux-musl-gcc (OpenWrt GCC 11.3.0 r19724+16-1521d5f453) 11.3.0, GNU ld (GNU Binutils) 2.37) #0 SMP Fri Oct 28 03:48:10 2022 [ 0.000000] SoC Type: MediaTek MT7621 ver:1 eco:3 [ 0.000000] printk: bootconsole [early0] enabled [ 0.000000] CPU0 revision is: 0001992f (MIPS 1004Kc) [ 0.000000] MIPS: machine is MikroTik RouterBOARD 760iGS [ 0.000000] Initrd not found or empty - disabling initrd [ 0.000000] VPE topology {2,2} total 4 [ 0.000000] Primary instruction cache 32kB, VIPT, 4-way, linesize 32 bytes. [ 0.000000] Primary data cache 32kB, 4-way, PIPT, no aliases, linesize 32 bytes [ 0.000000] MIPS secondary cache 256kB, 8-way, linesize 32 bytes. [ 0.000000] Zone ranges: [ 0.000000] Normal [mem 0x0000000000000000-0x000000000fffffff] [ 0.000000] HighMem empty [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x0000000000000000-0x000000000fffffff] [ 0.000000] Initmem setup node 0 [mem 0x0000000000000000-0x000000000fffffff] [ 0.000000] percpu: Embedded 11 pages/cpu s16064 r8192 d20800 u45056 [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 64960 [ 0.000000] Kernel command line: console=ttyS0,115200 rootfstype=squashfs,jffs2 [ 0.000000] Dentry cache hash table entries: 32768 (order: 5, 131072 bytes, linear) [ 0.000000] Inode-cache hash table entries: 16384 (order: 4, 65536 bytes, linear) [ 0.000000] Writing ErrCtl register=00019146 [ 0.000000] Readback ErrCtl register=00019146 [ 0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off [ 0.000000] Memory: 246220K/262144K available (7455K kernel code, 628K rwdata, 1308K rodata, 3524K init, 245K bss, 15924K reserved, 0K cma-reserved, 0K highmem) [ 0.000000] SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=4, Nodes=1 [ 0.000000] rcu: Hierarchical RCU implementation. boot continues as expected possibly relevant config options: grep -E '(SLUB|SLAB)' .config # SLAB allocator options # CONFIG_SLAB is not set CONFIG_SLUB=y CONFIG_SLAB_MERGE_DEFAULT=y # CONFIG_SLAB_FREELIST_RANDOM is not set # CONFIG_SLAB_FREELIST_HARDENED is not set # CONFIG_SLUB_STATS is not set CONFIG_SLUB_CPU_PARTIAL=y # end of SLAB allocator options # CONFIG_SLUB_DEBUG is not set With this commit reverted: cpuinfo and meminfo system type : MediaTek MT7621 ver:1 eco:3 machine : MikroTik RouterBOARD 760iGS processor : 0 cpu model : MIPS 1004Kc V2.15 BogoMIPS : 586.13 wait instruction : yes microsecond timers : yes tlb_entries : 32 extra interrupt vector : yes hardware watchpoint : yes, count: 4, address/irw mask: [0x0ffc, 0x0ffc, 0x0ffb, 0x0ffb] isa : mips1 mips2 mips32r1 mips32r2 ASEs implemented : mips16 dsp mt Options implemented : tlb 4kex 4k_cache prefetch mcheck ejtag llsc pindexed_dcache userlocal vint perf_cntr_intr_bit cdmm perf shadow register sets : 1 kscratch registers : 0 package : 0 core : 0 VPE : 0 VCED exceptions : not available VCEI exceptions : not available processor : 1 cpu model : MIPS 1004Kc V2.15 BogoMIPS : 586.13 wait instruction : yes microsecond timers : yes tlb_entries : 32 extra interrupt vector : yes hardware watchpoint : yes, count: 4, address/irw mask: [0x0ffc, 0x0ffc, 0x0ffb, 0x0ffb] isa : mips1 mips2 mips32r1 mips32r2 ASEs implemented : mips16 dsp mt Options implemented : tlb 4kex 4k_cache prefetch mcheck ejtag llsc pindexed_dcache userlocal vint perf_cntr_intr_bit cdmm perf shadow register sets : 1 kscratch registers : 0 package : 0 core : 0 VPE : 1 VCED exceptions : not available VCEI exceptions : not available processor : 2 cpu model : MIPS 1004Kc V2.15 BogoMIPS : 586.13 wait instruction : yes microsecond timers : yes tlb_entries : 32 extra interrupt vector : yes hardware watchpoint : yes, count: 4, address/irw mask: [0x0ffc, 0x0ffc, 0x0ffb, 0x0ffb] isa : mips1 mips2 mips32r1 mips32r2 ASEs implemented : mips16 dsp mt Options implemented : tlb 4kex 4k_cache prefetch mcheck ejtag llsc pindexed_dcache userlocal vint perf_cntr_intr_bit cdmm perf shadow register sets : 1 kscratch registers : 0 package : 0 core : 1 VPE : 0 VCED exceptions : not available VCEI exceptions : not available processor : 3 cpu model : MIPS 1004Kc V2.15 BogoMIPS : 586.13 wait instruction : yes microsecond timers : yes tlb_entries : 32 extra interrupt vector : yes hardware watchpoint : yes, count: 4, address/irw mask: [0x0ffc, 0x0ffc, 0x0ffb, 0x0ffb] isa : mips1 mips2 mips32r1 mips32r2 ASEs implemented : mips16 dsp mt Options implemented : tlb 4kex 4k_cache prefetch mcheck ejtag llsc pindexed_dcache userlocal vint perf_cntr_intr_bit cdmm perf shadow register sets : 1 kscratch registers : 0 package : 0 core : 1 VPE : 1 VCED exceptions : not available VCEI exceptions : not available MemTotal: 249744 kB MemFree: 211088 kB MemAvailable: 187364 kB Buffers: 0 kB Cached: 8824 kB SwapCached: 0 kB Active: 1104 kB Inactive: 8860 kB Active(anon): 1104 kB Inactive(anon): 8860 kB Active(file): 0 kB Inactive(file): 0 kB Unevictable: 0 kB Mlocked: 0 kB HighTotal: 0 kB HighFree: 0 kB LowTotal: 249744 kB LowFree: 211088 kB SwapTotal: 0 kB SwapFree: 0 kB Dirty: 0 kB Writeback: 0 kB AnonPages: 1192 kB Mapped: 2092 kB Shmem: 8824 kB KReclaimable: 1704 kB Slab: 9372 kB SReclaimable: 1704 kB SUnreclaim: 7668 kB KernelStack: 592 kB PageTables: 264 kB SecPageTables: 0 kB NFS_Unstable: 0 kB Bounce: 0 kB WritebackTmp: 0 kB CommitLimit: 124872 kB Committed_AS: 14676 kB VmallocTotal: 1040376 kB VmallocUsed: 2652 kB VmallocChunk: 0 kB Percpu: 272 kB Cheers, -- John Thomson