From: Anshuman Khandual <anshuman.khandual@arm.com>
To: kbuild test robot <lkp@intel.com>
Cc: mark.rutland@arm.com, david@redhat.com, catalin.marinas@arm.com,
linux-mm@kvack.org, arunks@codeaurora.org,
cpandya@codeaurora.org, will@kernel.org, ira.weiny@intel.com,
steven.price@arm.com, valentin.schneider@arm.com,
suzuki.poulose@arm.com, Robin.Murphy@arm.com, broonie@kernel.org,
cai@lca.pw, ard.biesheuvel@arm.com, dan.j.williams@intel.com,
linux-arm-kernel@lists.infradead.org, osalvador@suse.de,
kbuild-all@lists.01.org, steve.capper@arm.com,
logang@deltatee.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mgorman@techsingularity.net
Subject: Re: [PATCH V11 1/5] mm/hotplug: Introduce arch callback validating the hot remove range
Date: Mon, 13 Jan 2020 09:36:17 +0530 [thread overview]
Message-ID: <bf4362af-2ba0-9099-985a-7b32fdbc6871@arm.com> (raw)
In-Reply-To: <202001112247.k6CzgJBj%lkp@intel.com>
On 01/11/2020 07:41 PM, kbuild test robot wrote:
> mm/memory_hotplug.c: In function 'check_hotremove_memory_range':
>>> mm/memory_hotplug.c:1027:7: error: implicit declaration of function 'arch_memory_removable'; did you mean 'add_memory_resource'? [-Werror=implicit-function-declaration]
> rc = arch_memory_removable(start, size);
> ^~~~~~~~~~~~~~~~~~~~~
> add_memory_resource
> At top level:
> mm/memory_hotplug.c:1017:12: warning: 'check_hotremove_memory_range' defined but not used [-Wunused-function]
> static int check_hotremove_memory_range(u64 start, u64 size)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> vim +1027 mm/memory_hotplug.c
>
> 1016
> 1017 static int check_hotremove_memory_range(u64 start, u64 size)
> 1018 {
> 1019 int rc;
> 1020
> 1021 BUG_ON(check_hotplug_memory_range(start, size));
> 1022
> 1023 /*
> 1024 * First check if the platform is willing to have this
> 1025 * memory range removed else just abort.
> 1026 */
>> 1027 rc = arch_memory_removable(start, size);
> 1028 if (!rc)
> 1029 return -EINVAL;
> 1030
> 1031 return 0;
> 1032 }
> 1033
Both the build failures reported here could be solved by moving
check_hotremove_memory_range() inside CONFIG_MEMORY_HOTREMOVE
wrappers, will fix it.
- Anshuman
next prev parent reply other threads:[~2020-01-13 4:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 3:09 [PATCH V11 0/5] arm64/mm: Enable memory hot remove Anshuman Khandual
2020-01-10 3:09 ` [PATCH V11 1/5] mm/hotplug: Introduce arch callback validating the hot remove range Anshuman Khandual
2020-01-10 8:42 ` David Hildenbrand
2020-01-13 9:11 ` Anshuman Khandual
2020-01-13 9:14 ` David Hildenbrand
2020-01-13 9:50 ` Anshuman Khandual
2020-01-13 10:37 ` David Hildenbrand
2020-01-14 2:13 ` Anshuman Khandual
2020-01-14 11:09 ` Anshuman Khandual
2020-01-14 12:30 ` David Hildenbrand
2020-01-11 14:11 ` kbuild test robot
2020-01-13 4:06 ` Anshuman Khandual [this message]
2020-01-11 19:49 ` kbuild test robot
2020-01-10 3:09 ` [PATCH V11 2/5] mm/memblock: Introduce MEMBLOCK_BOOT flag Anshuman Khandual
2020-01-13 7:37 ` Mike Rapoport
2020-01-13 8:43 ` Anshuman Khandual
2020-01-13 8:57 ` David Hildenbrand
2020-01-10 3:09 ` [PATCH V11 3/5] of/fdt: Mark boot memory with MEMBLOCK_BOOT Anshuman Khandual
2020-01-10 3:09 ` [PATCH V11 4/5] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump Anshuman Khandual
2020-01-10 3:09 ` [PATCH V11 5/5] arm64/mm: Enable memory hot remove Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4362af-2ba0-9099-985a-7b32fdbc6871@arm.com \
--to=anshuman.khandual@arm.com \
--cc=Robin.Murphy@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@arm.com \
--cc=arunks@codeaurora.org \
--cc=broonie@kernel.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=logang@deltatee.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=steve.capper@arm.com \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).