From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC395C433DB for ; Wed, 10 Feb 2021 17:21:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22AA864E7E for ; Wed, 10 Feb 2021 17:21:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22AA864E7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D8B36B0006; Wed, 10 Feb 2021 12:21:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 460E26B006E; Wed, 10 Feb 2021 12:21:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DB566B0071; Wed, 10 Feb 2021 12:21:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 16BB46B0006 for ; Wed, 10 Feb 2021 12:21:58 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C3AC4180ACF0D for ; Wed, 10 Feb 2021 17:21:57 +0000 (UTC) X-FDA: 77803025874.16.C352E6A Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP id 6E528A0000FF for ; Wed, 10 Feb 2021 17:21:57 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B5C2A64EBC; Wed, 10 Feb 2021 17:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612977716; bh=lxipoW35mWSIBNIGbM7Z2K+aGwYJwr9dKY4OANlak7k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GGr4C1jJH4Zp9a/mEIU72UybzoYaT9/TIZxXNQmm5bAT/zvaeeSglDED9fUewnpO7 BrYrmiMW+g9SlVPVQksfYgQAbIVF0MTKkmMfi6NjxV87X1h2j8kZIMaBemRGPmn7+4 ZC1DyPS/e74GCSezb1hpd4YqPlSuerNNkhZdoLgis7oXUugfa5Lp86K7MOaToF8nkY Euzi9bVksgdHYqKG+3cp+jI3MXdlyDiTu6Or/oIdGHWPIOg5OUhFyWq1Z574CStmXU /Sq0uns4Ac01xgy0nc3+py4R0tedjVGEpLlH/raD2rf/eJctQlOCrCNFZzIHi93eN+ 0gsZ67yEPIsbw== Subject: Re: [PATCH 0/3][RESEND] add support for never printing hashed addresses To: Steven Rostedt , Tetsuo Handa Cc: Petr Mladek , Sergey Senozhatsky , Vlastimil Babka , Andy Shevchenko , Matthew Wilcox , akpm@linux-foundation.org, Linus Torvalds , roman.fietze@magna.com, Kees Cook , John Ogness , akinobu.mita@gmail.com, glider@google.com, Andrey Konovalov , Marco Elver , Rasmus Villemoes , Pavel Machek , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210210051814.845713-1-timur@kernel.org> <6da0be5a-7cb0-4943-e61f-7c3275e60cb6@i-love.sakura.ne.jp> <20210210111836.2468f10a@gandalf.local.home> <20210210114633.1b755f6e@gandalf.local.home> From: Timur Tabi Message-ID: Date: Wed, 10 Feb 2021 11:21:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210210114633.1b755f6e@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: z61bdqhh5uqamm9tgsbc371iyi8unhwm X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6E528A0000FF Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612977717-311868 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/10/21 10:46 AM, Steven Rostedt wrote: > Now the question is, why do you need the unhashed pointer? > > Currently, the instruction pointer is what is fine right? You get the > a function and its offset. If there's something that is needed, perhaps we > should look at how to fix that, instead of just unhashing all pointers by > default. The original version of this patch only fixed print_hex_dump(), because hashed addresses didn't make any sense for that. Each address is incremented by 16 or 32, but since they were all hashed, they may as well have been random numbers.