From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62C3C10F25 for ; Sun, 8 Mar 2020 03:20:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 721212072C for ; Sun, 8 Mar 2020 03:20:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 721212072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 26E1C6B0006; Sat, 7 Mar 2020 22:20:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D1066B0007; Sat, 7 Mar 2020 22:20:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E6F36B0008; Sat, 7 Mar 2020 22:20:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id E9B636B0006 for ; Sat, 7 Mar 2020 22:20:44 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7BD212466 for ; Sun, 8 Mar 2020 03:20:44 +0000 (UTC) X-FDA: 76570742808.15.show11_5dc1fd61cb711 X-HE-Tag: show11_5dc1fd61cb711 X-Filterd-Recvd-Size: 2810 Received: from smtprelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Sun, 8 Mar 2020 03:20:44 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id E3356180A5B05; Sun, 8 Mar 2020 03:20:43 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: night89_5d7274ac97a01 X-Filterd-Recvd-Size: 1736 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Sun, 8 Mar 2020 03:20:42 +0000 (UTC) Message-ID: Subject: Re: [PATCH] mm: Use fallthrough; From: Joe Perches To: Sergey Senozhatsky Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Date: Sat, 07 Mar 2020 19:19:04 -0800 In-Reply-To: <20200308031634.GA1125@jagdpanzerIV.localdomain> References: <20200308031634.GA1125@jagdpanzerIV.localdomain> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 2020-03-08 at 12:16 +0900, Sergey Senozhatsky wrote: > On (20/03/06 23:58), Joe Perches wrote: > [..] > > --- a/mm/zsmalloc.c > > +++ b/mm/zsmalloc.c > > @@ -424,7 +424,7 @@ static void *zs_zpool_map(void *pool, unsigned long handle, > > case ZPOOL_MM_WO: > > zs_mm = ZS_MM_WO; > > break; > > - case ZPOOL_MM_RW: /* fall through */ > > + case ZPOOL_MM_RW: > > default: > > zs_mm = ZS_MM_RW; > > break; > > Seems like missing fallthrough; for ZPOOL_MM_RW? Consecutive case labels do not need an interleaving fallthrough