From: David Hildenbrand <david@redhat.com>
To: David Howells <dhowells@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hillf Danton <hdanton@sina.com>,
Christian Brauner <brauner@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH v19 01/15] splice: Clean up direct_splice_read() a bit
Date: Wed, 15 Mar 2023 19:58:21 +0100 [thread overview]
Message-ID: <c1006976-8166-ca52-33db-d2eda8d8792e@redhat.com> (raw)
In-Reply-To: <20230315163549.295454-2-dhowells@redhat.com>
On 15.03.23 17:35, David Howells wrote:
> Do a couple of cleanups to direct_splice_read():
>
> (1) Cast to struct page **, not void *.
>
> (2) Simplify the calculation of the number of pages to keep/reclaim in
> direct_splice_read().
>
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> cc: Jens Axboe <axboe@kernel.dk>
> cc: Al Viro <viro@zeniv.linux.org.uk>
> cc: David Hildenbrand <david@redhat.com>
> cc: John Hubbard <jhubbard@nvidia.com>
> cc: linux-mm@kvack.org
> cc: linux-block@vger.kernel.org
> cc: linux-fsdevel@vger.kernel.org
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-03-15 18:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 16:35 [PATCH v19 00/15] splice, block: Use page pinning and kill ITER_PIPE David Howells
2023-03-15 16:35 ` [PATCH v19 01/15] splice: Clean up direct_splice_read() a bit David Howells
2023-03-15 18:58 ` David Hildenbrand [this message]
2023-03-15 16:35 ` [PATCH v19 02/15] splice: Make do_splice_to() generic and export it David Howells
2023-03-15 18:59 ` David Hildenbrand
2023-03-15 16:35 ` [PATCH v19 03/15] shmem: Implement splice-read David Howells
2023-03-15 16:35 ` [PATCH v19 04/15] overlayfs: " David Howells
2023-03-16 10:47 ` Christian Brauner
2023-03-16 13:14 ` David Hildenbrand
2023-03-15 16:35 ` [PATCH v19 05/15] coda: " David Howells
2023-03-15 16:35 ` [PATCH v19 06/15] tty, proc, kernfs, random: Use direct_splice_read() David Howells
2023-03-15 16:35 ` [PATCH v19 07/15] splice: Do splice read from a file without using ITER_PIPE David Howells
2023-03-16 10:43 ` Christian Brauner
2023-03-15 16:35 ` [PATCH v19 08/15] cifs: Use generic_file_splice_read() David Howells
2023-03-15 16:35 ` [PATCH v19 09/15] iov_iter: Kill ITER_PIPE David Howells
2023-03-16 10:51 ` Christian Brauner
2023-03-15 16:35 ` [PATCH v19 10/15] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-03-15 16:35 ` [PATCH v19 11/15] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-03-15 16:35 ` [PATCH v19 12/15] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-03-15 16:35 ` [PATCH v19 13/15] block: Add BIO_PAGE_PINNED and associated infrastructure David Howells
2023-03-15 16:35 ` [PATCH v19 14/15] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-03-15 16:35 ` [PATCH v19 15/15] block: convert bio_map_user_iov " David Howells
2023-03-15 17:00 ` [PATCH v19 00/15] splice, block: Use page pinning and kill ITER_PIPE Linus Torvalds
2023-03-15 17:47 ` Jens Axboe
2023-03-20 13:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1006976-8166-ca52-33db-d2eda8d8792e@redhat.com \
--to=david@redhat.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).