From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=cKhE=X4=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 812DAC10F14
	for <linux-mm@archiver.kernel.org>; Thu,  3 Oct 2019 20:40:44 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 2E524207FF
	for <linux-mm@archiver.kernel.org>; Thu,  3 Oct 2019 20:40:44 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="OvJoiMhG"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E524207FF
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id AC75A8E0005; Thu,  3 Oct 2019 16:40:43 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id A9D246B000A; Thu,  3 Oct 2019 16:40:43 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 9B17F8E0005; Thu,  3 Oct 2019 16:40:43 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217])
	by kanga.kvack.org (Postfix) with ESMTP id 79EE26B0007
	for <linux-mm@kvack.org>; Thu,  3 Oct 2019 16:40:43 -0400 (EDT)
Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay05.hostedemail.com (Postfix) with SMTP id E9350181AC9AE
	for <linux-mm@kvack.org>; Thu,  3 Oct 2019 20:40:42 +0000 (UTC)
X-FDA: 76003641924.08.straw88_2341e6374cd1b
X-HE-Tag: straw88_2341e6374cd1b
X-Filterd-Recvd-Size: 6256
Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65])
	by imf45.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Thu,  3 Oct 2019 20:40:42 +0000 (UTC)
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
	id <B5d965cc80000>; Thu, 03 Oct 2019 13:40:40 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Thu, 03 Oct 2019 13:40:40 -0700
X-PGP-Universal: processed;
	by hqpgpgate102.nvidia.com on Thu, 03 Oct 2019 13:40:40 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 3 Oct
 2019 20:40:40 +0000
Received: from [10.110.48.28] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 3 Oct 2019
 20:40:38 +0000
Subject: Re: [PATCH v5 01/11] asm-generic/pgtable: Adds generic functions to
 monitor lockless pgtable walks
To: Peter Zijlstra <peterz@infradead.org>, Leonardo Bras
	<leonardo@linux.ibm.com>
CC: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<kvm-ppc@vger.kernel.org>, <linux-arch@vger.kernel.org>,
	<linux-mm@kvack.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>,
	"Arnd Bergmann" <arnd@arndb.de>, Aneesh Kumar K.V
	<aneesh.kumar@linux.ibm.com>, Christophe Leroy <christophe.leroy@c-s.fr>,
	Nicholas Piggin <npiggin@gmail.com>, Andrew Morton
	<akpm@linux-foundation.org>, "Mahesh Salgaonkar" <mahesh@linux.vnet.ibm.com>,
	Reza Arbab <arbab@linux.ibm.com>, Santosh Sivaraj <santosh@fossix.org>,
	Balbir Singh <bsingharora@gmail.com>, Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mike Rapoport
	<rppt@linux.ibm.com>, "Allison Randal" <allison@lohutok.net>, Jason Gunthorpe
	<jgg@ziepe.ca>, Dan Williams <dan.j.williams@intel.com>, Vlastimil Babka
	<vbabka@suse.cz>, "Christoph Lameter" <cl@linux.com>, Logan Gunthorpe
	<logang@deltatee.com>, "Andrey Ryabinin" <aryabinin@virtuozzo.com>, Alexey
 Dobriyan <adobriyan@gmail.com>, Souptick Joarder <jrdr.linux@gmail.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Ralph Campbell
	<rcampbell@nvidia.com>, Jesper Dangaard Brouer <brouer@redhat.com>, Jann Horn
	<jannh@google.com>, Davidlohr Bueso <dave@stgolabs.net>, Ingo Molnar
	<mingo@kernel.org>, Christian Brauner <christian.brauner@ubuntu.com>, Michal
 Hocko <mhocko@suse.com>, Elena Reshetova <elena.reshetova@intel.com>, "Roman
 Gushchin" <guro@fb.com>, Andrea Arcangeli <aarcange@redhat.com>, Al Viro
	<viro@zeniv.linux.org.uk>, "Dmitry V. Levin" <ldv@altlinux.org>,
	=?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>, Song Liu
	<songliubraving@fb.com>, Bartlomiej Zolnierkiewicz
	<b.zolnierkie@samsung.com>, Ira Weiny <ira.weiny@intel.com>, "Kirill A.
 Shutemov" <kirill.shutemov@linux.intel.com>, Keith Busch
	<keith.busch@intel.com>, Paul McKenney <Paul.McKenney@us.ibm.com>
References: <20191003013325.2614-1-leonardo@linux.ibm.com>
 <20191003013325.2614-2-leonardo@linux.ibm.com>
 <20191003071145.GM4536@hirez.programming.kicks-ass.net>
 <20191003115141.GJ4581@hirez.programming.kicks-ass.net>
From: John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <c127ee98-094b-d5c0-0a42-6d01c16a72d9@nvidia.com>
Date: Thu, 3 Oct 2019 13:40:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191003115141.GJ4581@hirez.programming.kicks-ass.net>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1570135241; bh=oygYxcAudWTOP6aOcR5gJi5qvCLemgS4yrH5ULKuCPM=;
	h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
	 Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
	 X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
	 Content-Transfer-Encoding;
	b=OvJoiMhGmIDpiVNUmKclWvLO36Hu8mVLDqpSVxfPfxDWXLj1Qk/5tzPSf6+BvLm7X
	 HRUA5Mhctx9Sc1Z5x6G1w2/73K8d4qxY6qeNP5M8cj786M3ap3d4QR9pBTAaBmDrby
	 H3YMPNpBCkSyQC2dSpCe0dxg+9J5AqHgejWrIEuH09XsWwjshvUkQJ3ywDH98/Yppq
	 6Sni4ipqB3M5ld/Y1KReGpdtZEZ5gITxBSrOdu2NL56bycs63l62mtl7jlF323b6ri
	 UM4KhehiRZ+BCzZrBifRD6LZyOIcKdx6P35tDKFBbmCc9hFSegBapQxblpFYKQGbWn
	 6FWA9PZbDvQZA==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 10/3/19 4:51 AM, Peter Zijlstra wrote:
> On Thu, Oct 03, 2019 at 09:11:45AM +0200, Peter Zijlstra wrote:
>> On Wed, Oct 02, 2019 at 10:33:15PM -0300, Leonardo Bras wrote:
...
> 
> I'm still really confused about this barrier. It just doesn't make
> sense.
> 
> If an interrupt happens before the local_irq_disable()/save(), then it
> will discard any and all speculation that would be in progress to handle
> the exception.
> 

Hi Peter,

So, would that imply that it's correct to apply approximately the following
patch:

diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
index 1adbb8a371c7..cf41eff37e24 100644
--- a/Documentation/memory-barriers.txt
+++ b/Documentation/memory-barriers.txt
@@ -2099,9 +2099,9 @@ INTERRUPT DISABLING FUNCTIONS
 -----------------------------
 
 Functions that disable interrupts (ACQUIRE equivalent) and enable interrupts
-(RELEASE equivalent) will act as compiler barriers only.  So if memory or I/O
-barriers are required in such a situation, they must be provided from some
-other means.
+(RELEASE equivalent) will act as full memory barriers. This is because, for
+all supported CPU architectures, interrupt arrival causes all speculative
+memory accesses to be discarded.
 
?

We're also discussing this over in [1] ("mm: don't expose non-hugetlb page to
fast gup prematurely"), so I'm adding Paul to this thread here as well.

[1] https://lore.kernel.org/r/20191002092447.GC9320@quack2.suse.cz

thanks,
-- 
John Hubbard
NVIDIA