From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69273C4338F for ; Fri, 20 Aug 2021 15:49:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE8D46113B for ; Fri, 20 Aug 2021 15:49:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EE8D46113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5DB9D8D0001; Fri, 20 Aug 2021 11:49:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 565186B0073; Fri, 20 Aug 2021 11:49:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4535F8D0001; Fri, 20 Aug 2021 11:49:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 279506B0072 for ; Fri, 20 Aug 2021 11:49:27 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BF8E882DC4F0 for ; Fri, 20 Aug 2021 15:49:26 +0000 (UTC) X-FDA: 78495893532.01.4880D83 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf03.hostedemail.com (Postfix) with ESMTP id 3C61730000A6 for ; Fri, 20 Aug 2021 15:49:26 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-131-DAGKzonBN4SYNa4fYJu3Dw-1; Fri, 20 Aug 2021 16:49:23 +0100 X-MC-Unique: DAGKzonBN4SYNa4fYJu3Dw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 20 Aug 2021 16:49:22 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.023; Fri, 20 Aug 2021 16:49:22 +0100 From: David Laight To: 'Jeff Layton' , "torvalds@linux-foundation.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: "ebiederm@xmission.com" , "david@redhat.com" , "willy@infradead.org" , "linux-nfs@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "linux-doc@vger.kernel.org" , "v9fs-developer@lists.sourceforge.net" , "linux-afs@lists.infradead.org" , "cluster-devel@redhat.com" , "ocfs2-devel@oss.oracle.com" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "luto@kernel.org" , "bfields@fieldses.org" , "w@1wt.eu" , "rostedt@goodmis.org" , "stable@vger.kernel.org" Subject: RE: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks Thread-Topic: [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks Thread-Index: AQHXlctJ2CxbK7rVbku/gUAYi8DQHat8icSQ Date: Fri, 20 Aug 2021 15:49:22 +0000 Message-ID: References: <20210820135707.171001-1-jlayton@kernel.org> <20210820135707.171001-2-jlayton@kernel.org> In-Reply-To: <20210820135707.171001-2-jlayton@kernel.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=ACULAB.COM; spf=pass (imf03.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com X-Stat-Signature: etw4bmocewdjs5y6a83sbsx8y7166puw X-Rspamd-Queue-Id: 3C61730000A6 X-Rspamd-Server: rspam01 X-HE-Tag: 1629474566-386439 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jeff Layton > Sent: 20 August 2021 14:57 >=20 > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros > have disabled it. Warn the stragglers that still use "-o mand" that > we'll be dropping support for that mount option. >=20 > Cc: stable@vger.kernel.org > Signed-off-by: Jeff Layton > --- > fs/namespace.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/fs/namespace.c b/fs/namespace.c > index ab4174a3c802..ffab0bb1e649 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void) > } >=20 > #ifdef=09CONFIG_MANDATORY_FILE_LOCKING > +static bool warned_mand; > static inline bool may_mandlock(void) > { > +=09if (!warned_mand) { > +=09=09warned_mand =3D true; > +=09=09pr_warn("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); > +=09=09pr_warn("WARNING: the mand mount option is being deprecated and\n"= ); > +=09=09pr_warn(" will be removed in v5.15!\n"); > +=09=09pr_warn("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n"); > +=09} > =09return capable(CAP_SYS_ADMIN); > } If that is called more than once you don't want the 'inline'. I doubt it matters is not inlined - hardly a hot path. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)