From: Vlastimil Babka <vbabka@suse.cz>
To: Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@kernel.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrea Arcangeli <aarcange@redhat.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 4/4] hugetlbfs: don't retry when pool page allocations start to fail
Date: Tue, 6 Aug 2019 10:03:42 +0200 [thread overview]
Message-ID: <c13c0c78-55d1-b2e2-c24b-897ce2469410@suse.cz> (raw)
In-Reply-To: <20190806014744.15446-5-mike.kravetz@oracle.com>
On 8/6/19 3:47 AM, Mike Kravetz wrote:
> When allocating hugetlbfs pool pages via /proc/sys/vm/nr_hugepages,
> the pages will be interleaved between all nodes of the system. If
> nodes are not equal, it is quite possible for one node to fill up
> before the others. When this happens, the code still attempts to
> allocate pages from the full node. This results in calls to direct
> reclaim and compaction which slow things down considerably.
>
> When allocating pool pages, note the state of the previous allocation
> for each node. If previous allocation failed, do not use the
> aggressive retry algorithm on successive attempts. The allocation
> will still succeed if there is memory available, but it will not try
> as hard to free up memory.
>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Thanks.
prev parent reply other threads:[~2019-08-06 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 1:47 [PATCH v2 0/4] address hugetlb page allocation stalls Mike Kravetz
2019-08-06 1:47 ` [PATCH v2 1/4] mm, reclaim: make should_continue_reclaim perform dryrun detection Mike Kravetz
2019-08-06 1:47 ` [PATCH v2 2/4] mm, reclaim: cleanup should_continue_reclaim() Mike Kravetz
2019-08-06 1:47 ` [PATCH v2 3/4] mm, compaction: raise compaction priority after it withdrawns Mike Kravetz
2019-08-06 1:47 ` [PATCH v2 4/4] hugetlbfs: don't retry when pool page allocations start to fail Mike Kravetz
2019-08-06 8:03 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c13c0c78-55d1-b2e2-c24b-897ce2469410@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).