From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42463C4361B for ; Fri, 18 Dec 2020 02:35:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B7FC23A74 for ; Fri, 18 Dec 2020 02:35:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B7FC23A74 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A64B16B005C; Thu, 17 Dec 2020 21:35:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A14F46B005D; Thu, 17 Dec 2020 21:35:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92B8B6B0068; Thu, 17 Dec 2020 21:35:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 7DEC86B005C for ; Thu, 17 Dec 2020 21:35:22 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 322253654 for ; Fri, 18 Dec 2020 02:35:22 +0000 (UTC) X-FDA: 77604836484.25.coat64_421152d27439 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id ECE3B1804EE01 for ; Fri, 18 Dec 2020 02:35:21 +0000 (UTC) X-HE-Tag: coat64_421152d27439 X-Filterd-Recvd-Size: 10286 Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Dec 2020 02:35:20 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.78,428,1599494400"; d="scan'208";a="102693910" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 18 Dec 2020 10:33:50 +0800 Received: from G08CNEXMBPEKD05.g08.fujitsu.local (unknown [10.167.33.204]) by cn.fujitsu.com (Postfix) with ESMTP id ED9DA4CE601B; Fri, 18 Dec 2020 10:33:47 +0800 (CST) Received: from irides.mr (10.167.225.141) by G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Dec 2020 10:33:47 +0800 Subject: Re: [RFC PATCH v3 9/9] xfs: Implement ->corrupted_range() for XFS To: "Darrick J. Wong" CC: , , , , , , , , , , , , References: <20201215121414.253660-1-ruansy.fnst@cn.fujitsu.com> <20201215121414.253660-10-ruansy.fnst@cn.fujitsu.com> <20201215204032.GA6918@magnolia> From: Ruan Shiyang Message-ID: Date: Fri, 18 Dec 2020 10:31:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201215204032.GA6918@magnolia> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Language: en-US X-Originating-IP: [10.167.225.141] X-ClientProxiedBy: G08CNEXCHPEKD06.g08.fujitsu.local (10.167.33.205) To G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) X-yoursite-MailScanner-ID: ED9DA4CE601B.A0131 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: ruansy.fnst@cn.fujitsu.com Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/12/16 =E4=B8=8A=E5=8D=884:40, Darrick J. Wong wrote: > On Tue, Dec 15, 2020 at 08:14:14PM +0800, Shiyang Ruan wrote: >> This function is used to handle errors which may cause data lost in >> filesystem. Such as memory failure in fsdax mode. >> >> In XFS, it requires "rmapbt" feature in order to query for files or >> metadata which associated to the corrupted data. Then we could call f= s >> recover functions to try to repair the corrupted data.(did not >> implemented in this patchset) >> >> After that, the memory failure also needs to notify the processes who >> are using those files. >> >> Only support data device. Realtime device is not supported for now. >> >> Signed-off-by: Shiyang Ruan >> --- >> fs/xfs/xfs_fsops.c | 10 +++++ >> fs/xfs/xfs_mount.h | 2 + >> fs/xfs/xfs_super.c | 93 ++++++++++++++++++++++++++++++++++++++++++++= ++ >> 3 files changed, 105 insertions(+) >> >> diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c >> index ef1d5bb88b93..0ec1b44bfe88 100644 >> --- a/fs/xfs/xfs_fsops.c >> +++ b/fs/xfs/xfs_fsops.c >> @@ -501,6 +501,16 @@ xfs_do_force_shutdown( >> "Corruption of in-memory data detected. Shutting down filesystem"); >> if (XFS_ERRLEVEL_HIGH <=3D xfs_error_level) >> xfs_stack_trace(); >> + } else if (flags & SHUTDOWN_CORRUPT_META) { >> + xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_CORRUPT, >> +"Corruption of on-disk metadata detected. Shutting down filesystem")= ; >> + if (XFS_ERRLEVEL_HIGH <=3D xfs_error_level) >> + xfs_stack_trace(); >> + } else if (flags & SHUTDOWN_CORRUPT_DATA) { >> + xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_CORRUPT, >> +"Corruption of on-disk file data detected. Shutting down filesystem"= ); >> + if (XFS_ERRLEVEL_HIGH <=3D xfs_error_level) >> + xfs_stack_trace(); >> } else if (logerror) { >> xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_LOGERROR, >> "Log I/O Error Detected. Shutting down filesystem"); >> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h >> index dfa429b77ee2..e36c07553486 100644 >> --- a/fs/xfs/xfs_mount.h >> +++ b/fs/xfs/xfs_mount.h >> @@ -274,6 +274,8 @@ void xfs_do_force_shutdown(struct xfs_mount *mp, i= nt flags, char *fname, >> #define SHUTDOWN_LOG_IO_ERROR 0x0002 /* write attempt to the log fai= led */ >> #define SHUTDOWN_FORCE_UMOUNT 0x0004 /* shutdown from a forced unmou= nt */ >> #define SHUTDOWN_CORRUPT_INCORE 0x0008 /* corrupt in-memory data str= uctures */ >> +#define SHUTDOWN_CORRUPT_META 0x0010 /* corrupt metadata on device *= / >> +#define SHUTDOWN_CORRUPT_DATA 0x0020 /* corrupt file data on device = */ >=20 > This symbol isn't used anywhere. I don't know why we'd shut down the f= s > for data loss, as we don't do that anywhere else in xfs. I prepared this flag for the later use if possible. But since it seems=20 unnecessary, I will remove it in the next version. >=20 >> =20 >> /* >> * Flags for xfs_mountfs >> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c >> index e3e229e52512..30202de7e89d 100644 >> --- a/fs/xfs/xfs_super.c >> +++ b/fs/xfs/xfs_super.c >> @@ -35,6 +35,11 @@ >> #include "xfs_refcount_item.h" >> #include "xfs_bmap_item.h" >> #include "xfs_reflink.h" >> +#include "xfs_alloc.h" >> +#include "xfs_rmap.h" >> +#include "xfs_rmap_btree.h" >> +#include "xfs_rtalloc.h" >> +#include "xfs_bit.h" >> =20 >> #include >> #include >> @@ -1103,6 +1108,93 @@ xfs_fs_free_cached_objects( >> return xfs_reclaim_inodes_nr(XFS_M(sb), sc->nr_to_scan); >> } >> =20 >> +static int >> +xfs_corrupt_helper( >> + struct xfs_btree_cur *cur, >> + struct xfs_rmap_irec *rec, >> + void *data) >> +{ >> + struct xfs_inode *ip; >> + int rc =3D 0; >=20 > Note: we usually use the name "error", not "rc". OK. >=20 >> + int *flags =3D data; >> + >> + if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner)) { >=20 > There are a few more things to check here to detect if metadata has bee= n > lost. The first is that any loss in the extended attribute information > is considered filesystem metadata; and the second is that loss of an > extent btree block is also metadata. >=20 > IOWs, this check should be: >=20 > if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner) || > (rec->rm_flags & (XFS_RMAP_ATTR_FORK | XFS_RMAP_BMBT_BLOCK))) { > // TODO check and try to fix metadata > return -EFSCORRUPTED; > } Thanks for pointing out. >=20 >> + // TODO check and try to fix metadata >> + rc =3D -EFSCORRUPTED; >> + } else { >> + /* >> + * Get files that incore, filter out others that are not in use. >> + */ >> + rc =3D xfs_iget(cur->bc_mp, cur->bc_tp, rec->rm_owner, >> + XFS_IGET_INCORE, 0, &ip); >> + if (rc || !ip) >> + return rc; >> + if (!VFS_I(ip)->i_mapping) >> + goto out; >> + >> + if (IS_DAX(VFS_I(ip))) >> + rc =3D mf_dax_mapping_kill_procs(VFS_I(ip)->i_mapping, >> + rec->rm_offset, *flags); >=20 > If the file isn't S_DAX, should we call mapping_set_error here so > that the next fsync() will also return EIO? Nice idea. I will try. >=20 >> + >> + // TODO try to fix data >> +out: >> + xfs_irele(ip); >> + } >> + >> + return rc; >> +} >> + >> +static int >> +xfs_fs_corrupted_range( >> + struct super_block *sb, >> + struct block_device *bdev, >> + loff_t offset, >> + size_t len, >> + void *data) >> +{ >> + struct xfs_mount *mp =3D XFS_M(sb); >> + struct xfs_trans *tp =3D NULL; >> + struct xfs_btree_cur *cur =3D NULL; >> + struct xfs_rmap_irec rmap_low, rmap_high; >> + struct xfs_buf *agf_bp =3D NULL; >> + xfs_fsblock_t fsbno =3D XFS_B_TO_FSB(mp, offset); >> + xfs_filblks_t bc =3D XFS_B_TO_FSB(mp, len); >> + xfs_agnumber_t agno =3D XFS_FSB_TO_AGNO(mp, fsbno); >> + xfs_agblock_t agbno =3D XFS_FSB_TO_AGBNO(mp, fsbno); >> + int rc =3D 0; >> + >> + if (mp->m_rtdev_targp && mp->m_rtdev_targp->bt_bdev =3D=3D bdev) { >> + xfs_warn(mp, "storage lost support not available for realtime devic= e!"); >> + return 0; >> + } >=20 > This ought to kill the fs when an external log device is configured: >=20 > if (mp->m_logdev_targp && > mp->m_logdev_targp !=3D mp->m_ddev_targp && > mp->m_logdev_targp->bt_bdev =3D=3D bdev) { > xfs_error(mp, "ondisk log corrupt, shutting down fs!"); > xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_META); > return 0; > } >=20 > Then, we need to check explicitly for rmap support: >=20 > if (!xfs_sb_version_hasrmapbt(&mp->m_sb)) > return 0; >=20 > so that we screen out filesystems that don't have rmap enabled. Ah... I was too negligent to think of this. That's very thoughtful of=20 you. Thanks. >=20 >> + rc =3D xfs_trans_alloc_empty(mp, &tp); >> + if (rc) >> + return rc; >> + >> + rc =3D xfs_alloc_read_agf(mp, tp, agno, 0, &agf_bp); >> + if (rc) >> + return rc; >> + >> + cur =3D xfs_rmapbt_init_cursor(mp, tp, agf_bp, agno); >> + >> + /* Construct a range for rmap query */ >> + memset(&rmap_low, 0, sizeof(rmap_low)); >> + memset(&rmap_high, 0xFF, sizeof(rmap_high)); >> + rmap_low.rm_startblock =3D rmap_high.rm_startblock =3D agbno; >> + rmap_low.rm_blockcount =3D rmap_high.rm_blockcount =3D bc; >> + >> + rc =3D xfs_rmap_query_range(cur, &rmap_low, &rmap_high, xfs_corrupt_= helper, data); >> + if (rc =3D=3D -ECANCELED) >> + rc =3D 0; >=20 > I don't think anything returns ECANCELED here... Yes. Will remove it. -- Thanks, Ruan Shiyang. >=20 > --D >=20 >> + if (rc =3D=3D -EFSCORRUPTED) >> + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_META); >> + >> + xfs_btree_del_cursor(cur, rc); >> + xfs_trans_brelse(tp, agf_bp); >> + return rc; >> +} >> + >> static const struct super_operations xfs_super_operations =3D { >> .alloc_inode =3D xfs_fs_alloc_inode, >> .destroy_inode =3D xfs_fs_destroy_inode, >> @@ -1116,6 +1208,7 @@ static const struct super_operations xfs_super_o= perations =3D { >> .show_options =3D xfs_fs_show_options, >> .nr_cached_objects =3D xfs_fs_nr_cached_objects, >> .free_cached_objects =3D xfs_fs_free_cached_objects, >> + .corrupted_range =3D xfs_fs_corrupted_range, >> }; >> =20 >> static int >> --=20 >> 2.29.2 >> >> >> >=20 >=20