From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA2BC433DB for ; Fri, 19 Mar 2021 19:00:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4B71461974 for ; Fri, 19 Mar 2021 19:00:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B71461974 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1DB46B006E; Fri, 19 Mar 2021 15:00:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF4406B0070; Fri, 19 Mar 2021 15:00:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A483A6B0071; Fri, 19 Mar 2021 15:00:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 846396B006E for ; Fri, 19 Mar 2021 15:00:41 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4C1238249980 for ; Fri, 19 Mar 2021 19:00:41 +0000 (UTC) X-FDA: 77937540282.21.14D02B4 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf19.hostedemail.com (Postfix) with ESMTP id 302CF900073D for ; Fri, 19 Mar 2021 19:00:28 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id s17so13250210ljc.5 for ; Fri, 19 Mar 2021 12:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=upYBQNguiL04oAnOuIZVoxunH/QGosMTk93Yec7+Rbg=; b=T6mohFpQrPvDkTsnbhIZZTClnjt+wgrlDkN7EPqfVoRBeExZ0bweCm5hAVH1lmC5oH HfdbvZ3Am39pEy0irud+ZBabpuZ2Rbm0yi70vvi0OllOexkgQljG5ia3UF/M+GK/DhHO mgl1gmHh6LVtOVYvxLJ4Bsaj7AI3DygblXtJ6qG6qLuDrNGPvHLIYKPRUlTpT/X4JLRx t8GiNDJ0B0kz/Gogayji2Upnhq6uDsrubBhF4FzD84lglW13yusbMcPkk5CVyuBaK+xm xXArMEXdb4IcHLWKpjWLBkhsMIrVFd7rup8DGI1Zc+wRYYYwuSgGWMg00h0d88uNAQXp PQzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=upYBQNguiL04oAnOuIZVoxunH/QGosMTk93Yec7+Rbg=; b=NrVmzrUFibTMMSh+b+C/W1rqb5Rczthkjibgj+mQBv/Bcj5BljZwz6KILKdU7xt9RY SUrSaHnCFjKokU1zJW1o3zqoFhwVpwzuA13j5HnShWVzpI9k33bgq5JoVQm76X3coWkL XrpElsPISOVlkfE+/4Mg9uHbxG44qeRabA01rPjK+DxO0Vkb4rlX6QH4Iodsa/O83TcM Qo0haM6VzqWHA4lg7bsCaA3/0x8lxYDqZ3rrOl3zoijD6kap0i83clhCSNfCanqG6u3P CBZ1jM9Vq2YUb/fwt/Rfwo+nKjCHwTX+Ob1qGfaWZM4KFW70ZO6FJW/IAM7/x4Wv1uw7 pS6A== X-Gm-Message-State: AOAM532OjJiXq5KBpPHjZ7ZTvHJj2goUAafG6NeGFD3qYnoKPytlcMvG ZYICUdTd0Eat6kJTzfpxyrc= X-Google-Smtp-Source: ABdhPJwEHL4qNsfPRyoywMlkjZ69cy0QzZ+Nmm2U/SqQusVLnQuVWolvt/bER/1HMjW/b+LXWHB8/g== X-Received: by 2002:a2e:98c5:: with SMTP id s5mr1735067ljj.218.1616180421079; Fri, 19 Mar 2021 12:00:21 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id f8sm715617lfs.143.2021.03.19.12.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 12:00:20 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs To: Minchan Kim Cc: Greg Kroah-Hartman , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <82bde114-60c0-3fde-43f4-844522b80673@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 19 Mar 2021 22:00:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: 5hfft4nucxoofagmxnrct65in7skzubs X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 302CF900073D Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=mail-lj1-f171.google.com; client-ip=209.85.208.171 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616180428-701917 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 21:18, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> +#define CMA_ATTR_RO(_name) \ >>> + static struct kobj_attribute _name##_attr =3D __ATTR_RO(_name) >>> + >>> +static ssize_t alloc_pages_success_show(struct kobject *kobj, >>> + struct kobj_attribute *attr, char *buf) >> The indentations are still wrong. >> >> CHECK: Alignment should match open parenthesis > Hmm, I didn't know that we have that kinds of rule. > Maybe, my broken checkpatch couldn't catch it up. > Thanks. >=20 > $ ./scripts/checkpatch.pl 0001-mm-cma-support-sysfs.patch > Traceback (most recent call last): > File "scripts/spdxcheck.py", line 6, in > from ply import lex, yacc >=20 >=20 > < snip > >=20 That's probably because I use the --strict option of checkpatch by defaul= t.