From: David Hildenbrand <david@redhat.com>
To: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Joerg Roedel <jroedel@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [PATCH] mm: vmalloc: remove redundant asignmnet in unmap_kernel_range_noflush()
Date: Tue, 7 Jul 2020 19:16:56 +0200 [thread overview]
Message-ID: <c28e82a3-de60-8261-d3f6-8b8e6b260de2@redhat.com> (raw)
In-Reply-To: <20200707163226.374685-1-rppt@kernel.org>
On 07.07.20 18:32, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> 'addr' is set to 'start' and then a few lines afterwards 'start' is
> set to 'addr'.
> Remove the second asignment.
>
> Fixes: 2ba3e6947aed ("mm/vmalloc: track which page-table levels were modified")
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> mm/vmalloc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 5a2b55c8dd9a..68ebbafc9c9b 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -171,11 +171,10 @@ void unmap_kernel_range_noflush(unsigned long start, unsigned long size)
> pgd_t *pgd;
> unsigned long addr = start;
> pgtbl_mod_mask mask = 0;
>
> BUG_ON(addr >= end);
> - start = addr;
> pgd = pgd_offset_k(addr);
> do {
> next = pgd_addr_end(addr, end);
> if (pgd_bad(*pgd))
> mask |= PGTBL_PGD_MODIFIED;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-07-07 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 16:32 [PATCH] mm: vmalloc: remove redundant asignmnet in unmap_kernel_range_noflush() Mike Rapoport
2020-07-07 17:16 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c28e82a3-de60-8261-d3f6-8b8e6b260de2@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).