From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E518DC4338F for ; Mon, 2 Aug 2021 03:26:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 759C161050 for ; Mon, 2 Aug 2021 03:26:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 759C161050 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EB0E18D0001; Sun, 1 Aug 2021 23:26:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E615A6B0036; Sun, 1 Aug 2021 23:26:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4F228D0001; Sun, 1 Aug 2021 23:26:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id B870A6B0033 for ; Sun, 1 Aug 2021 23:26:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5C1E78249980 for ; Mon, 2 Aug 2021 03:26:07 +0000 (UTC) X-FDA: 78428701974.09.888BD74 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf10.hostedemail.com (Postfix) with ESMTP id 077E560020B9 for ; Mon, 2 Aug 2021 03:26:06 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id mt6so23435276pjb.1 for ; Sun, 01 Aug 2021 20:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=fY3bTijU6Gb04TFq1RIXd8jCmJsbDrkR6i4HqP4dglU=; b=jxL6WshFF20ldGPyHr6Ggzso3E86G1zQekA8y4cpogB+HSpClq7/QP7AyKJeQURLZu 0DSnvm4Xh+sBMLYx79ogN/gtNN8w6vK7NTCFr/UHlABFj1P8CSM0gTeHAQTSLseoziMt 4uiBj9FhtwaXnv5t0Q6MjPWt+sI49vw5Lw0rxyaZmB69bGptruBU9CX8SzYChdyt61ch tVqjkg7oZ5iCYKlNVzwYeGAiSE3UtBsJDJZyEmq9N9vjXbOfKzoO57tpHmS6NjUV/5dy /FWhRSpx4+AfEwtuXmfvAMqKNQ/Pp74L+8irL9kQVN/mCZxIEGwS8ZydQP9VWTkpiM5Q EpoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=fY3bTijU6Gb04TFq1RIXd8jCmJsbDrkR6i4HqP4dglU=; b=gOLk371J2sxwSmQte34mvBgG9SDSwJcdfByGtMU3qZ6OC5942cV1biPreJcg7neIca eMTBayZm0BF+Yf3XkA0PtT4hENtUuzkHWseSm+tAf0+SBFFGJ6nfsnxHK5L8DVCYaOjo DvFXHB05vh2ENJqcRMUYI+WztswnHOdgcUSmSZlztnkhPAmf1CDZ3nNSMsxCAz0/iRFw Fa35TJDbPGTqFJhJR/3vdR8n5kj8rD5iLuMOgXbgMLi1aIuqnJuOG3gdLgnU7kw6I1xK 690gyD1epxBBQdVjuUnmKuHpFFUHbvs63mZbjIF+xwP0iA3xEQlKpM6UywqetiFsrrX8 92FQ== X-Gm-Message-State: AOAM530YaXu0CtmDvbV3o3Zsrxs09WbRuJvHyEJZRZq4GNsZ8f5PCERR 4+FjMtvpSb1o0KOjXyGRmucQ8A== X-Google-Smtp-Source: ABdhPJyptad5Ewu1xNDCXTUeSSQ+YYElc7yFa+yls2G9a4s19lOkETRV3ni8rtKBZpjfSGp8g3AOzA== X-Received: by 2002:a63:d34e:: with SMTP id u14mr692880pgi.244.1627874765775; Sun, 01 Aug 2021 20:26:05 -0700 (PDT) Received: from [2620:15c:17:3:f081:306b:20f6:7d15] ([2620:15c:17:3:f081:306b:20f6:7d15]) by smtp.gmail.com with ESMTPSA id y139sm9460074pfb.107.2021.08.01.20.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Aug 2021 20:26:05 -0700 (PDT) Date: Sun, 1 Aug 2021 20:26:04 -0700 (PDT) From: David Rientjes To: Vlastimil Babka cc: Vijayanand Jitta , cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, vinmenon@codeaurora.org Subject: Re: [PATCH] mm: slub: Fix slub_debug disablement for list of slabs In-Reply-To: <8a3d992a-473a-467b-28a0-4ad2ff60ab82@suse.cz> Message-ID: References: <1626176750-13099-1-git-send-email-vjitta@codeaurora.org> <8a3d992a-473a-467b-28a0-4ad2ff60ab82@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 077E560020B9 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=jxL6WshF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of rientjes@google.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=rientjes@google.com X-Stat-Signature: g9oj4tusggprncc1t4q6o5k5e5ntwak1 X-HE-Tag: 1627874766-315996 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 27 Jul 2021, Vlastimil Babka wrote: > From 81a225fe31e53701902bb4caa9ab1524eb044cbc Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Tue, 13 Jul 2021 17:15:50 +0530 > Subject: [PATCH] mm: slub: fix slub_debug disabling for list of slabs > > Vijayanand Jitta reports: > > Consider the scenario where CONFIG_SLUB_DEBUG_ON is set > and we would want to disable slub_debug for few slabs. > Using boot parameter with slub_debug=-,slab_name syntax > doesn't work as expected i.e; only disabling debugging for > the specified list of slabs. Instead it disables debugging > for all slabs, which is wrong. > > This patch fixes it by delaying the moment when the global slub_debug flags > variable is updated. In case a "slub_debug=-,slab_name" has been passed, the > global flags remain as initialized (depending on CONFIG_SLUB_DEBUG_ON enabled > or disabled) and are not simply reset to 0. > > Reported-by: Vijayanand Jitta > Signed-off-by: Vlastimil Babka > Reviewed-by: Vijayanand Jitta Acked-by: David Rientjes Looks better, thanks!