From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F170ECAAD3 for ; Wed, 14 Sep 2022 17:27:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB2BB8D0003; Wed, 14 Sep 2022 13:27:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D610C8D0001; Wed, 14 Sep 2022 13:27:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C286C8D0003; Wed, 14 Sep 2022 13:27:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B39BF8D0001 for ; Wed, 14 Sep 2022 13:27:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8A83980B26 for ; Wed, 14 Sep 2022 17:27:57 +0000 (UTC) X-FDA: 79911373794.17.BBBF34D Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf10.hostedemail.com (Postfix) with ESMTP id 26981C0090 for ; Wed, 14 Sep 2022 17:27:57 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id g2so8585864qkk.1 for ; Wed, 14 Sep 2022 10:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=QyRGzlkoFcQG3CIMtJPpDZn+hUgACTBPPomMcutX19k=; b=Pn4nqjxVEX/40MaS2pCNxckO6W0GVqjplLgc4YUpDc+NUzQMdvYp+h9a2SUbKePdNf y8kZjtKbeOf8fVif7+dfDenYS/1jVYV5uoFoAs/cY4uIPSj19owpvWNd7wx/0m0l7rws oecBLvmQr6nar/9/rUQmFR9ltOIqaaW68CcY5Kgo8ysxDTvO6RFaQqmmpD1CQ5gzcJXf OFxlH1/pZ06zBltHk8fY4h1CK4yGsoQUovRnAPOdclXozylg4qtr0bgrQJa/egKMEPOb B6ZmZiy3RVdEFGRF2KkrY1qTREOETvJsBmdX8yhjBlcH4gn8S8Vz2XX1XviQtC12zn6h pu3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=QyRGzlkoFcQG3CIMtJPpDZn+hUgACTBPPomMcutX19k=; b=37Lqg2yQ1+wWIJnAMgptnvnznyq1EFY1qoFgQINp7R4cD6v2e0UyH1q6Hfd2OqPwku oF0aYshTzjGW98MOOaLHUCYn9E0QjrOqGYGfP4SiRe6HkObGpqC2A30Nk3rEfrSkAeX9 OIbaFpiUXNpX3v1ezhmLtbyndTdIs2gHh7ODHyfn7J2O7OD73ZsYUb953PNWTbu/DKCN +2iGNCh6H+4UBup8Z6eBAeQhv6Q4rYW4zTDEE4f2+RPrM0TXlnK3hO0KbvMoFCfgcZud uzJ8Gfx1X3B8zwrHDeUHKUC2OFvNSr7jLr/Ct3VsOqj+In5X7G22CWtPWAcmaSNP+Wu1 DG6w== X-Gm-Message-State: ACgBeo3NlYNOwchfFPwulB4dafEnzQySRmZYqJahAZdAme1LHjvhCiA0 XYp7Ur68CZFUKBsCMJUvXb0= X-Google-Smtp-Source: AA6agR5pvM1OqTJhrtgIA3p55nJJ77rDjYUI3TvVtLJ4yP/4XiCqo9RIOd8UUqhIagFXgfBGt0vKFQ== X-Received: by 2002:a05:620a:24d6:b0:6cd:f96a:35b with SMTP id m22-20020a05620a24d600b006cdf96a035bmr15502737qkn.471.1663176476372; Wed, 14 Sep 2022 10:27:56 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id d1-20020ac85341000000b0035ba48c032asm1838553qto.25.2022.09.14.10.27.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 10:27:55 -0700 (PDT) Message-ID: Date: Wed, 14 Sep 2022 10:26:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 02/21] mm/hugetlb: correct max_huge_pages accounting on demote Content-Language: en-US To: Mike Kravetz , Doug Berger Cc: Andrew Morton , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Muchun Song , Mike Rapoport , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Borislav Petkov , "Paul E. McKenney" , Neeraj Upadhyay , Randy Dunlap , Damien Le Moal , David Hildenbrand , Zi Yan , Oscar Salvador , Hari Bathini , Kees Cook , - , KOSAKI Motohiro , Mel Gorman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux.dev References: <20220913195508.3511038-1-opendmb@gmail.com> <20220913195508.3511038-3-opendmb@gmail.com> From: Florian Fainelli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663176477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QyRGzlkoFcQG3CIMtJPpDZn+hUgACTBPPomMcutX19k=; b=aapu/sC3UJ+uHUPx9CKIIX59SNbHRmuD/pJxEPnI7HRaI/L0fR39YFo9D+aEBjkwCyDotw Om2uvEBBgtNe403pVCexc/oxzFuj/buADJVwGp82SfSIvUKyCzHlRcR7F3m8YmRSiAY1SR 4z8lAavZXZk4IwSu2QkzFM20IYfrRyY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Pn4nqjxV; spf=pass (imf10.hostedemail.com: domain of f.fainelli@gmail.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663176477; a=rsa-sha256; cv=none; b=rQZABehscB8zW9CaTxsrV5oSN1vLWZQhmGZuTkFhftFTPWzGTnBeGk3eR80X49cLZeLQaq paraKSbL3K57ljHryfLVd2srUK6CGtg8+apV0VaXl9LGqPkAH42naEPTttzsqDz47Kg+0y VzSt9uBNWVwjUWThyOHbpwg1PYwdBEE= Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Pn4nqjxV; spf=pass (imf10.hostedemail.com: domain of f.fainelli@gmail.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: dhhoassf7mjibskg59xgzpyb88nfy7gs X-Rspamd-Queue-Id: 26981C0090 X-HE-Tag: 1663176477-905205 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/14/22 10:23, Mike Kravetz wrote: > On 09/13/22 12:54, Doug Berger wrote: >> When demoting a hugepage to a smaller order, the number of pages >> added to the target hstate will be the size of the large page >> divided by the size of the smaller page. >> >> Fixes: 8531fc6f52f5 ("hugetlb: add hugetlb demote page support") >> Signed-off-by: Doug Berger >> --- >> mm/hugetlb.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index e070b8593b37..79949893ac12 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -3472,7 +3472,8 @@ static int demote_free_huge_page(struct hstate *h, struct page *page) >> * based on pool changes for the demoted page. >> */ >> h->max_huge_pages--; >> - target_hstate->max_huge_pages += pages_per_huge_page(h); >> + target_hstate->max_huge_pages += pages_per_huge_page(h) / >> + pages_per_huge_page(target_hstate); >> >> return rc; >> } > > This has already been fixed here, > > https://lore.kernel.org/linux-mm/20220823030209.57434-2-linmiaohe@huawei.com/ > Could we slap the Fixes tag when this Miaohe's patch series gets accepted since the offending commit is in v5.16 and beyond. Thanks! -- Florian