From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309C7C433FE for ; Tue, 22 Nov 2022 00:44:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 985A56B0071; Mon, 21 Nov 2022 19:44:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 934B66B0073; Mon, 21 Nov 2022 19:44:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FD7B6B0074; Mon, 21 Nov 2022 19:44:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 720506B0071 for ; Mon, 21 Nov 2022 19:44:55 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39047C0510 for ; Tue, 22 Nov 2022 00:44:55 +0000 (UTC) X-FDA: 80159233350.12.906D7CC Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf11.hostedemail.com (Postfix) with ESMTP id 9C7A04000A for ; Tue, 22 Nov 2022 00:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669077894; x=1700613894; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vQu+Ql6V2W8MdI2sO01U5UcW0Jf0jzenhcur0b9+iUY=; b=ncFQK+6KFgytMgcc+Ewt/XD6k3hiie1U7GyDYDW1cFSYPrX+CEJc+Xrm U+4QSMjwkVHsqHKlqkUhzr0laEd1YsXthL7pMyuhg9x5bMUl4Hl+N+Tew EKbqX+ovVvYY7h4r/GHLW1rSeIYEEC1pDuKulK0mywP4tDY5+T051QLLx gjxCildlytdctAxGsIr0LsqqC8a+e8MJ0byGwxZ4OG4twKA6Ax76PjJ1f eH6mJGm2mpdfmY9tDHgPAFpVJtgMCUOvALc9TKyJKVaG2rWnQrBgibViI 56PkvpywKK7KSeFFBFOM5opfOCVYFOy7hGLFL143uKgvxAf6KDliLtBM0 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="313726137" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="313726137" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 16:44:53 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="783652648" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="783652648" Received: from ticela-or-327.amr.corp.intel.com (HELO [10.209.6.63]) ([10.209.6.63]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 16:44:51 -0800 Message-ID: Date: Mon, 21 Nov 2022 16:44:50 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 03/20] x86/virt/tdx: Disable TDX if X2APIC is not enabled Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <87e17024-755d-e195-d9ea-ef62a4de6aa8@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ncFQK+6K; spf=pass (imf11.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669077894; a=rsa-sha256; cv=none; b=vcr9EisehSlhVbVb7kMGsEi7Ve8/qOXfEfU/RcOxDSZJ40tAghYVEWQO8HaCqXF+bVrY21 CmpWdF/IL+cv4EMZO8ZWt5Y2YtWSWa83DF/4liTt1GPmbUAdHjgWMWR13oziLJVIULOPci jiJ2Nj7nPrLoHpwlec88A6FVWKukULw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669077894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QwMRGBWYzas+ZQrLaEnofwdfFB02EOMAadv4uVE0NuE=; b=e72vTHZYCIIewG6RnhnuO6rzbs9fQTdgBfw93oL4KGw1cs6munfQg/Gp3S+rvmKwtsD0GW 0mFVjPMRMsntmfVEAZQQZx6j6Qz7ubTHq0/oGNllFfnf0jiLgkbxh3iJmVQjXApAeHoZtZ jE6epyPbXiSm4XuI1F4IOrF/UbKr1CI= X-Stat-Signature: 3phmxkehzg36c1dk8ruro8zgctj656yu X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9C7A04000A Authentication-Results: imf11.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ncFQK+6K; spf=pass (imf11.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-HE-Tag: 1669077894-817350 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/21/22 16:30, Huang, Kai wrote: > > How about still having a patch to make INTEL_TDX_HOST depend on X86_X2APIC but > with something below in the changelog? > > " > TDX capable platforms are locked to X2APIC mode and cannot fall back to the > legacy xAPIC mode when TDX is enabled by the BIOS. It doesn't make sense to > turn on INTEL_TDX_HOST while X86_X2APIC is not enabled. Make INTEL_TDX_HOST > depend on X86_X2APIC. That's fine and it makes logical sense as a dependency. TDX host support requires x2APIC. Period.