From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0EB4C433DF for ; Mon, 19 Oct 2020 11:57:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D190D22268 for ; Mon, 19 Oct 2020 11:57:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aM66he/J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D190D22268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC6E26B005D; Mon, 19 Oct 2020 07:57:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9CDF6B0062; Mon, 19 Oct 2020 07:57:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB3816B0068; Mon, 19 Oct 2020 07:57:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id AFF236B005D for ; Mon, 19 Oct 2020 07:57:42 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 553B4180AD811 for ; Mon, 19 Oct 2020 11:57:42 +0000 (UTC) X-FDA: 77388525564.07.crowd71_121554527236 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 3CAA01803FD61 for ; Mon, 19 Oct 2020 11:57:42 +0000 (UTC) X-HE-Tag: crowd71_121554527236 X-Filterd-Recvd-Size: 4169 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 11:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603108661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8SlL4Q5SbHMhStfWfVjsxTibC0dKmqUQeioCU1eaaZw=; b=aM66he/J1IO02gxKdZxxMn2uk0d2fV32xL/qdKtx4h4U1cZc49eBnycU1LhLCZf2d2Z/9C hOCoJEVTQEnTV01b+vyymThJxn+NbsJwuQpgcpSZFHLI5LDMgLpHwisqibXvxnih2vfp+m p+tjZAA57NtsWaawlp+RjZEG2ZQ1wHk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-6W0ZzrGiPiWqR5E7wegN8w-1; Mon, 19 Oct 2020 07:57:39 -0400 X-MC-Unique: 6W0ZzrGiPiWqR5E7wegN8w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C2D257088; Mon, 19 Oct 2020 11:57:37 +0000 (UTC) Received: from [10.36.115.26] (ovpn-115-26.ams2.redhat.com [10.36.115.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 959A56EF44; Mon, 19 Oct 2020 11:57:30 +0000 (UTC) Subject: Re: [PATCH v1 20/29] virtio-mem: nb_sb_per_mb and subblock_size are specific to Sub Block Mode (SBM) To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Andrew Morton , "Michael S . Tsirkin" , Jason Wang , Pankaj Gupta References: <20201012125323.17509-1-david@redhat.com> <20201012125323.17509-21-david@redhat.com> <20201016085319.GD44269@L-31X9LVDL-1304.local> <7b55ffe1-95fc-1e71-ea6b-82bd0a98a6b4@redhat.com> <20201018124104.GD50506@L-31X9LVDL-1304> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Mon, 19 Oct 2020 13:57:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201018124104.GD50506@L-31X9LVDL-1304> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.10.20 14:41, Wei Yang wrote: > On Fri, Oct 16, 2020 at 03:17:06PM +0200, David Hildenbrand wrote: >> On 16.10.20 10:53, Wei Yang wrote: >>> On Mon, Oct 12, 2020 at 02:53:14PM +0200, David Hildenbrand wrote: >>>> Let's rename to "sbs_per_mb" and "sb_size" and move accordingly. >>>> >>>> Cc: "Michael S. Tsirkin" >>>> Cc: Jason Wang >>>> Cc: Pankaj Gupta >>>> Signed-off-by: David Hildenbrand >>> >>> One trivial suggestion, could we move this patch close the data structure >>> movement patch? >>> >>> I know this would be some work, since you have changed some of the code logic. >>> This would take you some time to rebase. >> >> You mean after patch #17 ? > > Yes > >> >> I guess I can move patch #18 (prereq) a little further up (e.g., after >> patch #15). Guess moving it in front of #19 shouldn't be too hard. >> >> Will give it a try - if it takes too much effort, I'll leave it like this. >> > > Not a big deal, while it will make the change more intact to me. > > This is a big patch set to me. In case it could be split into two parts, like > bug fix/logic improvement and BBM implementation, that would be more friendly > to review. I'll most probably keep it as a single series, but reshuffle the patches into 1. cleanups 2. preparations 3. BBM That should make things easier to digest. Thanks! -- Thanks, David / dhildenb