From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55ED9C3F2D7 for ; Wed, 4 Mar 2020 14:26:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 177FA20848 for ; Wed, 4 Mar 2020 14:26:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 177FA20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A56186B0003; Wed, 4 Mar 2020 09:26:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A06A66B0005; Wed, 4 Mar 2020 09:26:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F6726B0006; Wed, 4 Mar 2020 09:26:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 733D36B0003 for ; Wed, 4 Mar 2020 09:26:13 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1541F180AD801 for ; Wed, 4 Mar 2020 14:26:13 +0000 (UTC) X-FDA: 76557904626.13.body39_8d84f8a704f40 X-HE-Tag: body39_8d84f8a704f40 X-Filterd-Recvd-Size: 7415 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 14:26:12 +0000 (UTC) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 024EKqpX038129 for ; Wed, 4 Mar 2020 09:26:11 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yhsv9uec3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 04 Mar 2020 09:26:10 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Mar 2020 14:26:07 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 4 Mar 2020 14:26:00 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 024EPwZ512648592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Mar 2020 14:25:58 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 93DBCAE04D; Wed, 4 Mar 2020 14:25:58 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A97CAE045; Wed, 4 Mar 2020 14:25:57 +0000 (GMT) Received: from pic2.home (unknown [9.145.145.27]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 4 Mar 2020 14:25:57 +0000 (GMT) Subject: Re: [PATCH v3 22/27] powerpc/powernv/pmem: Implement the heartbeat command To: "Alastair D'Silva" , alastair@d-silva.org Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org References: <20200221032720.33893-1-alastair@au1.ibm.com> <20200221032720.33893-23-alastair@au1.ibm.com> From: Frederic Barrat Date: Wed, 4 Mar 2020 15:25:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200221032720.33893-23-alastair@au1.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 20030414-0016-0000-0000-000002ED23C9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20030414-0017-0000-0000-00003350725A Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-04_05:2020-03-04,2020-03-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 clxscore=1015 suspectscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040109 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 21/02/2020 =C3=A0 04:27, Alastair D'Silva a =C3=A9crit=C2=A0: > From: Alastair D'Silva >=20 > The heartbeat admin command is a simple admin command that exercises > the communication mechanisms within the controller. >=20 > This patch issues a heartbeat command to the card during init to ensure > we can communicate with the card's controller. >=20 > Signed-off-by: Alastair D'Silva > --- Nothing to add compared to what has already been commented on previous=20 patches (rc not set in probe(), higher level function to execute admin=20 command in one call). Fred > arch/powerpc/platforms/powernv/pmem/ocxl.c | 43 +++++++++++++++++++++= + > 1 file changed, 43 insertions(+) >=20 > diff --git a/arch/powerpc/platforms/powernv/pmem/ocxl.c b/arch/powerpc/= platforms/powernv/pmem/ocxl.c > index 081883a8247a..e01f6f9fc180 100644 > --- a/arch/powerpc/platforms/powernv/pmem/ocxl.c > +++ b/arch/powerpc/platforms/powernv/pmem/ocxl.c > @@ -306,6 +306,44 @@ static bool is_usable(const struct ocxlpmem *ocxlp= mem, bool verbose) > return true; > } > =20 > +/** > + * heartbeat() - Issue a heartbeat command to the controller > + * @ocxlpmem: the device metadata > + * Return: 0 if the controller responded correctly, negative on error > + */ > +static int heartbeat(struct ocxlpmem *ocxlpmem) > +{ > + int rc; > + > + mutex_lock(&ocxlpmem->admin_command.lock); > + > + rc =3D admin_command_request(ocxlpmem, ADMIN_COMMAND_HEARTBEAT); > + if (rc) > + goto out; > + > + rc =3D admin_command_execute(ocxlpmem); > + if (rc) > + goto out; > + > + rc =3D admin_command_complete_timeout(ocxlpmem, ADMIN_COMMAND_HEARTBE= AT); > + if (rc < 0) { > + dev_err(&ocxlpmem->dev, "Heartbeat timeout\n"); > + goto out; > + } > + > + rc =3D admin_response(ocxlpmem); > + if (rc < 0) > + goto out; > + if (rc !=3D STATUS_SUCCESS) > + warn_status(ocxlpmem, "Unexpected status from heartbeat", rc); > + > + (void)admin_response_handled(ocxlpmem); > + > +out: > + mutex_unlock(&ocxlpmem->admin_command.lock); > + return rc; > +} > + > /** > * allocate_minor() - Allocate a minor number to use for an OpenCAPI = pmem device > * @ocxlpmem: the device metadata > @@ -1458,6 +1496,11 @@ static int probe(struct pci_dev *pdev, const str= uct pci_device_id *ent) > goto err; > } > =20 > + if (heartbeat(ocxlpmem)) { > + dev_err(&pdev->dev, "Heartbeat failed\n"); > + goto err; > + } > + > elapsed =3D 0; > timeout =3D ocxlpmem->readiness_timeout + ocxlpmem->memory_available= _timeout; > while (!is_usable(ocxlpmem, false)) { >=20