From: Weichao Guo <guoweichao@oppo.com>
To: rpalethorpe@suse.de, kernel test robot <oliver.sang@intel.com>
Cc: "huangjianan@oppo.com" <huangjianan@oppo.com>,
lkp@intel.com, Linux Memory Management List <linux-mm@kvack.org>,
Chao Yu <yuchao0@huawei.com>, LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, Jaegeuk Kim <jaegeuk@kernel.org>,
ltp@lists.linux.it
Subject: Re: [LTP] [f2fs] 02eb84b96b: ltp.swapon03.fail
Date: Tue, 9 Mar 2021 10:23:35 +0800 [thread overview]
Message-ID: <c75229cc-e325-1c8b-0afa-fd236db8319c@oppo.com> (raw)
In-Reply-To: <87h7llhnfe.fsf@suse.de>
Hi Richard,
On 2021/3/8 19:53, Richard Palethorpe wrote:
> Hello,
>
>> kern :err : [ 187.461914] F2FS-fs (sda1): Swapfile does not align to section
>> commit 02eb84b96bc1b382dd138bf60724edbefe77b025
>> Author: huangjianan@oppo.com <huangjianan@oppo.com>
>> Date: Mon Mar 1 12:58:44 2021 +0800
>> f2fs: check if swapfile is section-alligned
>> If the swapfile isn't created by pin and fallocate, it can't be
>> guaranteed section-aligned, so it may be selected by f2fs gc. When
>> gc_pin_file_threshold is reached, the address of swapfile may change,
>> but won't be synchronized to swap_extent, so swap will write to wrong
>> address, which will cause data corruption.
>> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
>> Signed-off-by: Guo Weichao <guoweichao@oppo.com>
>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> The test uses fallocate to preallocate the swap file and writes zeros to
> it. I'm not sure what pin refers to?
'pin' refers to pinned file feature in F2FS, the LBA(Logical Block
Address) of a file is fixed after pinned. Without this operation before
fallocate, the LBA may not align with section(F2FS GC unit), some LBA of
the file may be changed by F2FS GC in some extreme cases.
For this test case, how about pin the swap file before fallocate for
F2FS as following:
ioctl(fd, F2FS_IOC_SET_PIN_FILE, true);
BR,
Weichao
next prev parent reply other threads:[~2021-03-09 2:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 7:25 [f2fs] 02eb84b96b: ltp.swapon03.fail kernel test robot
2021-03-08 11:53 ` [LTP] " Richard Palethorpe
2021-03-09 2:23 ` Weichao Guo [this message]
2021-03-09 4:01 ` Matthew Wilcox
2021-03-10 2:32 ` Huang Jianan
2021-03-10 20:49 ` Jaegeuk Kim
2021-03-23 9:04 ` Chao Yu
[not found] ` <cf28837a-9558-b00c-bca3-601a70b752ea@oppo.com>
2021-04-30 1:48 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c75229cc-e325-1c8b-0afa-fd236db8319c@oppo.com \
--to=guoweichao@oppo.com \
--cc=huangjianan@oppo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=ltp@lists.linux.it \
--cc=oliver.sang@intel.com \
--cc=rpalethorpe@suse.de \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).