From: Knut Omang <knut.omang@oracle.com>
To: Christopher Lameter <cl@linux.com>, Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: provide interface for retrieving kmem_cache name
Date: Fri, 08 Nov 2019 17:44:10 +0100 [thread overview]
Message-ID: <c77e82629f04f0183853884abbeddd871d8f5ab7.camel@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1911081534470.32431@www.lameter.com>
On Fri, 2019-11-08 at 15:37 +0000, Christopher Lameter wrote:
> On Thu, 7 Nov 2019, Michal Hocko wrote:
>
> > On Thu 07-11-19 13:26:09, Knut Omang wrote:
> > > On Thu, 2019-11-07 at 12:58 +0100, Michal Hocko wrote:
> > > > On Thu 07-11-19 12:54:04, Knut Omang wrote:
> > > > > With the restructuring done in commit 9adeaa226988
> > > > > ("mm, slab: move memcg_cache_params structure to mm/slab.h")
> > > > >
> > > > > it is no longer possible for code external to mm to access
>
> That patch only affected the memcg_cache_params structure and not
> kmem_cache.
>
> And I do not see any references to the memcg_cache_param?
Good point, I should have made explicit reference to it.
It gets inlined into kmem_cache with CONFIG_SLUB if CONFIG_MEMCG is set
(include/linux/slub_def.h, line 112)
> The fields that all allocators need to expose are listed in
> the struct kmme_cache definition in linux/mm/slab.h.
So I take that kmem_cache::name was still intended to be public,
just that that broke due to the inlining of struct memcg_cache_param
in slub_def.h?
Knut
next prev parent reply other threads:[~2019-11-08 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 11:54 [PATCH] mm: provide interface for retrieving kmem_cache name Knut Omang
2019-11-07 11:58 ` Michal Hocko
2019-11-07 12:26 ` Knut Omang
2019-11-07 13:13 ` Michal Hocko
2019-11-07 20:50 ` David Rientjes
2019-11-08 15:37 ` Christopher Lameter
2019-11-08 16:44 ` Knut Omang [this message]
2019-11-08 16:49 ` Christopher Lameter
2019-11-08 20:40 ` Knut Omang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c77e82629f04f0183853884abbeddd871d8f5ab7.camel@oracle.com \
--to=knut.omang@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).