Re: [PATCH] kasan: unpoison use memset to init unaligned object size

From: Yee Lee <yee.lee@mediatek.com>
To: Andrey Konovalov <andreyknvl@gmail.com>
Cc: <wsd_upstream@mediatek.com>,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"open list:KASAN" <kasan-dev@googlegroups.com>,
	"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
	open list <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Marco Elver <elver@google.com>
Subject: Re: [PATCH] kasan: unpoison use memset to init unaligned object size
Date: Wed, 23 Jun 2021 15:31:24 +0800	[thread overview]
Message-ID: <c874a47557ec256664e4cf0914a5e9840a335fe2.camel@mediatek.com> (raw)
In-Reply-To: <CA+fCnZdPwKZ9GfhTYPpWGVEO7bS6sSrh8cioZmRJet2maUjSVQ@mail.gmail.com>

On Tue, 2021-06-22 at 17:03 +0300, Andrey Konovalov wrote:
> On Mon, Jun 21, 2021 at 6:45 PM <yee.lee@mediatek.com> wrote:
> > 
> > From: Yee Lee <yee.lee@mediatek.com>
> > 
> > This patch adds a memset to initialize object of unaligned size.
> > Duing to the MTE granulrity, the integrated initialization using
> > hwtag instruction will force clearing out bytes in granular size,
> > which may cause undesired effect, such as overwriting to the
> > redzone
> > of SLUB debug. In this patch, for the unaligned object size,
> > function
> > uses memset to initailize context instead of the hwtag instruction.
> > 
> > Signed-off-by: Yee Lee <yee.lee@mediatek.com>
> > ---
> >  mm/kasan/kasan.h | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h
> > index 8f450bc28045..d8faa64614b7 100644
> > --- a/mm/kasan/kasan.h
> > +++ b/mm/kasan/kasan.h
> > @@ -387,8 +387,11 @@ static inline void kasan_unpoison(const void
> > *addr, size_t size, bool init)
> > 
> >         if (WARN_ON((unsigned long)addr & KASAN_GRANULE_MASK))
> >                 return;
> > +       if (init && ((unsigned long)size & KASAN_GRANULE_MASK)) {
> > +               init = false;
> > +               memset((void *)addr, 0, size);
> > +       }
> 
> With this implementation, we loose the benefit of setting tags and
> initializing memory with the same instructions.
> 
> Perhaps a better implementation would be to call
> hw_set_mem_tag_range() with the size rounded down, and then
> separately
> deal with the leftover memory.

Yes, this fully takes the advantage of hw instruction. 
However, the leftover memory needs one more hw_set_mem_tag_range() for
protection as well.

If the extra path is only executed as CONFIG_SLUB_DEBUG, the
performance lost would be less concerned.

> 
> >         size = round_up(size, KASAN_GRANULE_SIZE);
> > -
> >         hw_set_mem_tag_range((void *)addr, size, tag, init);
> >  }
> > 
> > --
> > 2.18.0
> > 