From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37EF2C433DB for ; Fri, 19 Feb 2021 00:22:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 94B3164EC0 for ; Fri, 19 Feb 2021 00:22:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94B3164EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E3C8F6B0005; Thu, 18 Feb 2021 19:22:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DEB3C6B006C; Thu, 18 Feb 2021 19:22:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB2D16B006E; Thu, 18 Feb 2021 19:22:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id B6EAD6B0005 for ; Thu, 18 Feb 2021 19:22:32 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7ABE475B0 for ; Fri, 19 Feb 2021 00:22:32 +0000 (UTC) X-FDA: 77833116144.19.149D152 Received: from mail-qt1-f201.google.com (mail-qt1-f201.google.com [209.85.160.201]) by imf12.hostedemail.com (Postfix) with ESMTP id 3AA2F130 for ; Fri, 19 Feb 2021 00:22:28 +0000 (UTC) Received: by mail-qt1-f201.google.com with SMTP id z3so2246880qtv.20 for ; Thu, 18 Feb 2021 16:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=U/iWzYWPjCN+XW1A2BqmtUjlIIZumhGvP/yo+EmOxYg=; b=G7bAXsSfm+ZNftqz1PsApsrrwJT8rMmTOEArec4kk5JfXkHSn5yAxj9DM4umoFPnWp RGmtL7d5uL9H7zRtAjVAbKIkaAF8ufdT94u9akurg8SFStJwtepBldAe7CzJ3uhcaMzp 9WEo3HH6yOSmwI+Lcgdd4NIQ6NS6Js00aG5ddncE4w0J4+Ks2433wNoGqaOZDjsXit0l tdPTVlwbwaNJ+GN5c/McwoIy7K8gu4vVTR2V/16/tycbQ9v2qp4R93lfHwogeNIl0Kjn NzIwqCWwxxy9qLwZ9Mf402aMCg10rkgFlP6McJvh2yH2Fz6dXez8C9TT4sRw8BpZBGe+ MWNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=U/iWzYWPjCN+XW1A2BqmtUjlIIZumhGvP/yo+EmOxYg=; b=EbdLQHgGU3KbKaMDuoIUVLLl7iaWbS3DZuZJzARpSU4JyOBeC4+n/zDDwieRwqmYG3 56MLXb8CthYQSLBexdqAA29dl+dGBwt6J/dvzfnJcF0zfhm34p/Tzsdw9akU4SfWMofD BnDnga/MJqdTlq/P8Bjw83QLQ4qxeNVAzT6+1g/UCcKg+Qc5epZ+jTf8ad7OQWHeNyRC X4jg1qYYvMqieYCMSeYx0vcsPwnZ6D7BJWd6W9IK5Lp/VhC70mrCW+ZRPWuqppk4iqJl H6Av6SWWNUgv3W/K6UB7MfHhRiZO3+oOIejUEMkuGae/vZBFC6BdX4/F2M5xaPyJRD5Q qDIA== X-Gm-Message-State: AOAM531fyI13SoVLPtWa6i1atlrPcngjIGkmuJ18WIdvRx82zo+/9LCZ eCqbSPR5EphAjaaazDRRtVIvRu8U5BgPwNFQ X-Google-Smtp-Source: ABdhPJyFsVJtAau0Mc2BHt611wI2ENN7q1M05EoS8ziF6kD66XPpoztxHVTEQqqAY5LyC/zaszm81323HxFZMODP X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:2d89:512e:587f:6e72]) (user=andreyknvl job=sendgmr) by 2002:a0c:8b8a:: with SMTP id r10mr6826124qva.52.1613694151028; Thu, 18 Feb 2021 16:22:31 -0800 (PST) Date: Fri, 19 Feb 2021 01:22:23 +0100 Message-Id: Mime-Version: 1.0 X-Mailer: git-send-email 2.30.0.617.g56c4b15f3c-goog Subject: [PATCH v2 1/2] kasan: initialize shadow to TAG_INVALID for SW_TAGS From: Andrey Konovalov To: Andrew Morton Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3AA2F130 X-Stat-Signature: 7f316e1cgxmkiqqt5uaqj97jnkjo8jz4 Received-SPF: none (flex--andreyknvl.bounces.google.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from="<3xwQvYAoKCJQyB1F2M8BJ94CC492.0CA96BIL-AA8Jy08.CF4@flex--andreyknvl.bounces.google.com>"; helo=mail-qt1-f201.google.com; client-ip=209.85.160.201 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613694148-71445 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, KASAN_SW_TAGS uses 0xFF as the default tag value for unallocated memory. The underlying idea is that since that memory hasn't been allocated yet, it's only supposed to be dereferenced through a pointer with the native 0xFF tag. While this is a good idea in terms on consistency, practically it doesn't bring any benefit. Since the 0xFF pointer tag is a match-all tag, it doesn't matter what tag the accessed memory has. No accesses through 0xFF-tagged pointers are considered buggy by KASAN. This patch changes the default tag value for unallocated memory to 0xFE, which is the tag KASAN uses for inaccessible memory. This doesn't affect accesses through 0xFF-tagged pointer to this memory, but this allows KASAN to detect wild and large out-of-bounds invalid memory accesses through otherwise-tagged pointers. This is a prepatory patch for the next one, which changes the tag-based KASAN modes to not poison the boot memory. Signed-off-by: Andrey Konovalov --- include/linux/kasan.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/kasan.h b/include/linux/kasan.h index 14f72ec96492..44c147dae7e3 100644 --- a/include/linux/kasan.h +++ b/include/linux/kasan.h @@ -30,7 +30,8 @@ struct kunit_kasan_expectation { /* Software KASAN implementations use shadow memory. */ #ifdef CONFIG_KASAN_SW_TAGS -#define KASAN_SHADOW_INIT 0xFF +/* This matches KASAN_TAG_INVALID. */ +#define KASAN_SHADOW_INIT 0xFE #else #define KASAN_SHADOW_INIT 0 #endif -- 2.30.0.617.g56c4b15f3c-goog