From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2826C43603 for ; Thu, 5 Dec 2019 03:42:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A00A4206DB for ; Thu, 5 Dec 2019 03:42:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A00A4206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=au1.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22E0B6B0E2F; Wed, 4 Dec 2019 22:42:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DEB56B0E30; Wed, 4 Dec 2019 22:42:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A8366B0E31; Wed, 4 Dec 2019 22:42:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id E10816B0E2F for ; Wed, 4 Dec 2019 22:42:26 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id AB9D845B4 for ; Thu, 5 Dec 2019 03:42:26 +0000 (UTC) X-FDA: 76229690292.16.bulb74_325ae41c4cd22 X-HE-Tag: bulb74_325ae41c4cd22 X-Filterd-Recvd-Size: 17307 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 03:42:25 +0000 (UTC) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB53WKsa061869 for ; Wed, 4 Dec 2019 22:42:25 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wnsuwx9gj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 04 Dec 2019 22:42:24 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Dec 2019 03:42:22 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 5 Dec 2019 03:42:15 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xB53gE8p49152176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Dec 2019 03:42:14 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1BCD9A404D; Thu, 5 Dec 2019 03:42:14 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6EA1AA405E; Thu, 5 Dec 2019 03:42:13 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 5 Dec 2019 03:42:13 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id C0A28A010B; Thu, 5 Dec 2019 14:42:10 +1100 (AEDT) Subject: Re: [PATCH v2 16/27] nvdimm/ocxl: Implement the Read Error Log command From: "Alastair D'Silva" To: "Alastair D'Silva" Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Keith Busch , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org Date: Thu, 05 Dec 2019 14:42:12 +1100 In-Reply-To: <20191203034655.51561-17-alastair@au1.ibm.com> References: <20191203034655.51561-1-alastair@au1.ibm.com> <20191203034655.51561-17-alastair@au1.ibm.com> Organization: IBM Australia Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19120503-0028-0000-0000-000003C5175C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19120503-0029-0000-0000-0000248837E1 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-04_04:2019-12-04,2019-12-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 phishscore=0 clxscore=1015 adultscore=0 suspectscore=2 bulkscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912050023 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2019-12-03 at 14:46 +1100, Alastair D'Silva wrote: > From: Alastair D'Silva > > The read error log command extracts information from the controller's > internal error log. > > This patch exposes this information in 2 ways: > - During probe, if an error occurs & a log is available, print it to > the > console > - After probe, make the error log available to userspace via an > IOCTL. > Userspace is notified of pending error logs in a later patch > ("nvdimm/ocxl: Forward events to userspace") > > Signed-off-by: Alastair D'Silva > --- > drivers/nvdimm/ocxl/scm.c | 270 > +++++++++++++++++++++++++++++ > drivers/nvdimm/ocxl/scm_internal.h | 1 + > include/uapi/nvdimm/ocxl-scm.h | 46 +++++ > 3 files changed, 317 insertions(+) > create mode 100644 include/uapi/nvdimm/ocxl-scm.h > > diff --git a/drivers/nvdimm/ocxl/scm.c b/drivers/nvdimm/ocxl/scm.c > index c313a473a28e..0bbe1a14291e 100644 > --- a/drivers/nvdimm/ocxl/scm.c > +++ b/drivers/nvdimm/ocxl/scm.c > @@ -495,10 +495,220 @@ static int scm_file_release(struct inode > *inode, struct file *file) > return 0; > } > > +/** > + * scm_error_log_header_parse() - Parse the first 64 bits of the > error log command response > + * @scm_data: the SCM metadata > + * @length: out, returns the number of bytes in the response > (excluding the 64 bit header) > + */ > +static int scm_error_log_header_parse(struct scm_data *scm_data, u16 > *length) > +{ > + int rc; > + u64 val; > + > + u16 data_identifier; > + u32 data_length; > + > + rc = ocxl_global_mmio_read64(scm_data->ocxl_afu, > + scm_data- > >admin_command.data_offset, > + OCXL_LITTLE_ENDIAN, &val); > + if (rc) > + return rc; > + > + data_identifier = val >> 48; > + data_length = val & 0xFFFF; > + > + if (data_identifier != 0x454C) { > + dev_err(&scm_data->dev, > + "Bad data identifier for error log data, > expected 'EL', got '%2s' (%#x), data_length=%u\n", > + (char *)&data_identifier, > + (unsigned int)data_identifier, data_length); > + return -EINVAL; > + } > + > + *length = data_length; > + return 0; > +} > + > +static int scm_error_log_offset_0x08(struct scm_data *scm_data, > + u32 *log_identifier, u32 > *program_ref_code) > +{ > + int rc; > + u64 val; > + > + rc = ocxl_global_mmio_read64(scm_data->ocxl_afu, > + scm_data- > >admin_command.data_offset + 0x08, > + OCXL_LITTLE_ENDIAN, &val); > + if (rc) > + return rc; > + > + *log_identifier = val >> 32; > + *program_ref_code = val & 0xFFFFFFFF; > + > + return 0; > +} > + > +static int scm_read_error_log(struct scm_data *scm_data, > + struct scm_ioctl_error_log *log, bool > buf_is_user) > +{ > + u64 val; > + u16 user_buf_length; > + u16 buf_length; > + u16 i; > + int rc; > + > + if (log->buf_size % 8) > + return -EINVAL; > + > + rc = scm_chi(scm_data, &val); > + if (rc) > + goto out; > + > + if (!(val & GLOBAL_MMIO_CHI_ELA)) > + return -EAGAIN; > + > + user_buf_length = log->buf_size; > + > + mutex_lock(&scm_data->admin_command.lock); > + > + rc = scm_admin_command_request(scm_data, ADMIN_COMMAND_ERRLOG); > + if (rc) > + goto out; > + > + rc = scm_admin_command_execute(scm_data); > + if (rc) > + goto out; > + > + rc = scm_admin_command_complete_timeout(scm_data, > ADMIN_COMMAND_ERRLOG); > + if (rc < 0) { > + dev_warn(&scm_data->dev, "Read error log timed out\n"); > + goto out; > + } > + > + rc = scm_admin_response(scm_data); > + if (rc < 0) > + goto out; > + if (rc != STATUS_SUCCESS) { > + scm_warn_status(scm_data, "Unexpected status from > retrieve error log", rc); > + goto out; > + } > + > + > + rc = scm_error_log_header_parse(scm_data, &log->buf_size); > + if (rc) > + goto out; > + // log->buf_size now contains the scm buffer size, not the user > size > + > + rc = scm_error_log_offset_0x08(scm_data, &log->log_identifier, > + &log->program_reference_code); > + if (rc) > + goto out; > + > + rc = ocxl_global_mmio_read64(scm_data->ocxl_afu, > + scm_data- > >admin_command.data_offset + 0x10, > + OCXL_LITTLE_ENDIAN, &val); > + if (rc) > + goto out; > + > + log->error_log_type = val >> 56; > + log->action_flags = (log->error_log_type == > SCM_ERROR_LOG_TYPE_GENERAL) ? > + (val >> 32) & 0xFFFFFF : 0; > + log->power_on_seconds = val & 0xFFFFFFFF; > + > + rc = ocxl_global_mmio_read64(scm_data->ocxl_afu, > + scm_data- > >admin_command.data_offset + 0x18, > + OCXL_LITTLE_ENDIAN, &log- > >timestamp); > + if (rc) > + goto out; > + > + rc = ocxl_global_mmio_read64(scm_data->ocxl_afu, > + scm_data- > >admin_command.data_offset + 0x20, > + OCXL_HOST_ENDIAN, &log->wwid[0]); > + if (rc) > + goto out; > + > + rc = ocxl_global_mmio_read64(scm_data->ocxl_afu, > + scm_data- > >admin_command.data_offset + 0x28, > + OCXL_HOST_ENDIAN, &log->wwid[1]); > + if (rc) > + goto out; > + > + rc = ocxl_global_mmio_read64(scm_data->ocxl_afu, > + scm_data- > >admin_command.data_offset + 0x30, > + OCXL_HOST_ENDIAN, (u64 *)log- > >fw_revision); > + if (rc) > + goto out; > + log->fw_revision[8] = '\0'; > + > + buf_length = (user_buf_length < log->buf_size) ? > + user_buf_length : log->buf_size; > + for (i = 0; i < buf_length + 0x48; i += 8) { > + u64 val; > + > + rc = ocxl_global_mmio_read64(scm_data->ocxl_afu, > + scm_data- > >admin_command.data_offset + i, > + OCXL_HOST_ENDIAN, &val); > + if (rc) > + goto out; > + > + if (buf_is_user) { > + if (copy_to_user(&log->buf[i], &val, > sizeof(u64))) { > + rc = -EFAULT; > + goto out; > + } > + } else > + log->buf[i] = val; > + } > + > + rc = scm_admin_response_handled(scm_data); > + if (rc) > + goto out; > + > +out: > + mutex_unlock(&scm_data->admin_command.lock); > + return rc; > + > +} > + > +static int scm_ioctl_error_log(struct scm_data *scm_data, > + struct scm_ioctl_error_log __user *uarg) > +{ > + struct scm_ioctl_error_log args; > + int rc; > + > + if (copy_from_user(&args, uarg, sizeof(args))) > + return -EFAULT; > + > + rc = scm_read_error_log(scm_data, &args, true); > + if (rc) > + return rc; > + > + if (copy_to_user(uarg, &args, sizeof(args))) > + return -EFAULT; > + > + return 0; > +} > + > +static long scm_file_ioctl(struct file *file, unsigned int cmd, > + unsigned long args) > +{ > + struct scm_data *scm_data = file->private_data; > + int rc = -EINVAL; > + > + switch (cmd) { > + case SCM_IOCTL_ERROR_LOG: > + rc = scm_ioctl_error_log(scm_data, > + (struct scm_ioctl_error_log > __user *)args); > + break; > + } > + return rc; > +} > + > static const struct file_operations scm_fops = { > .owner = THIS_MODULE, > .open = scm_file_open, > .release = scm_file_release, > + .unlocked_ioctl = scm_file_ioctl, > + .compat_ioctl = scm_file_ioctl, > }; > > /** > @@ -575,6 +785,60 @@ static int read_device_metadata(struct scm_data > *scm_data) > return 0; > } > > +static const char *scm_decode_error_log_type(u8 error_log_type) > +{ > + switch (error_log_type) { > + case 0x00: > + return "general"; > + case 0x01: > + return "predictive failure"; > + case 0x02: > + return "thermal warning"; > + case 0x03: > + return "data loss"; > + case 0x04: > + return "health & performance"; > + default: > + return "unknown"; > + } > +} > + > +static void scm_dump_error_log(struct scm_data *scm_data) > +{ > + struct scm_ioctl_error_log log; > + u32 buf_size; > + u8 *buf; > + int rc; > + > + if (scm_data->admin_command.data_size == 0) > + return; > + > + buf_size = scm_data->admin_command.data_size - 0x48; > + buf = kzalloc(buf_size, GFP_KERNEL); > + if (!buf) > + return; > + > + log.buf = buf; > + log.buf_size = buf_size; > + > + rc = scm_read_error_log(scm_data, &log, false); > + if (rc < 0) > + goto out; > + > + dev_warn(&scm_data->dev, > + "SCM Error log: WWID=0x%016llx%016llx LID=0x%x PRC=%x > type=0x%x %s, Uptime=%u seconds timestamp=0x%llx\n", > + log.wwid[0], log.wwid[1], > + log.log_identifier, log.program_reference_code, > + log.error_log_type, > + scm_decode_error_log_type(log.error_log_type), > + log.power_on_seconds, log.timestamp); > + print_hex_dump(KERN_WARNING, "buf", DUMP_PREFIX_OFFSET, 16, 1, > buf, > + log.buf_size, false); > + > +out: > + kfree(buf); > +} > + > /** > * scm_probe_function_0 - Set up function 0 for an OpenCAPI Storage > Class Memory device > * This is important as it enables templates higher than 0 across > all other functions, > @@ -617,6 +881,7 @@ static int scm_probe(struct pci_dev *pdev, const > struct pci_device_id *ent) > struct scm_data *scm_data = NULL; > int elapsed; > u16 timeout; > + u64 chi; > > if (PCI_FUNC(pdev->devfn) == 0) > return scm_probe_function_0(pdev); > @@ -707,6 +972,11 @@ static int scm_probe(struct pci_dev *pdev, const > struct pci_device_id *ent) > return 0; > > err: > + if (scm_data && > + (scm_chi(scm_data, &chi) == 0) && > + (chi & GLOBAL_MMIO_CHI_ELA)) > + scm_dump_error_log(scm_data); > + > /* > * Further cleanup is done in the release handler via > free_scm() > * This allows us to keep the character device live to handle > IOCTLs to > diff --git a/drivers/nvdimm/ocxl/scm_internal.h > b/drivers/nvdimm/ocxl/scm_internal.h > index 57491dbee1a4..9bf8fcf30ea6 100644 > --- a/drivers/nvdimm/ocxl/scm_internal.h > +++ b/drivers/nvdimm/ocxl/scm_internal.h > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include This should be uapi/nvdimm/ocxl-scm.h > #include > > #define SCM_DEFAULT_TIMEOUT 100 > diff --git a/include/uapi/nvdimm/ocxl-scm.h > b/include/uapi/nvdimm/ocxl-scm.h > new file mode 100644 > index 000000000000..b34dd1ba06ff > --- /dev/null > +++ b/include/uapi/nvdimm/ocxl-scm.h > @@ -0,0 +1,46 @@ > +/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */ > +/* Copyright 2017 IBM Corp. */ > +#ifndef _UAPI_OCXL_SCM_H > +#define _UAPI_OCXL_SCM_H > + > +#include > +#include > + > +#define SCM_ERROR_LOG_ACTION_RESET (1 << (32-32)) > +#define SCM_ERROR_LOG_ACTION_CHKFW (1 << (53-32)) > +#define SCM_ERROR_LOG_ACTION_REPLACE (1 << (54-32)) > +#define SCM_ERROR_LOG_ACTION_DUMP (1 << (55-32)) > + > +#define SCM_ERROR_LOG_TYPE_GENERAL (0x00) > +#define SCM_ERROR_LOG_TYPE_PREDICTIVE_FAILURE (0x01) > +#define SCM_ERROR_LOG_TYPE_THERMAL_WARNING (0x02) > +#define SCM_ERROR_LOG_TYPE_DATA_LOSS (0x03) > +#define SCM_ERROR_LOG_TYPE_HEALTH_PERFORMANCE (0x04) > + > +struct scm_ioctl_error_log { > + __u32 log_identifier; // out > + __u32 program_reference_code; // out > + __u32 action_flags; //out, recommended course of action > + __u32 power_on_seconds; // out, Number of seconds the > controller has been on when the error occurred > + __u64 timestamp; // out, relative time since the current IPL > + __u64 wwid[2]; // out, the NAA formatted WWID associated with > the controller > + char fw_revision[8+1]; // out, firmware revision as null > terminated text > + __u16 buf_size; /* in/out, buffer size provided/required. > + * If required is greater than provided, the > buffer > + * will be truncated to the amount provided. If > its > + * less, then only the required bytes will be > populated. > + * If it is 0, then there are no more error log > entries. > + */ > + __u8 error_log_type; > + __u8 reserved1; > + __u32 reserved2; > + __u64 reserved3[2]; > + __u8 *buf; // pointer to output buffer > +}; > + > +/* ioctl numbers */ > +#define SCM_MAGIC 0x5C > +/* SCM devices */ > +#define SCM_IOCTL_ERROR_LOG _IOWR(SCM_MAGIC, 0x01, struct > scm_ioctl_error_log) > + > +#endif /* _UAPI_OCXL_SCM_H */ -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819