From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A11A5C433EF for ; Tue, 11 Jan 2022 08:53:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CC4F6B0072; Tue, 11 Jan 2022 03:53:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27BFA6B0073; Tue, 11 Jan 2022 03:53:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16A8E6B0074; Tue, 11 Jan 2022 03:53:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 053ED6B0072 for ; Tue, 11 Jan 2022 03:53:40 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A9ED182DB2 for ; Tue, 11 Jan 2022 08:53:39 +0000 (UTC) X-FDA: 79017392958.15.F459F4F Received: from mail.itouring.de (mail.itouring.de [85.10.202.141]) by imf13.hostedemail.com (Postfix) with ESMTP id C402C20011 for ; Tue, 11 Jan 2022 08:53:38 +0000 (UTC) Received: from tux.applied-asynchrony.com (p5b07ee01.dip0.t-ipconnect.de [91.7.238.1]) by mail.itouring.de (Postfix) with ESMTPSA id E4900103765; Tue, 11 Jan 2022 09:53:36 +0100 (CET) Received: from [192.168.100.221] (hho.applied-asynchrony.com [192.168.100.221]) by tux.applied-asynchrony.com (Postfix) with ESMTP id 75FA3F01624; Tue, 11 Jan 2022 09:53:36 +0100 (CET) Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework To: Yu Zhao , Alexandre Frade , Brian Geffon , Daniel Byrne , Jan Alexander Steffens , Shuang Zhai , Sofia Trinh , Steven Barrett , Suleiman Souhlal Cc: Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Andrew Morton , Linus Torvalds References: <20220104202227.2903605-1-yuzhao@google.com> From: =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= Organization: Applied Asynchrony, Inc. Message-ID: Date: Tue, 11 Jan 2022 09:53:36 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: C402C20011 X-Stat-Signature: rmd64x7q8sxdytcdpb49bwwbnn7h4n7n Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of holger@applied-asynchrony.com designates 85.10.202.141 as permitted sender) smtp.mailfrom=holger@applied-asynchrony.com; dmarc=pass (policy=none) header.from=applied-asynchrony.com X-Rspamd-Server: rspam08 X-HE-Tag: 1641891218-492240 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-01-11 09:41, Yu Zhao wrote: > On Tue, Jan 04, 2022 at 01:30:00PM -0700, Yu Zhao wrote: >> On Tue, Jan 04, 2022 at 01:22:19PM -0700, Yu Zhao wrote: >>> TLDR >>> =3D=3D=3D=3D >>> The current page reclaim is too expensive in terms of CPU usage and i= t >>> often makes poor choices about what to evict. This patchset offers an >>> alternative solution that is performant, versatile and >>> straightforward. >> >> >> >>> Summery >>> =3D=3D=3D=3D=3D=3D=3D >>> The facts are: >>> 1. The independent lab results and the real-world applications >>> indicate substantial improvements; there are no known regressions= . >>> 2. Thrashing prevention, working set estimation and proactive reclaim >>> work out of the box; there are no equivalent solutions. >>> 3. There is a lot of new code; nobody has demonstrated smaller change= s >>> with similar effects. >>> >>> Our options, accordingly, are: >>> 1. Given the amount of evidence, the reported improvements will likel= y >>> materialize for a wide range of workloads. >>> 2. Gauging the interest from the past discussions [14][15][16], the >>> new features will likely be put to use for both personal computer= s >>> and data centers. >>> 3. Based on Google's track record, the new code will likely be well >>> maintained in the long term. It'd be more difficult if not >>> impossible to achieve similar effects on top of the existing >>> design. >> >> Hi Andrew, Linus, >> >> Can you please take a look at this patchset and let me know if it's >> 5.17 material? >> >> My goal is to get it merged asap so that users can reap the benefits >> and I can push the sequels. Please examine the data provided -- I >> think the unprecedented coverage and the magnitude of the improvements >> warrant a green light. >=20 > Downstream kernel maintainers who have been carrying MGLRU for more tha= n > 3 versions, can you please provide your Acked-by tags? >=20 > Having this patchset in the mainline will make your job easier :) >=20 > Alexandre - the XanMod Kernel maintainer > https://xanmod.org > =20 > Brian - the Chrome OS kernel memory maintainer > https://www.chromium.org > =20 > Jan - the Arch Linux Zen kernel maintainer > https://archlinux.org > =20 > Steven - the Liquorix kernel maintainer > https://liquorix.net > =20 > Suleiman - the ARCVM (Android downstream) kernel memory maintainer > https://chromium.googlesource.com/chromiumos/third_part= y/kernel >=20 > Also my gratitude to those who have helped test MGLRU: >=20 > Daniel - researcher at Michigan Tech > benchmarked memcached > =20 > Holger - who has been testing/patching/contributing to various > subsystems since ~2008 > =20 > Shuang - researcher at University of Rochester > benchmarked fio and provided a report > =20 > Sofia - EDI https://www.edi.works > benchmarked the top eight memory hogs and provided reports >=20 > Can you please provide your Tested-by tags? This will ensure the credit > for your contributions. >=20 > Thanks! >=20 Have been pounding on this "in production" on several different machines (server, desktop, laptop) and 5.15.x without any issues, so: Tested-by: Holger Hoffst=C3=A4tte Looking forward to seeing this in mainline! cheers, Holger