From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Yang Shi <yang.shi@linux.alibaba.com>,
songliubraving@fb.com, kirill.shutemov@linux.intel.com,
akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE
Date: Thu, 28 Nov 2019 15:12:15 +0530 [thread overview]
Message-ID: <caff6b97-fca8-4155-386a-cdd69717fef9@arm.com> (raw)
In-Reply-To: <1574793844-2914-1-git-send-email-yang.shi@linux.alibaba.com>
On 11/27/2019 12:14 AM, Yang Shi wrote:
> The commit 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem)
> FS") introduced a new khugepaged scan result: SCAN_PAGE_HAS_PRIVATE, but
> the corresponding description for trace events were not added.
>
> Cc: Song Liu <songliubraving@fb.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
> v2: *Adopted the comments from Anshuman Khandual
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
>
> include/trace/events/huge_memory.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
> index dd4db33..d82a0f4 100644
> --- a/include/trace/events/huge_memory.h
> +++ b/include/trace/events/huge_memory.h
> @@ -31,7 +31,8 @@
> EM( SCAN_ALLOC_HUGE_PAGE_FAIL, "alloc_huge_page_failed") \
> EM( SCAN_CGROUP_CHARGE_FAIL, "ccgroup_charge_failed") \
> EM( SCAN_EXCEED_SWAP_PTE, "exceed_swap_pte") \
> - EMe(SCAN_TRUNCATED, "truncated") \
> + EM( SCAN_TRUNCATED, "truncated") \
> + EMe(SCAN_PAGE_HAS_PRIVATE, "page_has_private") \
>
> #undef EM
> #undef EMe
>
prev parent reply other threads:[~2019-11-28 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 18:44 [v2 PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE Yang Shi
2019-11-28 9:42 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caff6b97-fca8-4155-386a-cdd69717fef9@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songliubraving@fb.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).