From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7967C49ED7 for ; Thu, 19 Sep 2019 05:44:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 59B2C21907 for ; Thu, 19 Sep 2019 05:44:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="FtPM45xR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B2C21907 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E7F996B0337; Thu, 19 Sep 2019 01:44:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E55DA6B033A; Thu, 19 Sep 2019 01:44:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D45416B033B; Thu, 19 Sep 2019 01:44:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id B3F566B0337 for ; Thu, 19 Sep 2019 01:44:41 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 60E771E06F for ; Thu, 19 Sep 2019 05:44:41 +0000 (UTC) X-FDA: 75950580762.21.pin96_802d550cf8402 X-HE-Tag: pin96_802d550cf8402 X-Filterd-Recvd-Size: 5491 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Sep 2019 05:44:40 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 46Ym523Fvpz9vBnB; Thu, 19 Sep 2019 07:44:38 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=FtPM45xR; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id E1DzxbKi3YAE; Thu, 19 Sep 2019 07:44:38 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 46Ym521sh9z9vBn5; Thu, 19 Sep 2019 07:44:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1568871878; bh=u3IPZEW+32C7DaDMfn0DvIJKyx2qRHLH39Ao90Ba2vI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FtPM45xRRq+ZMAt65+IvhdTxuzxace0VwgaQdf3cKJJT4y/Eahg1dC/4UOdaGCdh8 2keyDA6ggFlB3Ny+FMd2SlwiqZK/16OHJduDKueIBvHCwUrv+TaOH/TmV6EmcQ6aZD 62XuqZlFMWXmXNg2d+icfo4iXGpGWnUP9d4AjRIg= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1BE5C8B80C; Thu, 19 Sep 2019 07:44:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id kqE2oHvK7TMH; Thu, 19 Sep 2019 07:44:39 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C1DA68B783; Thu, 19 Sep 2019 07:44:36 +0200 (CEST) Subject: Re: [PATCH] mm/pgtable/debug: Fix test validating architecture page table helpers To: Anshuman Khandual , linux-mm@kvack.org Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , linux-arm-kernel@lists.infradead.org, Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" References: <1892b37d1fd9a4ed39e76c4b999b6556077201c0.1568355752.git.christophe.leroy@c-s.fr> From: Christophe Leroy Message-ID: Date: Thu, 19 Sep 2019 07:44:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 18/09/2019 =C3=A0 09:32, Anshuman Khandual a =C3=A9crit=C2=A0: >=20 >=20 > On 09/13/2019 11:53 AM, Christophe Leroy wrote: >> Fix build failure on powerpc. >> >> Fix preemption imbalance. >> >> Signed-off-by: Christophe Leroy >> --- >> mm/arch_pgtable_test.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/mm/arch_pgtable_test.c b/mm/arch_pgtable_test.c >> index 8b4a92756ad8..f2b3c9ec35fa 100644 >> --- a/mm/arch_pgtable_test.c >> +++ b/mm/arch_pgtable_test.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> =20 >> @@ -400,6 +401,8 @@ static int __init arch_pgtable_tests_init(void) >> p4d_clear_tests(p4dp); >> pgd_clear_tests(mm, pgdp); >> =20 >> + pte_unmap(ptep); >> + >> pmd_populate_tests(mm, pmdp, saved_ptep); >> pud_populate_tests(mm, pudp, saved_pmdp); >> p4d_populate_tests(mm, p4dp, saved_pudp); >> >=20 > Hello Christophe, >=20 > I am planning to fold this fix into the current patch and retain your > Signed-off-by. Are you okay with it ? >=20 No problem, do whatever is convenient for you. You can keep the=20 signed-off-by, or use tested-by: as I tested it on PPC32. Christophe