From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F41ECAAA1 for ; Tue, 6 Sep 2022 21:33:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 066528D0006; Tue, 6 Sep 2022 17:33:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F30C88D0002; Tue, 6 Sep 2022 17:33:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF9E88D0006; Tue, 6 Sep 2022 17:33:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CD61B8D0002 for ; Tue, 6 Sep 2022 17:33:35 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A78C61409CA for ; Tue, 6 Sep 2022 21:33:35 +0000 (UTC) X-FDA: 79882962390.04.1AD3155 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf08.hostedemail.com (Postfix) with ESMTP id 6253B160079 for ; Tue, 6 Sep 2022 21:33:35 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id o126so3678523pfb.6 for ; Tue, 06 Sep 2022 14:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date; bh=ZGYMVwiUEuLgtCDiQ8JfQCJPv9C+qcRU1c030cWDM0I=; b=aK9f85kNRa+1y5yKwv2P5ffGl1MdLdYym3bJvNDQqFvl1BAGrABmVa4NGeLFAKyI4I LolMhPS6SJFzYs8R687/VEtDa6xfuNehAJkSlbiTM5KOq355WspKihLK3QY8Kq5zTHGX S9+xb3hU1ETK+YenJ3YLR36Uc4o/2LF4kfTqnVNwSFyR1iLQuPlhmXRqeZ00obBwGvmu kAYEpwpe39C2RyYWCnZxNx/5HgMWjpRnbgOr6l+SAGCBJI2wfmrp529QqzuqyD3BJPj0 Xo+YU3nLQnH41+CaN5h+9GzwQq4uZgo3fajv1p004iqsKnDIXnu7lNmfVgfAgMQlf7PM m1nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date; bh=ZGYMVwiUEuLgtCDiQ8JfQCJPv9C+qcRU1c030cWDM0I=; b=nPsHqgcBLIEBwCi1AIlm/TPPenIsvMyLKV4oncESukDmn7TWtiQV5FjMwJy3sBJJNB LoYzsj+lJqv7lTUQ8n/kGBxdPfJGDFah3o5UZgI2zT+cOxJc6XKpbZUepzZC2/slS9sx r+NkaaICNKwnFGwGJ+jTaz9QO1xEXQtz02Qw1ytOu10G0FkTFBNNpmjBFM85VWK9AD+b WQmFiJZgsf63lY8Gns/jiJ2G0lx7CdoieQPstjyPpXfalqr7CjaL05j7sUVEaDmV8o9s sy7VLdeAODP3ZC54KKySxgqhQ1IcKOeplV6kBOYqJ63tX5OxTTZtJz+BXp8WZ83GrO6E SRPQ== X-Gm-Message-State: ACgBeo05h1lRrdL0rlIVjpX+F+BfCd9xN+x4TM+Xnx7rRhRQKLT945T3 apHcEN+2cnbkLwrM1uBV0spI/w== X-Google-Smtp-Source: AA6agR6Pt8dwvjHQ1jZb5gCP4MjBLzUhUsv4HzaDF9b2ihXBReQO2vBIYu8ZtERIRk87fhEXxlyVMw== X-Received: by 2002:a62:be0e:0:b0:536:76fe:ee96 with SMTP id l14-20020a62be0e000000b0053676feee96mr389440pff.44.1662500014172; Tue, 06 Sep 2022 14:33:34 -0700 (PDT) Received: from [2620:15c:29:203:9177:d472:6043:99cf] ([2620:15c:29:203:9177:d472:6043:99cf]) by smtp.gmail.com with ESMTPSA id a25-20020a62d419000000b005366696b735sm10587853pfh.77.2022.09.06.14.33.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 14:33:33 -0700 (PDT) Date: Tue, 6 Sep 2022 14:33:32 -0700 (PDT) From: David Rientjes To: Chao Yu cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, jaegeuk@kernel.org, Chao Yu , stable@kernel.org, syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com Subject: Re: [PATCH] mm/slub: fix to return errno if kmalloc() fails In-Reply-To: <20220830141009.150075-1-chao@kernel.org> Message-ID: References: <20220830141009.150075-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662500015; a=rsa-sha256; cv=none; b=ZO7P1kUBLXqAQ6F1sBL/ewateW6CFO5Mw/jeUMMPuyb6NzM3Hikyxp3DNcJf+YZAGLio6H EDx6T/5JyhNPpCBabRaraXoqJawA63scYHM7KJs/r0U3YQC57zOTmuQViMbndzaFxnHlbE N02VyXcjmryomw+Q0LH7/TYv75Jke9A= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aK9f85kN; spf=pass (imf08.hostedemail.com: domain of rientjes@google.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662500015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZGYMVwiUEuLgtCDiQ8JfQCJPv9C+qcRU1c030cWDM0I=; b=y+MDS3+hkc97TYoqRe4X6NHpG9leoXHTDP69Lo6kNvRihGqOn2vb8mIEejVQQf6zHCxNDO 17Cnzqqg7TrAGASNJAJyZDMeuqcAT/CXio5gBnthwgH/5yXEq+nZ70J4quqDpODVLY4MDv NcAcx0AWmCLP8SaOol2EjnjCp0dWGIQ= X-Stat-Signature: yr9nh7iq7xjc4f7qtyb4yoghmnd8fisj X-Rspamd-Queue-Id: 6253B160079 X-Rspamd-Server: rspam07 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aK9f85kN; spf=pass (imf08.hostedemail.com: domain of rientjes@google.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1662500015-387575 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 30 Aug 2022, Chao Yu wrote: > From: Chao Yu > > In create_unique_id(), kmalloc(, GFP_KERNEL) can fail due to > out-of-memory, if it fails, return errno correctly rather than > triggering panic via BUG_ON(); > > kernel BUG at mm/slub.c:5893! > Internal error: Oops - BUG: 0 [#1] PREEMPT SMP > > Call trace: > sysfs_slab_add+0x258/0x260 mm/slub.c:5973 > __kmem_cache_create+0x60/0x118 mm/slub.c:4899 > create_cache mm/slab_common.c:229 [inline] > kmem_cache_create_usercopy+0x19c/0x31c mm/slab_common.c:335 > kmem_cache_create+0x1c/0x28 mm/slab_common.c:390 > f2fs_kmem_cache_create fs/f2fs/f2fs.h:2766 [inline] > f2fs_init_xattr_caches+0x78/0xb4 fs/f2fs/xattr.c:808 > f2fs_fill_super+0x1050/0x1e0c fs/f2fs/super.c:4149 > mount_bdev+0x1b8/0x210 fs/super.c:1400 > f2fs_mount+0x44/0x58 fs/f2fs/super.c:4512 > legacy_get_tree+0x30/0x74 fs/fs_context.c:610 > vfs_get_tree+0x40/0x140 fs/super.c:1530 > do_new_mount+0x1dc/0x4e4 fs/namespace.c:3040 > path_mount+0x358/0x914 fs/namespace.c:3370 > do_mount fs/namespace.c:3383 [inline] > __do_sys_mount fs/namespace.c:3591 [inline] > __se_sys_mount fs/namespace.c:3568 [inline] > __arm64_sys_mount+0x2f8/0x408 fs/namespace.c:3568 > > Cc: > Reported-by: syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com > Signed-off-by: Chao Yu Acked-by: David Rientjes