From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9DDC74A36 for ; Thu, 11 Jul 2019 00:16:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 578FF21019 for ; Thu, 11 Jul 2019 00:16:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 578FF21019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E4A3E8E009E; Wed, 10 Jul 2019 20:16:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFAED8E0032; Wed, 10 Jul 2019 20:16:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE8B68E009E; Wed, 10 Jul 2019 20:16:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by kanga.kvack.org (Postfix) with ESMTP id 962118E0032 for ; Wed, 10 Jul 2019 20:16:31 -0400 (EDT) Received: by mail-pg1-f199.google.com with SMTP id d187so2460838pga.7 for ; Wed, 10 Jul 2019 17:16:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=4Ip7emag8pzZ25NnyKyhPC62jEv1a54u1Q3cXUPog/I=; b=NPQydaiLZZesc+OdODedIgfB4EY3DSR8Y1iAXW79V/i4H97GT5vVlMQOh4EOtXciUy brVcMHlC5LTy+s5z7TVAdYntvViv4JVqqdqgEVv1jvdTT8u7GGeTCp35BRvXCImM+UoZ nS9Cy/45SWc9BsXTHyxAKaFEHkbjN39y0EUhiv3pnqLSfBbFhAk8X73ckHmcYtJD1NjD Tfk5pOrV8r54TPCYyjWBWcCYpNJt6ufQM84pAdk66Lb99yXcqqm97UJvoG0updo5C+mx cgG/Slk/2KHcpDqGkX4k6jSCU6Vw4am96UdY3Lim5cZAyoh6YvUioVMEYLewo/1Rb7wz cxAA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of yang.shi@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=yang.shi@linux.alibaba.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alibaba.com X-Gm-Message-State: APjAAAXMM3gGM+E6zkMdUF7e9MwZQIr1l7OSrKe9UpUC6E8vykCdfKyR Y2/vSEqhVrxlPRALBzLRoFLTPOOGdVWuXQmqo3095LwPm26fkk1BJrEzLE+ND7XN6ANH6CWoSI+ Fjat7KTSkGOZLJXDYqVadWR7WnRq1jqXc3gyAal2h67nuwyBA7yDCEcxDW2NWEEjaAg== X-Received: by 2002:a63:550e:: with SMTP id j14mr1002261pgb.302.1562804191174; Wed, 10 Jul 2019 17:16:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEz+o3SnjZ3wW3DyrY3svC3BW4X1KpDNLoSY+blFUt+0Ux2fhXocfNgO4wwy2NR9lgMZO2 X-Received: by 2002:a63:550e:: with SMTP id j14mr1002181pgb.302.1562804189989; Wed, 10 Jul 2019 17:16:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562804189; cv=none; d=google.com; s=arc-20160816; b=NO3LX6zq7eC7sarkttF4LkvlvQ2TzlffbrNKFmQVrUD90930r8ZsWyDu4ahYxWVcbi wQFvcyFmy0jbyWtMwzOnt3yk7ed/XOEQ0OQ9w9iP3FFg9hLYomIfcAe4OFcacsAeb6Vs xyGukZVW+yGMYgX9RQA+tHQyTcT/NJC4mgueLgeyyeLWRSQRyrpYnI32l3UMjSv0oVVf Oak3d8M0m9shlgsSPyF9R+ZQ1naQ7b1wdfjdVy9Q8uF3Z7qEt5nf+Pz1OT6MviYJGbOj m/bJOc0Sx61/B/7wt4zodlIkGMc2XR0w9KwnekrvCYcYuQHB3JLTh+hb/IGlvgpWnz94 DaFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=4Ip7emag8pzZ25NnyKyhPC62jEv1a54u1Q3cXUPog/I=; b=PCJGC4LoqTOpDqYooOIlQwwWmb8RZTXDWbi1uH44+9+nhhNx59CG/MbNRwjIMLcxU/ 02UPpv/TjCxEcqC0QN6YE/rb2jN0QkW7AIMMkMPuYRJsupicG0AB8v+8TCWT5BnryxtN kfqLw4x7ax7Xif0hxv5HDMvlEzbvqoP7tTdPMiofpQC8/4NHT0P5K6jA9IyAuAIp8qDR iBrHcv/f0HMJ9i4AqlG7rMLCIjKHQo++MegrCBt+ZoA3OIiy7yT6aiyDIQ4wVIKSo9nJ uKl3pq9Wq5mEnsDWf019Uq/qaE5bDrEWhn8h6/P2CA+0I/EBVYagrOetIA73kfg76fJ2 +ORw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of yang.shi@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=yang.shi@linux.alibaba.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com. [115.124.30.133]) by mx.google.com with ESMTPS id m9si3436477pgq.373.2019.07.10.17.16.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jul 2019 17:16:29 -0700 (PDT) Received-SPF: pass (google.com: domain of yang.shi@linux.alibaba.com designates 115.124.30.133 as permitted sender) client-ip=115.124.30.133; Authentication-Results: mx.google.com; spf=pass (google.com: domain of yang.shi@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=yang.shi@linux.alibaba.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0TWa8jk1_1562804182; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0TWa8jk1_1562804182) by smtp.aliyun-inc.com(127.0.0.1); Thu, 11 Jul 2019 08:16:26 +0800 Subject: Re: list corruption in deferred_split_scan() To: Qian Cai Cc: "Kirill A. Shutemov" , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1562795006.8510.19.camel@lca.pw> From: Yang Shi Message-ID: Date: Wed, 10 Jul 2019 17:16:21 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1562795006.8510.19.camel@lca.pw> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Qian, Thanks for reporting the issue. But, I can't reproduce it on my machine. Could you please share more details about your test? How often did you run into this problem? Regards, Yang On 7/10/19 2:43 PM, Qian Cai wrote: > Running LTP oom01 test case with swap triggers a crash below. Revert the series > "Make deferred split shrinker memcg aware" [1] seems fix the issue. > > aefde94195ca mm: thp: make deferred split shrinker memcg aware > cf402211cacc mm-shrinker-make-shrinker-not-depend-on-memcg-kmem-fix-2-fix > ca37e9e5f18d mm-shrinker-make-shrinker-not-depend-on-memcg-kmem-fix-2 > 5f419d89cab4 mm-shrinker-make-shrinker-not-depend-on-memcg-kmem-fix > c9d49e69e887 mm: shrinker: make shrinker not depend on memcg kmem > 1c0af4b86bcf mm: move mem_cgroup_uncharge out of __page_cache_release() > 4e050f2df876 mm: thp: extract split_queue_* into a struct > > [1] https://lore.kernel.org/linux-mm/1561507361-59349-1-git-send-email-yang.shi@ > linux.alibaba.com/ > > [ 1145.730682][ T5764] list_del corruption, ffffea00251c8098->next is > LIST_POISON1 (dead000000000100) > [ 1145.739763][ T5764] ------------[ cut here ]------------ > [ 1145.745126][ T5764] kernel BUG at lib/list_debug.c:47! > [ 1145.750320][ T5764] invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN NOPTI > [ 1145.757513][ T5764] CPU: 1 PID: 5764 Comm: oom01 Tainted: > G        W         5.2.0-next-20190710+ #7 > [ 1145.766709][ T5764] Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 > Gen10, BIOS A40 01/25/2019 > [ 1145.776000][ T5764] RIP: 0010:__list_del_entry_valid.cold.0+0x12/0x4a > [ 1145.782491][ T5764] Code: c7 40 5a 33 af e8 ac fe bc ff 0f 0b 48 c7 c7 80 9e > a1 af e8 f6 4c 01 00 4c 89 ea 48 89 de 48 c7 c7 20 59 33 af e8 8c fe bc ff <0f> > 0b 48 c7 c7 40 9f a1 af e8 d6 4c 01 00 4c 89 e2 48 89 de 48 c7 > [ 1145.802078][ T5764] RSP: 0018:ffff888514d773c0 EFLAGS: 00010082 > [ 1145.808042][ T5764] RAX: 000000000000004e RBX: ffffea00251c8098 RCX: > ffffffffae95d318 > [ 1145.815923][ T5764] RDX: 0000000000000000 RSI: 0000000000000008 RDI: > ffff8888440bd380 > [ 1145.823806][ T5764] RBP: ffff888514d773d8 R08: ffffed1108817a71 R09: > ffffed1108817a70 > [ 1145.831689][ T5764] R10: ffffed1108817a70 R11: ffff8888440bd387 R12: > dead000000000122 > [ 1145.839571][ T5764] R13: dead000000000100 R14: ffffea00251c8034 R15: > dead000000000100 > [ 1145.847455][ T5764] FS:  00007f765ad4d700(0000) GS:ffff888844080000(0000) > knlGS:0000000000000000 > [ 1145.856299][ T5764] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 1145.862784][ T5764] CR2: 00007f8cebec7000 CR3: 0000000459338000 CR4: > 00000000001406a0 > [ 1145.870664][ T5764] Call Trace: > [ 1145.873835][ T5764]  deferred_split_scan+0x337/0x740 > [ 1145.878835][ T5764]  ? split_huge_page_to_list+0xe30/0xe30 > [ 1145.884364][ T5764]  ? __radix_tree_lookup+0x12d/0x1e0 > [ 1145.889539][ T5764]  ? node_tag_get.part.0.constprop.6+0x40/0x40 > [ 1145.895592][ T5764]  do_shrink_slab+0x244/0x5a0 > [ 1145.900159][ T5764]  shrink_slab+0x253/0x440 > [ 1145.904462][ T5764]  ? unregister_shrinker+0x110/0x110 > [ 1145.909641][ T5764]  ? kasan_check_read+0x11/0x20 > [ 1145.914383][ T5764]  ? mem_cgroup_protected+0x20f/0x260 > [ 1145.919645][ T5764]  shrink_node+0x31e/0xa30 > [ 1145.923949][ T5764]  ? shrink_node_memcg+0x1560/0x1560 > [ 1145.929126][ T5764]  ? ktime_get+0x93/0x110 > [ 1145.933340][ T5764]  do_try_to_free_pages+0x22f/0x820 > [ 1145.938429][ T5764]  ? shrink_node+0xa30/0xa30 > [ 1145.942906][ T5764]  ? kasan_check_read+0x11/0x20 > [ 1145.947647][ T5764]  ? check_chain_key+0x1df/0x2e0 > [ 1145.952474][ T5764]  try_to_free_pages+0x242/0x4d0 > [ 1145.957299][ T5764]  ? do_try_to_free_pages+0x820/0x820 > [ 1145.962566][ T5764]  __alloc_pages_nodemask+0x9ce/0x1bc0 > [ 1145.967917][ T5764]  ? kasan_check_read+0x11/0x20 > [ 1145.972657][ T5764]  ? gfp_pfmemalloc_allowed+0xc0/0xc0 > [ 1145.977920][ T5764]  ? kasan_check_read+0x11/0x20 > [ 1145.982659][ T5764]  ? check_chain_key+0x1df/0x2e0 > [ 1145.987487][ T5764]  ? do_anonymous_page+0x343/0xe30 > [ 1145.992489][ T5764]  ? lock_downgrade+0x390/0x390 > [ 1145.997230][ T5764]  ? __count_memcg_events+0x8b/0x1c0 > [ 1146.002404][ T5764]  ? kasan_check_read+0x11/0x20 > [ 1146.007145][ T5764]  ? __lru_cache_add+0x122/0x160 > [ 1146.011974][ T5764]  alloc_pages_vma+0x89/0x2c0 > [ 1146.016538][ T5764]  do_anonymous_page+0x3e1/0xe30 > [ 1146.021367][ T5764]  ? __update_load_avg_cfs_rq+0x2c/0x490 > [ 1146.026893][ T5764]  ? finish_fault+0x120/0x120 > [ 1146.031461][ T5764]  ? call_function_interrupt+0xa/0x20 > [ 1146.036724][ T5764]  handle_pte_fault+0x457/0x12c0 > [ 1146.041552][ T5764]  __handle_mm_fault+0x79a/0xa50 > [ 1146.046378][ T5764]  ? vmf_insert_mixed_mkwrite+0x20/0x20 > [ 1146.051817][ T5764]  ? kasan_check_read+0x11/0x20 > [ 1146.056557][ T5764]  ? __count_memcg_events+0x8b/0x1c0 > [ 1146.061732][ T5764]  handle_mm_fault+0x17f/0x370 > [ 1146.066386][ T5764]  __do_page_fault+0x25b/0x5d0 > [ 1146.071037][ T5764]  do_page_fault+0x4c/0x2cf > [ 1146.075426][ T5764]  ? page_fault+0x5/0x20 > [ 1146.079553][ T5764]  page_fault+0x1b/0x20 > [ 1146.083594][ T5764] RIP: 0033:0x410be0 > [ 1146.087373][ T5764] Code: 89 de e8 e3 23 ff ff 48 83 f8 ff 0f 84 86 00 00 00 > 48 89 c5 41 83 fc 02 74 28 41 83 fc 03 74 62 e8 95 29 ff ff 31 d2 48 98 90 > 44 15 00 07 48 01 c2 48 39 d3 7f f3 31 c0 5b 5d 41 5c c3 0f 1f > [ 1146.106959][ T5764] RSP: 002b:00007f765ad4cec0 EFLAGS: 00010206 > [ 1146.112921][ T5764] RAX: 0000000000001000 RBX: 00000000c0000000 RCX: > 00007f98f2674497 > [ 1146.120804][ T5764] RDX: 0000000001d95000 RSI: 00000000c0000000 RDI: > 0000000000000000 > [ 1146.128687][ T5764] RBP: 00007f74d9d4c000 R08: 00000000ffffffff R09: > 0000000000000000 > [ 1146.136569][ T5764] R10: 0000000000000022 R11: 000000000[ 1147.588181][ > T5764] Shutting down cpus with NMI > [ 1147.592756][ T5764] Kernel Offset: 0x2d400000 from 0xffffffff81000000 > (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > [ 1147.604414][ T5764] ---[ end Kernel panic - not syncing: Fatal exception ]---