From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E90C433DF for ; Tue, 14 Jul 2020 12:07:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DA5732220D for ; Tue, 14 Jul 2020 12:07:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA5732220D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 47E286B0003; Tue, 14 Jul 2020 08:07:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42ECA6B0005; Tue, 14 Jul 2020 08:07:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3442A6B0006; Tue, 14 Jul 2020 08:07:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 1A3AD6B0003 for ; Tue, 14 Jul 2020 08:07:38 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6FE18181AEF00 for ; Tue, 14 Jul 2020 12:07:37 +0000 (UTC) X-FDA: 77036556954.17.page29_46142a226ef0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id E16E3180CF5E1 for ; Tue, 14 Jul 2020 12:07:00 +0000 (UTC) X-HE-Tag: page29_46142a226ef0 X-Filterd-Recvd-Size: 2331 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jul 2020 12:07:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DCB87B021; Tue, 14 Jul 2020 12:07:01 +0000 (UTC) Subject: Re: [PATCH v2 3/6] mm: Print head flags in dump_page To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton , John Hubbard , "Kirill A. Shutemov" , William Kucharski , Mike Rapoport References: <20200709202117.7216-1-willy@infradead.org> <20200709202117.7216-4-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Tue, 14 Jul 2020 14:06:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709202117.7216-4-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E16E3180CF5E1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/9/20 10:21 PM, Matthew Wilcox (Oracle) wrote: > Tail page flags contain very little useful information. Print the head > page's flags instead. While the flags will contain "head" for tail pages, > this should not be too confusing as the previous line starts with the > word "head:" and so the flags should be interpreted as belonging to > the head page. Should be fine, hopefully. > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Vlastimil Babka > --- > mm/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/debug.c b/mm/debug.c > index f35c1ae1a7a5..d2ffc926d8f5 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -162,7 +162,7 @@ void __dump_page(struct page *page, const char *reason) > out_mapping: > BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1); > > - pr_warn("%sflags: %#lx(%pGp)%s\n", type, page->flags, &page->flags, > + pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags, &head->flags, > page_cma ? " CMA" : ""); > > hex_only: >