From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA068C352A3 for ; Tue, 11 Feb 2020 11:49:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8445F20842 for ; Tue, 11 Feb 2020 11:49:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8445F20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3369E6B02BA; Tue, 11 Feb 2020 06:49:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E70C6B02BB; Tue, 11 Feb 2020 06:49:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FCF96B02BC; Tue, 11 Feb 2020 06:49:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 0503D6B02BA for ; Tue, 11 Feb 2020 06:49:09 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 85E19181AEF00 for ; Tue, 11 Feb 2020 11:49:08 +0000 (UTC) X-FDA: 76477675176.21.beef85_6ce3c5789531f X-HE-Tag: beef85_6ce3c5789531f X-Filterd-Recvd-Size: 2154 Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Feb 2020 11:49:08 +0000 (UTC) Received: from dhcp-172-16-24-104.sw.ru ([172.16.24.104]) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1j1U2F-0007Ti-OE; Tue, 11 Feb 2020 14:49:00 +0300 Subject: Re: [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs() To: Vasily Averin , akpm@linux-foundation.org, guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <158142103093.888182.8911729633457501747.stgit@localhost.localdomain> <792e25d0-413f-28e0-1fd0-560523b63a45@virtuozzo.com> From: Kirill Tkhai Message-ID: Date: Tue, 11 Feb 2020 14:48:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <792e25d0-413f-28e0-1fd0-560523b63a45@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.02.2020 14:46, Vasily Averin wrote: > On 2/11/20 2:38 PM, Kirill Tkhai wrote: >> Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break(). >> >> Fixes: bf8d5d52ffe8 "memcg: introduce memory.min" >> Signed-off-by: Kirill Tkhai >> --- >> mm/vmscan.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index b1863de475fb..f6efe2348ba3 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) >> continue; >> } >> memcg_memory_event(memcg, MEMCG_LOW); >> - break; > > It is not cycle break, it is switch/case break. Oh, I missed this, thanks. >> + /* fallthrough */ >> case MEMCG_PROT_NONE: >> + mem_cgroup_iter_break(target_memcg, memcg); >> /* >> * All protection thresholds breached. We may >> * still choose to vary the scan pressure >> >>