From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2168C4361B for ; Tue, 8 Dec 2020 03:41:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5BAB1239EB for ; Tue, 8 Dec 2020 03:41:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BAB1239EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 958B38D0015; Mon, 7 Dec 2020 22:41:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E1998D0001; Mon, 7 Dec 2020 22:41:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D1008D0015; Mon, 7 Dec 2020 22:41:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 62FBE8D0001 for ; Mon, 7 Dec 2020 22:41:33 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 23B70181AEF21 for ; Tue, 8 Dec 2020 03:41:33 +0000 (UTC) X-FDA: 77568715266.28.night64_1a0d431273e3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 0A3386D67 for ; Tue, 8 Dec 2020 03:41:33 +0000 (UTC) X-HE-Tag: night64_1a0d431273e3 X-Filterd-Recvd-Size: 2897 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 03:41:30 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UHwrZ-V_1607398881; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UHwrZ-V_1607398881) by smtp.aliyun-inc.com(127.0.0.1); Tue, 08 Dec 2020 11:41:22 +0800 Subject: Re: [PATCH 01/11] mm: use add_page_to_lru_list() To: Yu Zhao , Andrew Morton , Hugh Dickins Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201207220949.830352-1-yuzhao@google.com> <20201207220949.830352-2-yuzhao@google.com> From: Alex Shi Message-ID: Date: Tue, 8 Dec 2020 11:41:21 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201207220949.830352-2-yuzhao@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Reviewed-by: Alex Shi =E5=9C=A8 2020/12/8 =E4=B8=8A=E5=8D=886:09, Yu Zhao =E5=86=99=E9=81=93: > There is add_page_to_lru_list(), and move_pages_to_lru() should reuse > it, not duplicate it. >=20 > Signed-off-by: Yu Zhao > --- > mm/vmscan.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 469016222cdb..a174594e40f8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1821,7 +1821,6 @@ static unsigned noinline_for_stack move_pages_to_= lru(struct lruvec *lruvec, > int nr_pages, nr_moved =3D 0; > LIST_HEAD(pages_to_free); > struct page *page; > - enum lru_list lru; > =20 > while (!list_empty(list)) { > page =3D lru_to_page(list); > @@ -1866,11 +1865,8 @@ static unsigned noinline_for_stack move_pages_to= _lru(struct lruvec *lruvec, > * inhibits memcg migration). > */ > VM_BUG_ON_PAGE(!lruvec_holds_page_lru_lock(page, lruvec), page); > - lru =3D page_lru(page); > + add_page_to_lru_list(page, lruvec, page_lru(page)); > nr_pages =3D thp_nr_pages(page); > - > - update_lru_size(lruvec, lru, page_zonenum(page), nr_pages); > - list_add(&page->lru, &lruvec->lists[lru]); > nr_moved +=3D nr_pages; > if (PageActive(page)) > workingset_age_nonresident(lruvec, nr_pages); >=20