From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D61C07E96 for ; Tue, 6 Jul 2021 04:38:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E373C6198D for ; Tue, 6 Jul 2021 04:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E373C6198D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 673B16B0011; Tue, 6 Jul 2021 00:38:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 649A16B0036; Tue, 6 Jul 2021 00:38:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C3876B005D; Tue, 6 Jul 2021 00:38:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 284C86B0011 for ; Tue, 6 Jul 2021 00:38:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8B6CF1801C1A1 for ; Tue, 6 Jul 2021 04:38:39 +0000 (UTC) X-FDA: 78330907158.28.65F22BC Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by imf25.hostedemail.com (Postfix) with ESMTP id 00003B000293 for ; Tue, 6 Jul 2021 04:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1625546315; bh=ZxhGIG2OkUGFZUIh7V4unqo2ELzbDu8A5k97ZBWkPeY=; h=X-UI-Sender-Class:Subject:From:To:Cc:Date:In-Reply-To:References; b=Y45UnbzpVH8Lb+x3gchSikFLPaurgNQyZUIgkW6tKlfSwEyFsoKzcW4vx1IuyFiO7 pjzj0z5aXya7ohB/j8ieHTCJ7ERdQFEeIU5JvWA/zu5AStpKbVrqGzPzdCBhbRWP14 oB77AEVAb19NfTImXY474NKYdYh8pcHc6Dx+eLPE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from homer.fritz.box ([185.191.216.125]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MqJqN-1lM5BQ2cXj-00nTYm; Tue, 06 Jul 2021 06:38:35 +0200 Message-ID: Subject: Re: [RFC v2 12/34] mm, slub: move disabling/enabling irqs to ___slab_alloc() From: Mike Galbraith To: Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn Date: Tue, 06 Jul 2021 06:38:33 +0200 In-Reply-To: <20210609113903.1421-13-vbabka@suse.cz> References: <20210609113903.1421-1-vbabka@suse.cz> <20210609113903.1421-13-vbabka@suse.cz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:SoPOq+KD3SxRHu3cf1jBAsXMnKo3MzQ1yoFH9tukdoczdrINLNT 9uZUg0RHltb+UFIpZ7VrF0gh8Z6snGWK9iUVQVBEWYOhEs87mfOjyk5CN1LomZV8cfdEPqi LQH/YmTMX6twRHx7hCDeZY48oDk85l7nhXo29x3pWO1APbzxAj2vukYOyG4C7fLCfG7Ze9P W+beDwDuKwVq7zVJ5mZKA== X-UI-Out-Filterresults: notjunk:1;V03:K0:nuqWi4z6tPE=:SlR2/A5bg92+1/XFOw/JC3 0YT4DrhQZafl2z0EfBHB5kre0Nmr6tIHiS/enoA1jn4h1qptkDX7eqYjgT7IxwCEvwbyWSc3C qp/yE39Q4kNLsCzEzGLyZ3XQWIwFFeLGv5KtawKfHW0bxurZuohc3WKhp/ldOO/hl4dOneoNw WDGe2tQ5flXzbb8K+zfT7IZX07t8QF80l/h+EFkpt6eqwQNQulWyNN2vK1M5X1uJzlT5P0Scm KzrHjBc5VFyI2JplMZRtXk8F2KwAHvUp2BDE47HToQ57HEymOPlxTY1uxyedEsSOj2MC19Jbh o7mmA1sO2ph+U2dUaRiwykCMkzwNVzpWea1CA9yp7qLRM+KfwdSqUnoW3vUHt5Psx2aMMunBl /FbGODXRRE3pp6qBl0PPTdcjNZ6eNCWbDVdZ97Kxgy8yMGnRJa3IMaAMsqFZe3+Z2KFvkfNts 3xs2tgSBae38ExvB4nkfvGesymVP4O16ToRz5pav9vRyZJs04Vyw45b+4pU2hc13/RCXVaASL pZd6sBN9YfCgSiqFjGE35n6stxrkiVqAzjhFmvXIrT7PMiCJ3Oh/jXDQIfsWNU6kB4ceiUUXz yDvRCmOXHVBVBGU0uqbRuRpNK+oRwR/F2Z2ucP7FJm+wGhYCW6vLmGQVS5lL2/uQ0fyY2lh5y pYVpfvoJ4gYdwoLDzT2M049awh4m48fiuvgEuCUV7SnSAL85mp183vj9ge/KrjQ4jpW7MGTC2 KAXycR2kP3hm5e8nGM3EhbrnZSyn7TPW1VU9/navAyH8d69xKxZwfJN4zikp7s76TTjivObgt 7GsPgvqDAn+zaipIvctzCYLV1GcG67/UutAdFpmLyAuBFjTgHxGWU5VxU24wQ8zezwtSJ8+V1 BeiDYU2hUmhxGb0hRbASA+gZkH90wYQYYr3i2jKOdcPfNVHXyPWXBov8dVp8RdMTiTqcpPawU qo9s7h5mMZwy2PyfSVYlmqPRg0zWPlQfaktemrBCDwkp5YAfGDEAehY2Vc4y3kr86y8wMUgMB DaoD7VGuLGHuFcZwl0WErzbmRZhifpsOMM30BHUw1xAoywYJJlwMYPXEv7xvOKeCOzvlB8Ylh 2LMD8Q0akwLbR783ndECAJnt4XrieAq/l/A Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=Y45Unbzp; spf=pass (imf25.hostedemail.com: domain of efault@gmx.de designates 212.227.17.22 as permitted sender) smtp.mailfrom=efault@gmx.de; dmarc=pass (policy=none) header.from=gmx.de X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 00003B000293 X-Stat-Signature: i7bkfcrryreh86kyfp1e4cjr9af8euzw X-HE-Tag: 1625546318-855932 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Greetings, On Wed, 2021-06-09 at 13:38 +0200, Vlastimil Babka wrote: > @@ -3313,6 +3320,8 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, > gfp_t flags, size_t size, > */ > c->tid =3D next_tid(c->tid); > > + local_irq_enable(); > + > /* > * Invoking slow path likely have side-effect > * of re-populating per CPU c->freelist This addition should have been followed by removal of the one in the error path. At the end of the series, RT ends up doing a double local_unlock_irq() instead of post ___slab_alloc() slub_put_cpu_ptr(). -Mike