From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC5CC43462 for ; Thu, 20 May 2021 17:18:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 593B2611ED for ; Thu, 20 May 2021 17:18:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 593B2611ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8E2F18D000D; Thu, 20 May 2021 13:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86CA48D0001; Thu, 20 May 2021 13:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BF818D000D; Thu, 20 May 2021 13:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 34DE88D0001 for ; Thu, 20 May 2021 13:18:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B6FDF824301F for ; Thu, 20 May 2021 17:18:16 +0000 (UTC) X-FDA: 78162267792.21.154BFF7 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf21.hostedemail.com (Postfix) with ESMTP id 1F7CBE00080D for ; Thu, 20 May 2021 17:18:12 +0000 (UTC) IronPort-SDR: Fg4IXyR3WD1Q7VET/+ACIU3eU5JaIbX3HLCar7RTfW8TyOfCBrioPkSsN6Wu5b3l6K7jf6RL1i eGjZ834SO6Gw== X-IronPort-AV: E=McAfee;i="6200,9189,9990"; a="265196564" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="265196564" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 10:18:11 -0700 IronPort-SDR: +Ag2SsApIJEIlKZfue7i6g7Kg5zY9nUKyaziq+N5gU5DS0FMi1OlubULGDUNx+eIrh36+w89Ij 4osxWTb2YRng== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="475283324" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.209.167.234]) ([10.209.167.234]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 10:18:10 -0700 Subject: Re: [PATCH v26 26/30] ELF: Introduce arch_setup_elf_property() To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Mark Brown , Catalin Marinas References: <20210427204315.24153-1-yu-cheng.yu@intel.com> <20210427204315.24153-27-yu-cheng.yu@intel.com> From: "Yu, Yu-cheng" Message-ID: Date: Thu, 20 May 2021 10:18:10 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1F7CBE00080D Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf21.hostedemail.com: domain of yu-cheng.yu@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=yu-cheng.yu@intel.com X-Rspamd-Server: rspam04 X-Stat-Signature: yygxhgs6uoq5xpfpjdpg8m5es1xbkzbw X-HE-Tag: 1621531092-815391 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/2021 2:26 AM, Borislav Petkov wrote: > On Wed, May 19, 2021 at 03:14:58PM -0700, Yu, Yu-cheng wrote: >> However, those parsing functions take (struct arch_elf_state *) as an input. > > Exactly. > >> It probably makes sense to have ARCH_USE_GNU_PROPERTY dependent on >> ARCH_BINFMT_ELF_STATE. It would be ok as-is too. ARM people might have >> other plans in mind. > > Well, let's look at ARM, ARM64 in particular. They have defined struct > arch_elf_state without the ifdeffery in > > arch/arm64/include/asm/elf.h > > and are using that struct in arch_parse_elf_property(). > > And they have selected ARCH_BINFMT_ELF_STATE just so that they disable > those dummy accessors in fs/binfmt_elf.c > > And you're practically glueing together ARCH_BINFMT_ELF_STATE and > ARCH_USE_GNU_PROPERTY. However, all the functionality is for adding > the gnu property note so I think you should select both but only use > ARCH_USE_GNU_PROPERTY in all the ifdeffery in your patch to at least > have this as simple as possible. > ARM64 has ARCH_USE_GNU_PROPERTY and ARCH_BINFMT_ELF_STATE selected unconditionally. We will do the same for X86_64 and remove the ifdeffery. >> I just looked at the ABI document. > > Which document is that? Link? > >> ARM has GNU_PROPERTY_AARCH64_FEATURE_1_AND 0xc0000000 >> >> X86 has: >> GNU_PROPERTY_X86_ISA_1_USED 0xc0000000 >> GNU_PROPERTY_X86_ISA_1_NEEDED 0xc0000001 >> GNU_PROPERTY_X86_FEATURE_1_AND 0xc0000002 > > Our defines should at least have a comment pointing to that document. > > Thx. > The latest pdf's are posted here. https://gitlab.com/x86-psABIs/x86-64-ABI/-/wikis/x86-64-psABI Thanks, Yu-cheng