From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7723C4332F for ; Thu, 8 Dec 2022 15:17:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 314668E0003; Thu, 8 Dec 2022 10:17:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29D5F8E0001; Thu, 8 Dec 2022 10:17:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 118108E0003; Thu, 8 Dec 2022 10:17:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F20FB8E0001 for ; Thu, 8 Dec 2022 10:17:34 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9C3F0C0165 for ; Thu, 8 Dec 2022 15:17:34 +0000 (UTC) X-FDA: 80219493228.09.AC02E8C Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf23.hostedemail.com (Postfix) with ESMTP id 0222114000C for ; Thu, 8 Dec 2022 15:17:31 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HgxSklxt; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670512652; a=rsa-sha256; cv=none; b=U8XF9Xz2RK+xkgmVNgjI/GyCi96y7u8j7VXD5Y2Pj1Jx9XNyVp39oSe33rz0dqWcyNu8nj KmTh/3QWFf+lECAek+mUTB7rV1h6hnJEx6VPun0ZIHgT13t3WfAw6N+rjCDHpX/snY2Smi pdwoRz76orhrHORoyMKxtn6sb1dC3BE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HgxSklxt; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670512652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FkvG5yTXclF9+g/2EkMbO7vGwoHB6cevpsYBKw0wTVc=; b=5vdq69sjkaBB7JBhpn7KFXvayqIEtZ0OVCsEdY4PTEr1fAa/Wu/skAA7OXPWrwtJBYWxqm iGToj/JUHh85d41niQ05c17gH6/uxuAnDzEvkV+bGwVlHW5UXhbOmVjhK5OFbfvuUxONYf emOMwK17wC66E+Ot1k2QD3O0lxjATZw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670512652; x=1702048652; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=sjIdGJ3dFJPHY95KafrCNYiB0J29f+N6H9kF/DT80ck=; b=HgxSklxtvGjPe7FNdHSf286xRbD4w+mqKwEuYNN1Oebx96UkTIlNdfM2 6hSP/K1U8/VkLZbiFIshxToZXrIDrU94uvE9vlexyHA8YGgrxyWYmfqVt 6OfPA3b8ZBFpW8WZYZK9EP7CugW5f0jOFuGxjGgzKjXHZ6+6pWQrwzSbY /2CdOB5BcMQSpLLZaI6r4xOubeVUFF+YSExl5oNL6Rtbd1f72GA6i+Lxc LR4xWYhvSy3kXvsISeq7SybPtA4JHF95LDMTbCatQcsOLi1hUBh2O2kB+ U74X8tQZ5KUc77BBZbjIUqvpvmQ3scfB/Q8OWcVfyLgwDKRf6HKr5DaqG A==; X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="300621618" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="300621618" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 06:58:12 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="771505225" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="771505225" Received: from mbielby-mobl.amr.corp.intel.com (HELO [10.209.7.219]) ([10.209.7.219]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 06:58:11 -0800 Message-ID: Date: Thu, 8 Dec 2022 06:58:09 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v7 11/20] x86/virt/tdx: Add placeholder to construct TDMRs to cover all TDX memory regions Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "Shahar, Sagi" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <32c1968fe34c8cf3cb834e3a9966cd2a201efc5b.1668988357.git.kai.huang@intel.com> <6d4d429a-ade2-771d-0e4c-788bef45041a@intel.com> <35aee96c1bb56322191ae442f3928d7dff064a92.camel@intel.com> <9a653cd2-70df-8c55-ac7d-5ddcb3b18b0c@intel.com> <60deb2ffe15e71bc91727aa04298c79f21a58c83.camel@intel.com> <02d2a49cbd319814a7afdf57ca3cc9809123952a.camel@intel.com> <98935273b05feb55fc52c69a48d31018e0124e58.camel@intel.com> <702c11db9820a074aee31c2958a565b21299607f.camel@intel.com> From: Dave Hansen In-Reply-To: <702c11db9820a074aee31c2958a565b21299607f.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0222114000C X-Stat-Signature: ikgd8hb9brxacfnquq6ckg7p3tgp6i3c X-HE-Tag: 1670512651-314954 X-HE-Meta: U2FsdGVkX1+OOOpmdLrHu0jyLeNeIahR8gzQdyRucTbhQi6Lyw5IppetXX7xzARJ085ubOFtJbWtuHYvG/t7YutuNd7TwqXS2Xc/I/T4MmNwXTAQg2WPs4dAL4MQk08/4R2OqzVvdDbcaUzCLnX1OC35sKHIcDrn9mMPrnjzmyexwHdAru+meEgRVRzW6wAPLMqFC4Duz08zmWpSnNoIQdgn4X+gPYRsIcQMuf65ozwXEmLkvwy1531SXPPGIbcMuTKXRgFJmcaVH6M/QXJI9W9gGxEmWY7P9FDqOONEAv07v2e5W6m+dOU6/uhplUerlI5MZKJ1jZklJK5KSU8QKx3FXszmKMitXmwNx8cfjFMlavVvFdRU6hD7Z7QK1xdP9ozm2JoUlqWUT8v0xrEPAaCo7L79l8Ya+/bXb5Y8zU4xMXxSNBnnzJc7/6YPy23owM+vb54SRbpEkFOXHBpA75b3jHRYBCo4auu8yfwZEPsJMfnUDKqODjbi9S9A2+b1FsceRnk9exkRT87f94sw8MAsqjglXO5jGRs3VXNwDbw/x1k9RYKaFtAYoWj/PuunvZz/uRnOz5Q+NecdpPW4OuMBHC/+UvC/85JA+OEuvjzci6OeKSJIssfN4KEY5anCxc8hTHsWdW50PdQ2AXEgOdjhAivWM0kl18kyT8Zl9giMoRTpP+YhWandk56lsN7h6n69BIgp30IgqIHgQIzS3kxLO1omtnP6LwDJltwWgUR+oHJlS1q+RvfsEVBVB+HkBO04doXHt7qhSq9DWtqMLHXhbhAndDwlhcZksygjtGzM0HMRzBMRusanhLzAp2kH71dX6i83ryVqNtF8Vc5+8XkqVDo8iRZ7keDqe2QiBZohth47xhU2e3Uc7+8s0KJvVutyXJ+TvTkANbD7509/rQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003715, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/8/22 04:56, Huang, Kai wrote: > I haven't looked into the reason yet but I suspect the address isn't aligned (I > used __pa() to get the physical address). I'll take a look and report back. > > In the meantime, do you have any comments? Should I still pursue to keep them > as local variable on the stack? Yes, you should investigate the reason for the failure and try to understand both the success and the failure cases.