From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3EFEC2D0F9 for ; Wed, 13 May 2020 08:58:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 86403206F5 for ; Wed, 13 May 2020 08:58:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86403206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 090B5900117; Wed, 13 May 2020 04:58:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01A9D9000F3; Wed, 13 May 2020 04:58:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2431900117; Wed, 13 May 2020 04:58:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id C681E9000F3 for ; Wed, 13 May 2020 04:58:20 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 89B07759C for ; Wed, 13 May 2020 08:58:20 +0000 (UTC) X-FDA: 76811094360.08.line09_2bad6d8465017 X-HE-Tag: line09_2bad6d8465017 X-Filterd-Recvd-Size: 3748 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 May 2020 08:58:20 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DA7AAB03A; Wed, 13 May 2020 08:58:20 +0000 (UTC) Subject: Re: [PATCH v3 5/5] lib/test_sysctl: support testing of sysctl. boot parameter To: Luis Chamberlain Cc: Andrew Morton , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner , Masami Hiramatsu References: <20200427180433.7029-1-vbabka@suse.cz> <20200427180433.7029-6-vbabka@suse.cz> <20200427183913.GH11244@42.do-not-panic.com> <028d1996-9f4c-20c6-fb2a-706baa919dde@suse.cz> <20200511183155.GT11244@42.do-not-panic.com> From: Vlastimil Babka Message-ID: Date: Wed, 13 May 2020 10:58:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200511183155.GT11244@42.do-not-panic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/11/20 8:31 PM, Luis Chamberlain wrote: > On Mon, May 11, 2020 at 01:05:22PM +0200, Vlastimil Babka wrote: >> ----8<---- >> From a999e993a89e521b152bbd4b1466f69e62879c30 Mon Sep 17 00:00:00 2001 >> From: Vlastimil Babka >> Date: Mon, 11 May 2020 12:59:49 +0200 >> Subject: [PATCH] lib/test_sysctl: support testing of sysctl. boot parameter - >> fix >> >> Skip the new test if boot_int sysctl is not present, otherwise, per Luis, >> "This would fail if someone uses this script to test an older kernel, and >> the scripts in selftests are supposed to work with older kernels." >> >> Suggested-by: Luis Chamberlain >> Signed-off-by: Vlastimil Babka >> --- >> tools/testing/selftests/sysctl/sysctl.sh | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/tools/testing/selftests/sysctl/sysctl.sh >> index ef6417b8067b..148704f465b5 100755 >> --- a/tools/testing/selftests/sysctl/sysctl.sh >> +++ b/tools/testing/selftests/sysctl/sysctl.sh >> @@ -756,6 +756,11 @@ sysctl_test_0006() > > You want to: > > > # Kselftest framework requirement - SKIP code is 4. > ksft_skip=4 > >> sysctl_test_0007() >> { >> TARGET="${SYSCTL}/boot_int" >> + if [ ! -f $TARGET ]; then >> + echo "Skipping test for $TARGET as it is not present ..." >> + return 0 >> + fi > > And return 4 instead. If I return it from the function, nobody will care, AFAICS. If I 'exit $ksft_skip', is that correct if it's just a single test out of 7? What's the proper way? Thanks > Luis >> + >> if [ -d $DIR ]; then >> echo "Boot param test only possible sysctl_test is built-in, not module:" >> cat $TEST_DIR/config >&2 >> -- >> 2.26.2 >> >