From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Qian Cai <cai@lca.pw>, Alexey Dobriyan <adobriyan@gmail.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Toshiki Fukasawa <t-fukasawa@vx.jp.nec.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Anthony Yznaga <anthony.yznaga@oracle.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>,
Logan Gunthorpe <logang@deltatee.com>,
Ira Weiny <ira.weiny@intel.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v1] mm: Fix access of uninitialized memmaps in fs/proc/page.c
Date: Wed, 9 Oct 2019 15:32:46 +0200 [thread overview]
Message-ID: <d1516f32-8031-8ad2-7d69-1272b5ee480e@redhat.com> (raw)
In-Reply-To: <20191009132950.GB6681@dhcp22.suse.cz>
On 09.10.19 15:29, Michal Hocko wrote:
> On Wed 09-10-19 15:24:05, David Hildenbrand wrote:
>> On 09.10.19 15:22, Michal Hocko wrote:
>>> On Wed 09-10-19 14:58:24, David Hildenbrand wrote:
>>> [...]
>>>> I would be fine with this, but it means that - for now - the three
>>>> /proc/ files won't be able to deal with ZONE_DEVICE memory.
>>>
>>> Thanks for the clarification. Is this an actual problem though? Do we
>>> have any consumers of the functionality?
>>>
>>
>> I don't know, that's why I was being careful in not changing its behavior.
>
> Can we simply go with pfn_to_online_page. I would be quite surprised if
> anybody was really examining zone device memory ranges as they are
> static IIUC. If there is some usecase I am pretty sure we will learn
> that and can address it accordingly.
>
I consider it mostly a debug interface either way. Will rework, test and
resend. Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-10-09 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 9:12 [PATCH v1] mm: Fix access of uninitialized memmaps in fs/proc/page.c David Hildenbrand
2019-10-09 9:37 ` Michal Hocko
2019-10-09 10:19 ` David Hildenbrand
2019-10-09 11:24 ` Michal Hocko
2019-10-09 12:58 ` David Hildenbrand
2019-10-09 13:22 ` Michal Hocko
2019-10-09 13:24 ` David Hildenbrand
2019-10-09 13:29 ` Michal Hocko
2019-10-09 13:32 ` David Hildenbrand [this message]
2019-10-09 9:57 ` Naoya Horiguchi
2019-10-10 7:30 ` David Hildenbrand
2019-10-11 0:11 ` Naoya Horiguchi
2019-10-11 0:50 ` Naoya Horiguchi
2019-10-11 9:53 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1516f32-8031-8ad2-7d69-1272b5ee480e@redhat.com \
--to=david@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anthony.yznaga@oracle.com \
--cc=cai@lca.pw \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=koct9i@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mhocko@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=t-fukasawa@vx.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).