From: Rik van Riel <riel@surriel.com>
To: Ivan Babrou <ivan@cloudflare.com>,
linux-mm@kvack.org, Mel Gorman <mgorman@techsingularity.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
kernel-team <kernel-team@cloudflare.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: Reclaim regression after 1c30844d2dfe
Date: Fri, 07 Feb 2020 18:05:08 -0500 [thread overview]
Message-ID: <d17a44fd064998729ca78193071a6d993b7047dc.camel@surriel.com> (raw)
In-Reply-To: <CABWYdi1eOUD1DHORJxTsWPMT3BcZhz++xP1pXhT=x4SgxtgQZA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]
On Fri, 2020-02-07 at 14:54 -0800, Ivan Babrou wrote:
> This change from 5.5 times:
>
> * https://github.com/torvalds/linux/commit/1c30844d2dfe
>
> > mm: reclaim small amounts of memory when an external fragmentation
> > event occurs
>
> Introduced undesired effects in our environment.
>
> * NUMA with 2 x CPU
> * 128GB of RAM
> * THP disabled
> * Upgraded from 4.19 to 5.4
>
> Before we saw free memory hover at around 1.4GB with no spikes. After
> the upgrade we saw some machines decide that they need a lot more
> than
> that, with frequent spikes above 10GB, often only on a single numa
> node.
>
> We can see kswapd quite active in balance_pgdat (it didn't look like
> it slept at all):
>
> $ ps uax | fgrep kswapd
> root 1850 23.0 0.0 0 0 ? R Jan30 1902:24
> [kswapd0]
> root 1851 1.8 0.0 0 0 ? S Jan30 152:16
> [kswapd1]
>
> This in turn massively increased pressure on page cache, which did
> not
> go well to services that depend on having a quick response from a
> local cache backed by solid storage.
>
> Here's how it looked like when I zeroed vm.watermark_boost_factor:
We have observed the same thing, even on single node systems.
I have some hacky patches to apply the watermark_boost thing on
a per pgdat basis, which seems to resolve the issue, but I have
not yet found the time to get the locking for that correct.
Given how rare the watermark boosting is, maybe the answer is
just to use atomics? Not sure :)
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-07 23:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 22:54 Reclaim regression after 1c30844d2dfe Ivan Babrou
2020-02-07 23:05 ` Rik van Riel [this message]
2020-02-08 9:08 ` Vlastimil Babka
2020-02-08 11:11 ` Hillf Danton
2020-02-11 10:16 ` Mel Gorman
2020-02-12 22:45 ` Ivan Babrou
2020-02-12 23:55 ` Mel Gorman
2020-02-18 22:07 ` Ivan Babrou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d17a44fd064998729ca78193071a6d993b7047dc.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=ivan@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).