From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=2lSW=4T=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 02C1FC3F2D1
	for <linux-mm@archiver.kernel.org>; Mon,  2 Mar 2020 23:42:45 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id B514E2465E
	for <linux-mm@archiver.kernel.org>; Mon,  2 Mar 2020 23:42:44 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="OnqzzuBg"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B514E2465E
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 393676B0005; Mon,  2 Mar 2020 18:42:44 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 343F56B0006; Mon,  2 Mar 2020 18:42:44 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 20BE56B0007; Mon,  2 Mar 2020 18:42:44 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95])
	by kanga.kvack.org (Postfix) with ESMTP id 093EB6B0005
	for <linux-mm@kvack.org>; Mon,  2 Mar 2020 18:42:44 -0500 (EST)
Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay02.hostedemail.com (Postfix) with ESMTP id EC91CBEE6
	for <linux-mm@kvack.org>; Mon,  2 Mar 2020 23:42:43 +0000 (UTC)
X-FDA: 76552049406.06.crack67_51f700833df1a
X-HE-Tag: crack67_51f700833df1a
X-Filterd-Recvd-Size: 4798
Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65])
	by imf15.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Mon,  2 Mar 2020 23:42:43 +0000 (UTC)
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
	id <B5e5d99e30000>; Mon, 02 Mar 2020 15:42:27 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 02 Mar 2020 15:42:41 -0800
X-PGP-Universal: processed;
	by hqpgpgate101.nvidia.com on Mon, 02 Mar 2020 15:42:41 -0800
Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 2 Mar
 2020 23:42:41 +0000
Subject: Re: [PATCHv5 0/3] fix omission of check on FOLL_LONGTERM in gup fast
 path
To: Pingfan Liu <kernelfans@gmail.com>, <linux-mm@kvack.org>
CC: Ira Weiny <ira.weiny@intel.com>, Andrew Morton
	<akpm@linux-foundation.org>, Mike Rapoport <rppt@linux.ibm.com>, Dan Williams
	<dan.j.williams@intel.com>, Matthew Wilcox <willy@infradead.org>, Aneesh
 Kumar K.V <aneesh.kumar@linux.ibm.com>, Keith Busch <keith.busch@intel.com>,
	Christoph Hellwig <hch@infradead.org>, Shuah Khan <shuah@kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <1582889550-9101-1-git-send-email-kernelfans@gmail.com>
From: John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <d1fbea67-5047-206f-62df-4c3317bfd5fd@nvidia.com>
Date: Mon, 2 Mar 2020 15:42:40 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <1582889550-9101-1-git-send-email-kernelfans@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1583192548; bh=MfSVA2E+Wzo7k4JOfkURCKkqFp1vH9FpYvZytNvgyKo=;
	h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
	 Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
	 X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
	 Content-Transfer-Encoding;
	b=OnqzzuBgc4//rABV7d8+PuBXSCc3o5a3Gb8sqdifRCooblxlv9KlV+ORhXaXSdsTp
	 dCujhxGx2LBaziGB1cW3cfGhB1Tw7HG3btezyRF7SAboM2SdcuFbpTH7OalDlI0aGK
	 PDZomvYfM6hPrChGBqj908ZooYqCbttjnGQQcf5zyTS3mAqKQpTPOUdd2hRWR5O9Oy
	 f6ODsOMCHoV0aHiyQhfHz7nT6cSJSDb6hg/qFqZ+89qxbbobwBp/xcYY6Pr/nnV5wM
	 AQCZpcLLv/5ToCt9HXa+TLWhcTKteIa2H9uM+RVXfoSqXsM1A9PZQ2fSyp7wLyO/qQ
	 G+5ikelJeUj7A==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 2/28/20 3:32 AM, Pingfan Liu wrote:
> The last V4 series:
> https://lore.kernel.org/patchwork/project/lkml/list/?series=397950, and be
> dropped from mm tree due to conflict with "RFC: switch the remaining
> architectures to use generic GUP" [1]
> 
> I rebase it and sent out V5.
> V4 -> V5: move around the patched code due to code change.
> 
> [1]: https://lore.kernel.org/linux-mm/20190601074959.14036-1-hch@lst.de/ 
> 

Hi,

This whole series conflicts pretty significantly with the upcoming "track
FOLL_PIN pages" patch series that is in mmtom. Can you please try to resolve
this a bit more? In other words:

The easiest way is to rebase against mmotm and target Linux 5.7, but I'm assuming
that since you've based this on today's linux.git (5.6-rc*), you want this to go
into 5.6,right?

If that's the case, then let's find the minimal fix for 5.6, and put the remaining
stuff (name changes, etc) into mmotm where it will have to fit in with the other
upcoming changes, please.


thanks,
-- 
John Hubbard
NVIDIA

> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> Cc: Keith Busch <keith.busch@intel.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Shuah Khan <shuah@kernel.org>
> To: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> 
> ---
> Pingfan Liu (3):
>   mm/gup: rename nr as nr_pinned in get_user_pages_fast()
>   mm/gup: fix omission of check on FOLL_LONGTERM in gup fast path
>   mm/gup_benchemark: add LONGTERM_BENCHMARK test in gup fast path
> 
>  mm/gup.c                                   | 46 +++++++++++++++++++-----------
>  mm/gup_benchmark.c                         |  7 +++++
>  tools/testing/selftests/vm/gup_benchmark.c |  6 +++-
>  3 files changed, 41 insertions(+), 18 deletions(-)
>