From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A54B7C55186 for ; Thu, 23 Apr 2020 01:21:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 676912076C for ; Thu, 23 Apr 2020 01:21:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 676912076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D4198E0007; Wed, 22 Apr 2020 21:21:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 086328E0003; Wed, 22 Apr 2020 21:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB59A8E0007; Wed, 22 Apr 2020 21:21:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id D11548E0003 for ; Wed, 22 Apr 2020 21:21:18 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 90D76181AEF09 for ; Thu, 23 Apr 2020 01:21:18 +0000 (UTC) X-FDA: 76737366636.21.jump86_7fcbab37fa44d X-HE-Tag: jump86_7fcbab37fa44d X-Filterd-Recvd-Size: 3248 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Apr 2020 01:21:18 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id x77so2100396pfc.0 for ; Wed, 22 Apr 2020 18:21:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HuA0hxQTe90PJtZs9WSSy8kDWUbxSlnvi9VsPza7S2Y=; b=ONoeGRC+Eahwo+V7ofbVcaTJxRogCSfHp8lSi1FPtsAIJGA9aFMjhnX3BayCWyFQZk 2qjqVIvs5p5Tu5SA4NAudFQjSI3xuuCvtaBvNiV7PDWjOZTxCObjtFSn3tJCiixWc4lk ymXc1bySPYr3J0wyMISscjQ8332QK8rDhkY9Zwm/B6qhx3u7QErSASyxS9x3OM57CJ9+ chJOAys1Wl26rU4kBEaGZBebU7sNEvYuWjOoHDpAzaP9O8XvrBj0xClBuMoqE13p+Eln 2gfJuZZSSpiuKUdphGJJAevOtoQXBR9lbREluY2A7pdvpBKQLusWnPkWVUVCjB/BbNv9 9Sug== X-Gm-Message-State: AGi0Pua4k5NEGcCMPMULmf6phKDDNkk6EonTNZY7I4iui0kl25Vs2Xtr 2X0qadlqU2jbnemHNxjmJQs= X-Google-Smtp-Source: APiQypKxBlGRT0F6vEFPhi5oneOUM697xMXU65q00ggKMra7UIbFqy/Kx++vjPJ34SrVHIxn8OpClA== X-Received: by 2002:aa7:80cf:: with SMTP id a15mr1441540pfn.124.1587604876968; Wed, 22 Apr 2020 18:21:16 -0700 (PDT) Received: from [100.124.12.67] ([104.129.198.222]) by smtp.gmail.com with ESMTPSA id n23sm471545pjq.18.2020.04.22.18.21.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2020 18:21:16 -0700 (PDT) Subject: Re: [PATCH v2] stacktrace: cleanup inconsistent variable type To: Walter Wu , Matthias Brugger , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Josh Poimboeuf , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream References: <20200421013511.5960-1-walter-zh.wu@mediatek.com> From: Bart Van Assche Message-ID: Date: Wed, 22 Apr 2020 18:21:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200421013511.5960-1-walter-zh.wu@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/20/20 6:35 PM, Walter Wu wrote: > Modify the variable type of 'skip' member of struct stack_trace. > In theory, the 'skip' variable type should be unsigned int. > There are two reasons: > - The 'skip' only has two situation, 1)Positive value, 2)Zero > - The 'skip' of struct stack_trace has inconsistent type with struct > stack_trace_data, it makes a bit confusion in the relationship between > struct stack_trace and stack_trace_data. Reviewed-by: Bart Van Assche