From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB282C6FD1F for ; Sun, 19 Mar 2023 06:18:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02107900003; Sun, 19 Mar 2023 02:18:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F13CE900002; Sun, 19 Mar 2023 02:18:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDC57900003; Sun, 19 Mar 2023 02:18:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D09E3900002 for ; Sun, 19 Mar 2023 02:18:27 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9CD8A40789 for ; Sun, 19 Mar 2023 06:18:27 +0000 (UTC) X-FDA: 80584643454.25.521EC28 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf17.hostedemail.com (Postfix) with ESMTP id B536640004 for ; Sun, 19 Mar 2023 06:18:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hjWICnSU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679206705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xhqo9SbWO6qq+Q6ia+mS1H3WpBHGnRuwtscD7xGcrHs=; b=rpbfxSB7cEqGBJCnZPYKNXFT8QB4GQHuITBxeDjDWS5LxWillGuqUbIWOZpao7tJJj4pCS IyJfYvbWki+wB1uUZlmlomexsPCWk3XT26z8vx0GV7tUtDHY8OoOtR7Dyb0FJ1jY2wGZs7 iSibnFS3ZoqpL4+lK/Vkmh3MInKxgkY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hjWICnSU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679206705; a=rsa-sha256; cv=none; b=xAA4qpYWwitx0QVl7Prwdmb82P/IX+Yt3gKJLdAwdv9PnXjA0NGgQJJEzjoDnViG/z/ZqO deYIoqN6GS9E2zJORlhr5ml9DufC3/WSxSveGRSrcve9sMyBbLJVQp1UJPIgbiuhUwUnvb BlUgK6qme4/xeL1CPe7vURE4oDKcMAQ= Received: by mail-wm1-f45.google.com with SMTP id p16so5570283wmq.5 for ; Sat, 18 Mar 2023 23:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679206704; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xhqo9SbWO6qq+Q6ia+mS1H3WpBHGnRuwtscD7xGcrHs=; b=hjWICnSUfd0FkUjbaUaU1k+9N+t8FYxO+nuJ9xLlmVvPlAECNGAK9WTDaxxMKjd9m5 wYwSJ3RMS5bM4TYXF5vkL/6Lxg9regvlkqPvb5Hm29Zx8AF/XFWoMaYDABSM8o1h9EpA wIL0wqxOlvspIY47Fi+6nAi4bWher6S0Vp/4eKy6q2i+c2dnLN9M+uMI1sNx+fX0W/e7 eksq1Hlo9g4x1yhs+DHG/s1c+kUO9dCgpePvrtJmPoBEspRFt2TGOjd0/72bxtN1ZbBU B1x99P0gFZDJPcRGYNaNqyvykcUY3iSMAQUIXHnLRhl03BNIbErH2QTncAeiKsH7TOUI KoFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679206704; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xhqo9SbWO6qq+Q6ia+mS1H3WpBHGnRuwtscD7xGcrHs=; b=YLpYB8tE0CHfhn5Uj8lVcRiBw17fo3G+cvlUXjAHQYLiSp8O5h3aNeGLKiMVLwwJsj e6cFBPg5FbXWgurI97nERF+N17elpmlij4xzUqiJQ+QBmU5YDZ162FHP1Y/VobXSTl7T UvRkCMWvDFVuGvQ/cZN4DddXAXU3lKv0iyw2sOr4cfB6Sy6GDoVXZV7r2UVA7doJ1zCi xNlG5BhA3HJmKEKBwDnqyrLjyl1yurr5IrA6YhO66vZcdaVzA5MX4/SHmBht7HGuc2z7 9A4pNF3yjRIwwWCJ7tzU+hbuaQycqEteuF7Mm7Hw7rclruQOyxgRG1PbDpvLk8RipdsZ TuzQ== X-Gm-Message-State: AO0yUKU2CGkdg82f1pfy58LPqEqyJFmFENDa701nensVjXQF9mwiUon5 Tm5oM7Q1mqbkq/jFWcM8jzIGMJuOa80= X-Google-Smtp-Source: AK7set9KqR9HZ0+RJIp4qsI7IbQOymXJCYcLZalOuh1caFBzureR/W9BTPBITqoJSweFKvxCR3hhuQ== X-Received: by 2002:a05:600c:190c:b0:3e1:fc61:e0e5 with SMTP id j12-20020a05600c190c00b003e1fc61e0e5mr27919904wmq.33.1679206704320; Sat, 18 Mar 2023 23:18:24 -0700 (PDT) Received: from localhost (host86-146-209-214.range86-146.btcentralplus.com. [86.146.209.214]) by smtp.gmail.com with ESMTPSA id e8-20020adffd08000000b002c592535839sm5868560wrr.17.2023.03.18.23.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 23:18:23 -0700 (PDT) Date: Sun, 19 Mar 2023 06:16:13 +0000 From: Lorenzo Stoakes To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Baoquan He , Uladzislau Rezki , David Hildenbrand , Liu Shixin , Jiri Olsa Subject: Re: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() Message-ID: References: <119871ea9507eac7be5d91db38acdb03981e049e.1679183626.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B536640004 X-Stat-Signature: 9p6zdoyajh991x6nxdy4qy97xa8b6mcy X-HE-Tag: 1679206705-694855 X-HE-Meta: U2FsdGVkX197iq3Z77M6mSz92T/Ltdnd55OnuOfmyeFl5/HG7ODtVmt3vn5yKaCYnm6hyVt6X4SFvItqLqx7BFU0GP5yJL05gETMmwc48K0Cs/D6WwpOExink0eKF3rbADE/OStkTrlPitF2+wilJT++cu4p8pDoHpMg0aQ9bG7eKcTW+hXAM0Ce+E3DBFKtPkwPYdM0NLOnVcXtbYpWeXC7807lk3qnPPVcFwtM9w9AlfbQ1E7MIjaNl1eiodgECvYSbMJSj4kqr1W3RNDj/QJfsx16XwWHs2QZ+LXe7vms61mQs+bji+dAVhp5Ho7A0nq/rPwIHjJLpo3epDcJ7WLdqy/7FGFdTwDIDYQIhXHx4LD2Nj5A6c7yi+dAdwzvgI/R56couy30TsPi7eUisDo0WlyMV8x41ws2fIWsLQAW+9i0TGw5KUDu9cWYzlZOzYZ90jNAjmuTo4UGseC4bpxbs6uvy/iIJXQR1y/mJ05aWA5Ud17YlOtE0xp6qRulgUe6Qp7LozxxJ7eIF4ok8Rey+JBN2F8gE7ZYBa+YK5N42fWUyTJnIcozLpFXjmSDWynKfxjuZ5fcnAvyKQO7lvlcB51Xc/2he4qGYMro1dBX4Vui2cJB/VxmmszhKAW3Rq/58aCpUhmF+WuktTX2lzAHK7tLNA7iR0VA96vZ8Sp5DWN3uutsA9AWqy7Hhtpt3XzwU5ZgnOF3eQQlOpvU3DBoYd3uvfzUFh7jokcFIfcepQkCTnMa9Bh9bySz8gKhLTApiQyo7W4CfVjD8hWzEvdSzHNSW0w6qVM5HefGEcTpUZ38Ptygf/0o9CdWrE6sH39+4rhsyBMjmExkbGszEpv31G9lfSOlLRKRayMC1lNiaUaVNvv21WM9fKpcfUTtBXZvvI6e+79cAbtJNN8Sv/VigZJ5IF0ecN5KDPitpMqf5kKpaRvYTNj3rRFwQ1ZektOOwOTpjVq+CKTGSPR ++K/l9ZY R96QpvsagTMgb6Cl6pm/Za4D6R3s/BuplRNqjc7ISQPjWVZf7W0YPIJ73OJ+EVrTeTKMcQvdhgEriE3KqNJKxb4VA6cUfwOzXGlkfg7Z1+Gcvj+AqDetJvfqLRoxSYWIk7uBo3RW/13R1fPNaoYdSVgeVuEG1OwuCkLSJiluPyPm4Wdlg2VZxJ7i44haCLb7rv+eYLJdW3sDUQ2oRZP79gdvgbVYqz5L7mzwZKKPgq3nvxxDqsattQSJ+RK6U+fb6jMhtDH8qSzsIJbAfuoqdl+TG8AkMgBS4sdKzjdrIR9UmI5rKlxoBE190kGHC9Ku51tA9WJRWj0GFTnbwruVB+CCJBxc2XsPQM2fX6FK3XJ83Sz8P9/MUnBv+HQinxd7iD3F8eGwfn8Z64/w8q6OmlAMbg7I/3XrMe2XktOcBs8IMvCeHP8mjzOV68XPXkucPksvF8PxeUXXzFdE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 19, 2023 at 02:50:56AM +0000, Matthew Wilcox wrote: > On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote: > > /* for /proc/kcore */ > > -extern long vread(char *buf, char *addr, unsigned long count); > > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter); > > I don't love the order of the arguments here. Usually we follow > memcpy() and have (dst, src, len). This sometimes gets a bit more > complex when either src or dst need two arguments, but that's not the > case here. Indeed it's not delightful, I did this purely to mimic the order of copy_to_iter() and friends which place iter last, however on second thoughts I think placing iter first would be better here where we have the freedom to order things more sensibly. I'll respin with a fix.