From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
<lkp@lists.01.org>, <lkp@intel.com>,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [PM] bfcc1e67ff: kernel-selftests.breakpoints.step_after_suspend_test.fail
Date: Fri, 15 Oct 2021 20:45:38 +0200 [thread overview]
Message-ID: <d3cf18f1-2af7-5e4d-abe4-c882f25bd5c3@intel.com> (raw)
In-Reply-To: <6755cf07-fa5a-cbb7-c076-57c162a08c99@gmail.com>
On 10/14/2021 11:55 PM, Florian Fainelli wrote:
> On 10/14/21 12:23 PM, Rafael J. Wysocki wrote:
>> On 10/14/2021 6:26 PM, Florian Fainelli wrote:
>>> On 10/14/21 12:57 AM, kernel test robot wrote:
>>>> Greeting,
>>>>
>>>> FYI, we noticed the following commit (built with gcc-9):
>>>>
>>>> commit: bfcc1e67ff1e4aa8bfe2ca57f99390fc284c799d ("PM: sleep: Do not
>>>> assume that "mem" is always present")
>>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
>>>>
>>>>
>>>> in testcase: kernel-selftests
>>>> version: kernel-selftests-x86_64-c8c9111a-1_20210929
>>>> with following parameters:
>>>>
>>>> group: group-00
>>>> ucode: 0x11
>>>>
>>>> test-description: The kernel contains a set of "self tests" under the
>>>> tools/testing/selftests/ directory. These are intended to be small
>>>> unit tests to exercise individual code paths in the kernel.
>>>> test-url: https://www.kernel.org/doc/Documentation/kselftest.txt
>>>>
>>>>
>>>> on test machine: 288 threads 2 sockets Intel(R) Xeon Phi(TM) CPU 7295
>>>> @ 1.50GHz with 80G memory
>>>>
>>>> caused below changes (please refer to attached dmesg/kmsg for entire
>>>> log/backtrace):
>>>>
>>>>
>>>>
>>>>
>>>> If you fix the issue, kindly add following tag
>>>> Reported-by: kernel test robot <oliver.sang@intel.com>
>>> Thanks for your report. Assuming that the code responsible for
>>> registering the suspend operations is drivers/acpi/sleep.c for your
>>> platform, and that acpi_sleep_suspend_setup() iterated over all possible
>>> sleep states, your platform must somehow be returning that ACPI_STATE_S3
>>> is not a supported state somehow?
>>>
>>> Rafael have you ever encountered something like that?
>> Yes, there are systems with ACPI that don't support S3.
> OK and do you know what happens when we enter suspend with "mem" in
> those cases? Do we immediately return because ultimately the firmware
> does not support ACPI S3?
"mem" should not be present in the list of available strings then, so it
should be rejected right away.
> I will rework
> tools/testing/selftests/breakpoints/step_after_suspend_test.c not to
> assume that "mem" is always available, since it may not be.
next prev parent reply other threads:[~2021-10-15 18:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 7:57 [PM] bfcc1e67ff: kernel-selftests.breakpoints.step_after_suspend_test.fail kernel test robot
2021-10-14 16:26 ` Florian Fainelli
2021-10-14 19:23 ` Rafael J. Wysocki
2021-10-14 21:55 ` Florian Fainelli
2021-10-15 18:45 ` Rafael J. Wysocki [this message]
2021-10-15 19:40 ` Florian Fainelli
2021-10-19 18:53 ` Rafael J. Wysocki
2021-10-19 19:03 ` Florian Fainelli
2021-10-20 13:49 ` Rafael J. Wysocki
2021-10-20 15:34 ` Florian Fainelli
2021-10-20 16:00 ` Rafael J. Wysocki
2021-10-20 18:17 ` Florian Fainelli
2021-10-20 18:48 ` Rafael J. Wysocki
2021-10-21 19:19 ` Florian Fainelli
2021-10-22 14:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3cf18f1-2af7-5e4d-abe4-c882f25bd5c3@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).